Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2294262imm; Sat, 12 May 2018 09:10:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrXzcl7XRj9+1vS/NkLcUavBsQ7cgCHJ/G88FJ3u23E59bwbLvW6qnw0os7eyiAOMRpV3v1 X-Received: by 2002:a62:6c3:: with SMTP id 186-v6mr3577233pfg.151.1526141448017; Sat, 12 May 2018 09:10:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526141447; cv=none; d=google.com; s=arc-20160816; b=bEMGAHGEon48VyJTV9vkObOp8Fdd2QFA0WOuDXGY+N9SPI/d9C11sgDW1yKChQn5DB gRu0+UvaEyLoU9XOA60bAlV/aEcnmXDcet1kcRvxv9oJkQ4RRCeNjI91kDByYsIH0cSv 1NYD2MENwHeJb2qxLJKVoniUc8uhrYJjvgIK3p2eAUjEgnnFOxdQeSAL54rFzCT5K6AJ oPzppp6yuuWL48N/sThPS8m3VYJXMPr6z+geWqSeSIZ64pieyV3dVmOqE/PiwPYM9h4A 4R6LszvzmK62ZCr5Xhe+p7iugqLnd5LQ7Zw6or1b7qHH6WnnyOoerIXlg4ghnOEyhoZ7 MHIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=+d2iDyf3jJBs5s3Lf44v//cavwal9DnS42pfFwy6l9k=; b=t/gGLR6qD6OKJMWT8Gtp17lFeQ48aZpJ/8565pGhbzOPbIfJyFxkMaxD2e+8WWYPMr 7YLvDUry8LiR8dHnZiukXUC3BjBCfOEPVdg5OwE2aX49w2Gga33KkIhv8MYPVlQS4m/B 9vujF2JfHXRjEussChD/QeFVctXG5y/GrtySv40ngS4ZIKuFzx7iC6B8gbDhtj0cBjmR iisBHAPcXhVdzpbZUrGzI6EdkyGQzluGX5xdj8lcqItvffxHGx0u8xE5Bx5SAVXP189x ggOOTSEXayu3rPiLWgdPdvCulra51lMOmuluQNMC90DfZChSwfY9KlcniD7kXRbIXmr6 BebQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ILAP5cYQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x127-v6si4455506pgb.651.2018.05.12.09.10.32; Sat, 12 May 2018 09:10:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ILAP5cYQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbeELQKX (ORCPT + 99 others); Sat, 12 May 2018 12:10:23 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:34089 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbeELQKV (ORCPT ); Sat, 12 May 2018 12:10:21 -0400 Received: by mail-lf0-f50.google.com with SMTP id r25-v6so12108147lfd.1 for ; Sat, 12 May 2018 09:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+d2iDyf3jJBs5s3Lf44v//cavwal9DnS42pfFwy6l9k=; b=ILAP5cYQH/3euG8h4MO3VcOBGHqDz2C4w6zUaKur8Yiv61Wc8MMzJrdfM2aRBUIluw gRTc1FdbmzuIE8Ee3g0dgfSoh3t9QcfaFByuRW9rrA5X5W5sRPmC7EkNj2odQoXe3c0L 45boqGx2PLtOm6Ans8iJ45Ux/bvyQ/oA6VHNPLTVgju8P4YGdtjqlzGyvc0JWn/VfS6Q hf8MvM4nf1wjTZVi5MTU4HKkRh1nxLlf4fxujj/MW+OwmGV5aB4pC3YGSbHiV11FJtUu cPl0WauxXqahLRmbR2SENq7e2O7IBiwUqXhgL0dnrHb8YbwQnU/0B6DAtWzw5jhBEhQL T0XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+d2iDyf3jJBs5s3Lf44v//cavwal9DnS42pfFwy6l9k=; b=DRtdrCd620RIZw5BL59f4jtavx7LfPmutJoN9GR0C1reynwQs+YokpfDN2iiIgPwMe sUFgUpLXLCsWfjfkU8bv7/KkbMwGLTlu3FrltIm6cD3zDxkdoATmoz134QhtG4gtzS57 innBvLxfAD70wFq7J/nrj8XxZ87h9l16h1FQPAJyiUjT3RXTDq7uCqkeyhz9DVoBsuMt JiDk2gx3uULXZw7U+IQAwVhFgL6343ovb/nguWmd7RHlj96OwhCd0GHAmHoACe1Gi+We UuIQZ7fMh2bKG/dUfRUqYzcof02KwCn/vc9bVtAHlvA9c5zlccSNNWpvRyO4a1BmOnZa N4Jw== X-Gm-Message-State: ALKqPwfUtLmZME6QFAw1Iz6AtAwRhGDzD0MWjCjJgPb2gEuZPv/oiT5j FVOVkQVptD2QI+l98Ori0HZp783X X-Received: by 2002:a2e:9706:: with SMTP id r6-v6mr1101422lji.5.1526141420091; Sat, 12 May 2018 09:10:20 -0700 (PDT) Received: from [192.168.10.160] (91-159-63-40.elisa-laajakaista.fi. [91.159.63.40]) by smtp.gmail.com with ESMTPSA id p74-v6sm1249922lfe.42.2018.05.12.09.10.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 May 2018 09:10:19 -0700 (PDT) Subject: Re: [RFC: Coding Style] Best way to split a long function declaration with modifiers To: Joe Perches , Jonathan Corbet , linux-kernel@vger.kernel.org References: <4fdc0980-d0af-3a02-02e7-0beed8ba05e2@gmail.com> <2d0127b079b8c9547519ee8c38a42042ad946d50.camel@perches.com> From: Igor Stoppa Message-ID: <79c58d1a-5d30-e3be-b7ad-c561f81d7b16@gmail.com> Date: Sat, 12 May 2018 19:10:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2d0127b079b8c9547519ee8c38a42042ad946d50.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/18 18:41, Joe Perches wrote: >> I personally like more the former, not to mention that it uses also one >> line less, but it seems less common in the sources. >> The coding style references do not seem to say anything explicit about >> which style to prefer. thank you, I could provide a patch to the docs for this case, if it's not considered too much of a corner case. -- igor