Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 13 May 2018 09:18:57 +0200
Message-ID: <s5hpo2081lq.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Connor McAdams" <conmanx360@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        =?UTF-8?B?IkrDqXLDqW15IExlZmF1cmUi?= <jeremy.lefaure@lse.epita.fr>,
        "Jaroslav Kysela" <perex@perex.cz>, <o-takashi@sakamocchi.jp>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 03/13] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ
In-Reply-To: <1525800015-2920-4-git-send-email-conmanx360@gmail.com>
References: <1525800015-2920-1-git-send-email-conmanx360@gmail.com>
        <1525800015-2920-4-git-send-email-conmanx360@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 08 May 2018 19:20:03 +0200,
Connor McAdams wrote:
> 
> This patch adds iomapping for the region2 section of memory on the SBZ.
> This memory region is used in later patches for setting inputs and
> outputs. If the mapping fails, the quirk is changed back to QUIRK_NONE
> to avoid attempts to write to uninitialized memory.
> 
> It also adds a new exit sequence to unmap the iomem for the SBZ.
> 
> Signed-off-by: Connor McAdams <conmanx360@gmail.com>
> ---
>  sound/pci/hda/patch_ca0132.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 02238fe..78d2c26 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -29,6 +29,9 @@
>  #include <linux/firmware.h>
>  #include <linux/kernel.h>
>  #include <sound/core.h>
> +#include <linux/types.h>
> +#include <linux/io.h>
> +#include <linux/pci.h>
>  #include "hda_codec.h"
>  #include "hda_local.h"
>  #include "hda_auto_parser.h"

The linux/*.h inclusion should be before sound/*.h.
But never mind, I fixed it locally, so no need for resubmission.


thanks,

Takashi