Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <f0028b5a-101a-4f19-80b8-a00926bc68dd@default>
References: <f0028b5a-101a-4f19-80b8-a00926bc68dd@default>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Sun, 13 May 2018 16:44:54 +0800
Message-ID: <CANRm+CzisB6YPW96k_WPMzJDZVLxQKGeHnC0Gr+QOcuN5gM_aw@mail.gmail.com>
Subject: Re: [PATCH 2/2] KVM: X86: Fix loss of CR3_PCID_INVD bit when guest
 writes CR3
To:     Liran Alon <liran.alon@oracle.com>
Cc:     Radim Krcmar <rkrcmar@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Junaid Shahid <junaids@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-05-13 16:03 GMT+08:00 Liran Alon <liran.alon@oracle.com>:
>
> ----- kernellwp@gmail.com wrote:
>
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> SDM volume 3, section 4.10.4:
>>
>> * MOV to CR3. The behavior of the instruction depends on the value of
>> CR4.PCIDE:
>> =E2=80=94 If CR4.PCIDE =3D 1 and bit 63 of the instruction=E2=80=99s sou=
rce operand is
>> 1, the
>>   instruction is not required to invalidate any TLB entries or entries
>> in
>>   paging-structure caches.
>>
>> The CR3_PCID_INVD bit should not be removed if CR4.PCIDE =3D 1 when
>> guest writes
>> CR3, this patch fixes it.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>> Cc: Junaid Shahid <junaids@google.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>>  arch/x86/kvm/x86.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 9a90668..438f140 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -849,11 +849,13 @@ EXPORT_SYMBOL_GPL(kvm_set_cr4);
>>
>>  int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
>>  {
>> +     unsigned long cr3_check =3D cr3;
>> +
>>  #ifdef CONFIG_X86_64
>>       bool pcid_enabled =3D kvm_read_cr4_bits(vcpu, X86_CR4_PCIDE);
>>
>>       if (pcid_enabled)
>> -             cr3 &=3D ~CR3_PCID_INVD;
>> +             cr3_check &=3D ~CR3_PCID_INVD;
>>  #endif
>>
>>       if (cr3 =3D=3D kvm_read_cr3(vcpu) && !pdptrs_changed(vcpu)) {
>> @@ -863,7 +865,7 @@ int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned
>> long cr3)
>>       }
>>
>>       if (is_long_mode(vcpu) &&
>> -         (cr3 & rsvd_bits(cpuid_maxphyaddr(vcpu), 63)))
>> +         (cr3_check & rsvd_bits(cpuid_maxphyaddr(vcpu), 63)))
>>               return 1;
>>       else if (is_pae(vcpu) && is_paging(vcpu) &&
>>                  !load_pdptrs(vcpu, vcpu->arch.walk_mmu, cr3))
>> --
>> 2.7.4
>
> This commit doesn't seem correct to me.
>
> According to Intel SDM "MOV=E2=80=94Move to/from Control Registers":
> "If CR4.PCIDE =3D 1, bit 63 of the source operand to MOV to CR3 determine=
s whether the instruction
> invalidates entries in the TLBs and the paging-structure caches
> (see Section 4.10.4.1, =E2=80=9COperations that Invalidate TLBs and Pagin=
g-Structure Caches,=E2=80=9D
> in the Intel=C2=AE 64 and IA-32 Architectures Software Developer=E2=80=99=
s Manual, Volume 3A).
> The instruction does not modify bit 63 of CR3, which is reserved and alwa=
ys 0."
>
> However, after this commit kvm_set_cr3() will update vcpu->arch.cr3 to ha=
ve bit CR3_PCID_INVD set.
> Which is wrong as it should be reserved and always 0.

You are right, thanks Liran.

Regards,
Wanpeng Li