Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3179249imm; Sun, 13 May 2018 06:04:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqp3+nBY+9+Iz27lOisI/nn6KEUxLURaXQo4/YYqh4uk76rvR0DWMAxl0KmkUwJdgIZCa3s X-Received: by 2002:a17:902:2c83:: with SMTP id n3-v6mr5827768plb.211.1526216645221; Sun, 13 May 2018 06:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526216645; cv=none; d=google.com; s=arc-20160816; b=RD0/ck0WUhuWLUbZ9oqzmoc06AJEbxEYX6DrbjObu5OMrMml7tOa+3eZmibEZVlMrq mkCsWHMtEn1BemvNdDI3WRXXtrnnGyL//9O5v2pN8tBr7ecczFehtV5OEM4psdcWhqwE ofAXI/G8sARfb455GkkuZr+z6lmc1gpCH/cLMFa09dTIXu6pwx5jawU5wG3cnFXz6NmF IkS7kF0OrTxQFOG+4acEmR9OIyaXlp5KsjqpYdjEiJBEeh7hd+ZYdvJjlamcXpZz+hwR YZUZRwby7cU8YN+Npr6hFgw66papR/ekKfCgQGNDKDr2QW5I4TfFc1aDERoR3tXbrDPr 1ITQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=paZdj2ham7Od/irg5NQHs9CL4EtVRaodteHXJiouz/w=; b=zcvoLadG0n3XUPUZ5yyn02hgfP1ve/4hCv/bauYS2Ban4fbdf3w+25mz3Xp/bmmH+F ZIrC2+xatzJQOchynKFaUajCBBKEa6sfgfuvtg4JSP9JhKIQvb5c8ov4MOjK4bgqhTLg 8K+groqYtRvjCQlkmVVbpRvvBygbdINlnsM6ByHvbRXm2O0KcfeWCaNEv9w6DYio5bt5 0sKn8E+uvgG8hv4NQ9vtDc251yZyQ+qQEYUFBD1m01KhstaXSO3yNQuvp+MzkXcYjw2J rZiA606u6aF7ohn83c4Z/TCILVFdkZZutlQELb15gg5/j2C7eLW3DO1uaoDDbbTSLnGQ PdgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5-v6si100538pgu.370.2018.05.13.06.03.50; Sun, 13 May 2018 06:04:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbeEMNDe (ORCPT + 99 others); Sun, 13 May 2018 09:03:34 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49218 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbeEMNDd (ORCPT ); Sun, 13 May 2018 09:03:33 -0400 Received: from p4fea4eb5.dip0.t-ipconnect.de ([79.234.78.181] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fHqex-0003LO-JW; Sun, 13 May 2018 15:03:31 +0200 Date: Sun, 13 May 2018 15:03:31 +0200 (CEST) From: Thomas Gleixner To: Joe Perches cc: linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH 1/6] x86/early-quirks: Rename duplicate define of dev_err In-Reply-To: <8fb4b2a77d50e21ae1f7e4e267e68691efe2c270.1525878372.git.joe@perches.com> Message-ID: References: <8fb4b2a77d50e21ae1f7e4e267e68691efe2c270.1525878372.git.joe@perches.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 May 2018, Joe Perches wrote: > dev_err is becoming a macro calling _dev_err to allow prefixing of > dev_fmt to any dev_ use that has a #define dev_fmt(fmt) similar > to the existing #define pr_fmt(fmt) uses. > > Remove this dev_err macro and convert the existing two uses to pr_err. > This allows clean compilation in the patch that introduces dev_fmt which > can prefix dev_ logging macros with arbitrary content similar to > the #define pr_fmt macro. > > Signed-off-by: Joe Perches I assume you want to take them as block, so: Reviewed-by: Thomas Gleixner