Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3428688imm; Sun, 13 May 2018 11:07:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoNAJW4hZz55mG6qzGucFGAg7Ht3irpBm3qnB/sp3XqnUcZ/ldTRGy5pM5GNwtcEZ7aKYXf X-Received: by 2002:a17:902:8f84:: with SMTP id z4-v6mr6781637plo.194.1526234827840; Sun, 13 May 2018 11:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526234827; cv=none; d=google.com; s=arc-20160816; b=0g+AyV11qCfNx1Eroy7lElqhqSBO/7979Ymsaiodv7IfkwRosHuDNhID/z+IR815xo 0yAHKxcUVMzbJ8a/3sDTRFVEc/I//KGequERv6TuB91K+HMjwURSDVbEIRQ1SjZ0F2mf tsaYMw8Ylnb7G9V8brmeRLIl1q1vQ46YhEJew9tyYKvN2+ZAQsxdZKS4MWRzo0x06zZl yrCXgAq2sAmO32w4un1EG5BeXCjR1dPkD5qCAcATXQ0tgumgAWcAR3RtgVDMcRoai/zi BnPPvkZ/2vCZ4eG9awF8Jiq+/VVm3IOfAmlkuGJrP42NDq+9KFURwm4tGg1p7W4wdXkM 8jWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=sQ1z4VJWSRySzXRPyZI/jxhVUFKNhyZdDU8KzKpgABg=; b=HT9c/jLQJk8rFVztkXyg+vHVyaQtb6DeYxatOa/PRZRwMbO0GabDAT3lRPR3UoqJeD HVrqVj0S8fdQ+iLZQ+Wd/mwSB2UbGHolnFQtG4NI4QxRpP3Ot4U86l7pBZaW4MobV7DZ vfZXaVyCZcQacWI1oETib1DEtHUz6TBTpZpQTqAG2vMgvxPMLqjQWIEclDefBh9M1Zh6 aKY0rOHrvm7IWfM3H09AxXaG1wYGBMdC7934GEBT2euWhtborEVufYBqnwGYBmWhJMU8 ifVoyAkkZrV4sLQAdSxWr0RcHVaciuJJ1kZP0KYhBmsVC6FTu9ivOZ6mUiJBkUvHLANI 0pYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kapsi.fi header.s=20161220 header.b=Ayp0Usg2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si7970983plt.98.2018.05.13.11.06.53; Sun, 13 May 2018 11:07:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kapsi.fi header.s=20161220 header.b=Ayp0Usg2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbeEMSGl (ORCPT + 99 others); Sun, 13 May 2018 14:06:41 -0400 Received: from mail.kapsi.fi ([91.232.154.25]:60699 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbeEMSGj (ORCPT ); Sun, 13 May 2018 14:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=sQ1z4VJWSRySzXRPyZI/jxhVUFKNhyZdDU8KzKpgABg=; b=Ayp0Usg2gxIePcNxwAdbNA7ML2HwKO0r7CESQV/o55ICIWacnbw684reeUih0dWWtqKGMLOtNkrsCa1euJV0lo8hHtgTRyR2UANAcrtVF7kXJ5RJbS1XFGHHvuKLCYVqS/FMe9GIB4RqN6y6MOdho/KwGn3hamisQ+GUbZ/oW8VodBpdAeYmwu4S9AkPY7sFIKMb6oNbwk/Xjrhu3YfQ8/nRNNhA+phDnw5ddw/bEEvR7xFx7kqhHnhkor19NI2W4NAbpXDxfhZ5j2MNKHk7koqRrXab8Eaq+9+3zB5DMrQWTNkjWONvjFtmSda3eKov9NPaUARdvHQ+XXhc1NxGqQ==; Received: from dsl-hkibng22-54faa2-250.dhcp.inet.fi ([84.250.162.250]) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fHvOH-0004kf-9X; Sun, 13 May 2018 21:06:37 +0300 Subject: Re: [PATCH 6/8] serial: Add Tegra Combined UART driver To: Jassi Brar , Mikko Perttunen Cc: Rob Herring , Mark Rutland , Greg KH , Thierry Reding , Jon Hunter , araza@nvidia.com, Devicetree List , linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org, ", linux-arm-kernel"@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream , Linux Kernel Mailing List References: <20180508114403.14499-1-mperttunen@nvidia.com> <20180508114403.14499-7-mperttunen@nvidia.com> From: Mikko Perttunen Message-ID: <4d6aab52-9c99-8dd8-556d-86f32d9f6234@kapsi.fi> Date: Sun, 13 May 2018 21:06:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.250.162.250 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/13/2018 06:36 PM, Jassi Brar wrote: > On Tue, May 8, 2018 at 5:14 PM, Mikko Perttunen wrote: > > .... >> >> +config SERIAL_TEGRA_TCU >> + tristate "NVIDIA Tegra Combined UART" >> + depends on ARCH_TEGRA && MAILBOX >> + select SERIAL_CORE >> + help >> + Support for the mailbox-based TCU (Tegra Combined UART) serial port. >> + TCU is a virtual serial port that allows multiplexing multiple data >> + streams into a single hardware serial port. >> + > Maybe make it depend upon TEGRA_HSP_MBOX ? Yeah, that probably makes more sense. MAILBOX is enough to build it but it won't be of any use without TEGRA_HSP_MBOX. > > ...... > >> + >> +static void tegra_tcu_write(const char *s, unsigned int count) >> +{ >> + struct tegra_tcu *tcu = tegra_tcu_uart_port.private_data; >> + unsigned int written = 0, i = 0; >> + bool insert_nl = false; >> + uint32_t value = 0; >> + >> + while (i < count) { >> + if (insert_nl) { >> + value |= '\n' << (written++ * 8); >> + insert_nl = false; >> + i++; >> + } else if (s[i] == '\n') { >> + value |= '\r' << (written++ * 8); >> + insert_nl = true; >> + } else { >> + value |= s[i++] << (written++ * 8); >> + } >> + >> + if (written == 3) { >> + value |= 3 << 24; >> + value |= BIT(26); >> + mbox_send_message(tcu->tx, &value); >> > How is this supposed to work? tegra_hsp_doorbell_send_data() ignores > the second argument. The previous patch in the series adds support for what are called "shared mailboxes" to the tegra-hsp driver. For these the second argument is used. Thanks, Mikko > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >