Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3431145imm; Sun, 13 May 2018 11:10:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpPjJkJWtslkkQNHc4/Tr4qQ4QHjYhyIPjEFP/V0ToUh6J0K5p0MerF5cub/gXh/4+PsyhO X-Received: by 2002:a17:902:380c:: with SMTP id l12-v6mr6737459plc.19.1526235020912; Sun, 13 May 2018 11:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526235020; cv=none; d=google.com; s=arc-20160816; b=eUC+cN+vX+ZBs2lzWZkiDgNvrUt20s1jpucE6vZ6JE1NAYKKplmw3+6uamEU4ctyVE vb0AAmlZb3J/lSCSjB+dOyjHdzpmtwzwlmkwgeHBWxTacdpS3dLf8muDyP2IOwoK2m8k uVsN/YvVEqwRVXh+EwuHdZQ+ueaQFJ/ekqE/NQQdv3tmvStd7Hq5kghi7eqLU9paC5Sf tmIDxEL1e2RZalOhjZ4xPQAcdZa2DE48jGn9HQxtP2+uMrOR5zMPdJ+tXbsM/IcVmvLC 4FnHX5dAHwxUzyhIukV1BcGhGjkIiGuAsWxnQbjQmTAtijuljf4125YRNtpjcUftxUJK 8wUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:arc-authentication-results; bh=c/mKW1DS/Pb2XBXpTbzBtnGZU7Z6goKnZHUOQGWRjtM=; b=fZS1/1pp7cwA0G/awm6KrcSUJoK0rQ4OaBa8gZ5UTwF3BmY/aUhmpPiZvA+dgLgMPg 0ej6QR/NNyir1dbdc/v8AfEx/58D8tpN/cS3i+8XXJB/ZF5aF8VY+B/o3V4y1kY4M0gS ZsXifq48JibRDdqs+B/MtIs578qUF9Dz7RiibVuZ0qeL7PTfPWl3Zdsvjg2udDD0KK48 nmF+8mBSkGHB8UDV+fgGWp1fAIHgdsxfmNGPSIrJpN177dD7ak8jLsdIpIUnZ+1T2sIF lSGshczMoQA8GMGvZR7I5WjyHTwN7JAYhugaRIIWs81xOe1300FyQ7k8M++M91cjXPHL 2XPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si7756666pli.274.2018.05.13.11.10.06; Sun, 13 May 2018 11:10:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbeEMSJz (ORCPT + 99 others); Sun, 13 May 2018 14:09:55 -0400 Received: from terminus.zytor.com ([198.137.202.136]:54683 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbeEMSJw (ORCPT ); Sun, 13 May 2018 14:09:52 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id w4DI9kS6428772 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 13 May 2018 11:09:46 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w4DI9kUo428769; Sun, 13 May 2018 11:09:46 -0700 Date: Sun, 13 May 2018 11:09:46 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Joe Perches Message-ID: Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, joe@perches.com, tglx@linutronix.de Reply-To: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, joe@perches.com, mingo@kernel.org In-Reply-To: <8fb4b2a77d50e21ae1f7e4e267e68691efe2c270.1525878372.git.joe@perches.com> References: <8fb4b2a77d50e21ae1f7e4e267e68691efe2c270.1525878372.git.joe@perches.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/cleanups] x86/early-quirks: Rename duplicate define of dev_err Git-Commit-ID: a7a3153a98d581196ce092e0b83cac2c4ee1fd1f X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_DATE_IN_FUTURE_96_Q autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a7a3153a98d581196ce092e0b83cac2c4ee1fd1f Gitweb: https://git.kernel.org/tip/a7a3153a98d581196ce092e0b83cac2c4ee1fd1f Author: Joe Perches AuthorDate: Wed, 9 May 2018 08:15:45 -0700 Committer: Thomas Gleixner CommitDate: Sun, 13 May 2018 20:04:35 +0200 x86/early-quirks: Rename duplicate define of dev_err dev_err is becoming a macro calling _dev_err to allow prefixing of dev_fmt to any dev_ use that has a #define dev_fmt(fmt) similar to the existing #define pr_fmt(fmt) uses. Remove this dev_err macro and convert the existing two uses to pr_err. This allows clean compilation in the patch that introduces dev_fmt which can prefix dev_ logging macros with arbitrary content similar to the #define pr_fmt macro. Signed-off-by: Joe Perches Signed-off-by: Thomas Gleixner Cc: "H. Peter Anvin" Link: https://lkml.kernel.org/r/8fb4b2a77d50e21ae1f7e4e267e68691efe2c270.1525878372.git.joe@perches.com --- arch/x86/kernel/early-quirks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c index bae0d32e327b..da5d8ac60062 100644 --- a/arch/x86/kernel/early-quirks.c +++ b/arch/x86/kernel/early-quirks.c @@ -28,8 +28,6 @@ #include #include -#define dev_err(msg) pr_err("pci 0000:%02x:%02x.%d: %s", bus, slot, func, msg) - static void __init fix_hypertransport_config(int num, int slot, int func) { u32 htcfg; @@ -617,7 +615,8 @@ static void __init apple_airport_reset(int bus, int slot, int func) pmcsr = read_pci_config_16(bus, slot, func, BCM4331_PM_CAP + PCI_PM_CTRL); if ((pmcsr & PCI_PM_CTRL_STATE_MASK) != PCI_D0) { - dev_err("Cannot power up Apple AirPort card\n"); + pr_err("pci 0000:%02x:%02x.%d: Cannot power up Apple AirPort card\n", + bus, slot, func); return; } } @@ -628,7 +627,8 @@ static void __init apple_airport_reset(int bus, int slot, int func) mmio = early_ioremap(addr, BCM4331_MMIO_SIZE); if (!mmio) { - dev_err("Cannot iomap Apple AirPort card\n"); + pr_err("pci 0000:%02x:%02x.%d: Cannot iomap Apple AirPort card\n", + bus, slot, func); return; }