Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <039ab80bd6a653505e606bf87fceae156fe127e1.camel@perches.com>
Subject: Re: [PATCH] staging: speakup: Fix coding style
From:   Joe Perches <joe@perches.com>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org
Date:   Sun, 13 May 2018 14:49:06 -0700
In-Reply-To: <20180513093830.lwspfmjaxjixpaew@var.youpi.perso.aquilenet.fr>
References: <20180513093830.lwspfmjaxjixpaew@var.youpi.perso.aquilenet.fr>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2018-05-13 at 11:38 +0200, Samuel Thibault wrote:
[]
> @@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
>  char spk_str_caps_start[MAXVARLEN + 1] = "\0";
>  char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
>  char spk_str_pause[MAXVARLEN + 1] = "\0";
> -bool spk_paused = 0;
> +bool spk_paused;
>  const struct st_bits_data spk_punc_info[] = {
>  	{"none", "", 0},
>  	{"some", "/$%&@", SOME},
> @@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
>  		/* Speakup output, discard */
>  		return;
>  	speakup_date(vc);
> -	if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
> -	{
> +	if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
>  		synth_printf("%s", spk_str_pause);
>  		spk_paused = 1;

probably nice to change the assignments of
spk_paused to true&false too