Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Andrew Morton <akpm@linux-foundation.org>, kernel@pengutronix.de,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Mark Brown <broonie@kernel.org>
References: <20180305102524.5905-1-o.rempel@pengutronix.de>
 <20180305102524.5905-4-o.rempel@pengutronix.de>
 <20180504185052.bjhfkvpgrblc7tfc@pengutronix.de>
 <1937901.oyadCYFYNo@aspire.rjw.lan>
 <a431b0e1-f4f4-1439-f0bf-736018c6ab0c@pengutronix.de>
 <091ccf85-ae4c-f6fd-0455-1a70e973c85c@pengutronix.de>
Message-ID: <12a60556-deaf-1b2a-e073-ba2a70389141@pengutronix.de>
Date:   Mon, 14 May 2018 12:12:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <091ccf85-ae4c-f6fd-0455-1a70e973c85c@pengutronix.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="gAYFsmZs7qnQXrg9TsiHuZ0dEDFJoFZz3"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gAYFsmZs7qnQXrg9TsiHuZ0dEDFJoFZz3
Content-Type: multipart/mixed; boundary="2ofMOmFf4n6AQ4iFh7cCAVd4ChFcJMSD2";
 protected-headers="v1"
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, kernel@pengutronix.de,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
 Liam Girdwood <lgirdwood@gmail.com>,
 Leonard Crestez <leonard.crestez@nxp.com>, Rob Herring <robh+dt@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Michael Turquette <mturquette@baylibre.com>,
 Stephen Boyd <sboyd@codeaurora.org>, Fabio Estevam <fabio.estevam@nxp.com>,
 Russell King <linux@armlinux.org.uk>, Shawn Guo <shawnguo@kernel.org>,
 Mark Brown <broonie@kernel.org>
Message-ID: <12a60556-deaf-1b2a-e073-ba2a70389141@pengutronix.de>
Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare
References: <20180305102524.5905-1-o.rempel@pengutronix.de>
 <20180305102524.5905-4-o.rempel@pengutronix.de>
 <20180504185052.bjhfkvpgrblc7tfc@pengutronix.de>
 <1937901.oyadCYFYNo@aspire.rjw.lan>
 <a431b0e1-f4f4-1439-f0bf-736018c6ab0c@pengutronix.de>
 <091ccf85-ae4c-f6fd-0455-1a70e973c85c@pengutronix.de>
In-Reply-To: <091ccf85-ae4c-f6fd-0455-1a70e973c85c@pengutronix.de>

--2ofMOmFf4n6AQ4iFh7cCAVd4ChFcJMSD2
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable


On 14.05.2018 07:10, Oleksij Rempel wrote:
>=20
>=20
> On 14.05.2018 06:33, Oleksij Rempel wrote:
>>
>>
>> On 12.05.2018 13:13, Rafael J. Wysocki wrote:
>>> On Friday, May 4, 2018 8:50:52 PM CEST Oleksij Rempel wrote:
>>>> Hallo Andrew,
>>>> I need your ACK or NACK for this patch.
>>>>
>>>> This function is used to configure external PMIC to interpret
>>>> signal which will be triggered by pm_power_off as power off.
>>>> Since same signal can be used for stand by, I linked PMIC configurat=
ion
>>>> with pm_power_off_prepare to avoid possible conflicts.
>>>>
>>>> On Mon, Mar 05, 2018 at 11:25:20AM +0100, Oleksij Rempel wrote:
>>>>> Export pm_power_off_prepare. It is needed to implement power off on=

>>>>> Freescale/NXP iMX6 based boards with external power management
>>>>> integrated circuit (PMIC).
>>>>>
>>>>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>>>>> ---
>>>>>  kernel/reboot.c | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>>>>> index e4ced883d8de..350be6baa60d 100644
>>>>> --- a/kernel/reboot.c
>>>>> +++ b/kernel/reboot.c
>>>>> @@ -49,6 +49,7 @@ int reboot_force;
>>>>>   */
>>>>> =20
>>>>>  void (*pm_power_off_prepare)(void);
>>>>> +EXPORT_SYMBOL(pm_power_off_prepare);
>>>
>>> Why not EXPORT_SYMBOL_GPL() ?
>>
>> No special reason. Fixed.
>> Any other comments?
>>
>=20
> Or with other words, will it be enough to get your Signed-of-by for thi=
s
> patch?

Hi again,

i was punished by my colleagues and actually by Russel for asking
"Signed-of-by". So, I correct my self, is it enough for a Reviewed-by?


--2ofMOmFf4n6AQ4iFh7cCAVd4ChFcJMSD2--

--gAYFsmZs7qnQXrg9TsiHuZ0dEDFJoFZz3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEpENFL0P3hvQ7p0DDdQOiSHVI77QFAlr5YQMACgkQdQOiSHVI
77TgxQgAuCnYkS1JEWYbZQegzl5HQLClkc3ycFmZxXyPOCAh5LK+14N6VwZVpi3P
WLA5sMSy8T3pAwmFmNu2jskeepgAF96oN3R9rJ1gzbkLKVs5NXugm+T2Uo0ynpw0
7L57u/CgqertRfbBrGFxlelXecXSP+QucPjmW6qlEAUum0gNVH13PBv9ZitLq42z
tm4I+OZdiFDVge0FNzUPO65DVHJ2HxfEDMBGhSDLVd5HOtx8076dG8prTFckhVzy
GBIJNrsHeaDnu9IYXBxTowjdtATw4JxDOdMNLH4yN+5B/H7hKGCRnEDK58z0+f/R
gC72P2P9XKQ6ionAlqiTA8hakLIJGg==
=+/u4
-----END PGP SIGNATURE-----

--gAYFsmZs7qnQXrg9TsiHuZ0dEDFJoFZz3--