Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4152911imm; Mon, 14 May 2018 03:27:52 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqKsOj97/dI1GFyb9V7wb11JM+E3qOAY73/ej6MKyPKJIBu4UWG8ZVco4bJN5EHalJaIs2Z X-Received: by 2002:a63:4384:: with SMTP id q126-v6mr7842491pga.294.1526293672138; Mon, 14 May 2018 03:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526293672; cv=none; d=google.com; s=arc-20160816; b=BD5PpkaYa7xbqx5pSBt3TaE82ysuCNw/m6GnQ/v4hp88iUUDEt783S1ogBZo/AjsIn uROhV1FsfzBgfU+utlFt3MntZpczbCEfOfn940J74VB/t1q16KfCxN8kAc835K6wHdwH JzTLN9uKoS+8wLQfv1DGW70BqSPnN0P02yuGUN6WPZW04Xzf+JJ8PWTgjLnbuGaTPmXQ 2xrULolEtiSn37GkT8U8RSL04EyaMcpMKo5nW3ckSg6SfFeaBFwKjdpfJ/69dsUxG1EC Sct8JAnGQLzO05cifoFE/gKvTsvqNaBHl0vlAJMh6qYMKu0kXEX8buNmCxRIPhBlD39z VMvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=J2cB/nMnZgACBNU8dW3Se+W54bdCa8KpskxJzHP24Uk=; b=kLkJCGSv296PlJ8ieoDT4K0j9dPyZuclki/3yp4nOoli/cKDtAgzoNjhchLe+5FVK9 bFTWmiJM/Sd7Hx7AQyYF/T72r27cZKBY+WXpLpCzXaH6cnOgpgCBrhPfoAa3RxodrM76 339jjk21qsRL0ilbanHa+vNpM1l95Ei7Z7TvAz/8dp90rqD6w8pOPSbw54V4LlLwAHRd h/7y9ilAuqojn4jQ3MOGvtkOZy0YShuBwLPrW47moKRkemTSLXRj/HQTD0dFYuv1jhHP tcRl758VSUm4dq6sLYAioKGFlA5XIffIagJ16/dmDB4sKuUNClRadpQ0ueOEwLGnpsSE k6RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s11-v6si6839169pgc.607.2018.05.14.03.27.37; Mon, 14 May 2018 03:27:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbeENK1S (ORCPT + 99 others); Mon, 14 May 2018 06:27:18 -0400 Received: from mga11.intel.com ([192.55.52.93]:38331 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbeENK1R (ORCPT ); Mon, 14 May 2018 06:27:17 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 03:27:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,399,1520924400"; d="scan'208";a="228266996" Received: from yixuanma-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.136]) by fmsmga005.fm.intel.com with ESMTP; 14 May 2018 03:27:14 -0700 Date: Mon, 14 May 2018 13:27:13 +0300 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe Subject: Re: [PATCH] tpm_tis: verify locality released before returning from release_locality Message-ID: <20180514102713.GA8228@linux.intel.com> References: <20180505195453.10431-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180505195453.10431-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 05, 2018 at 12:54:53PM -0700, Jerry Snitselaar wrote: > For certain tpm chips releasing locality can take long enough that a > subsequent call to request_locality will see the locality as being > active when the access register is read in check_locality. So check > that the locality has been released before returning from > release_locality. > > Cc: Jarkko Sakkinen > Cc: Peter Huewe > Cc: Jason Gunthorpe > Reported-by: Laurent Bigonville > Signed-off-by: Jerry Snitselaar Reviewed-by: Jarkko Sakkinen /Jarkko