Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4346124imm; Mon, 14 May 2018 06:20:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqRpe8C6J2OBIIDuK+wB80pRfx0ZSr1/jQIIaJontVNjVtB0KoBqDWy3b+w13RjPpf2w1hX X-Received: by 2002:a63:7b53:: with SMTP id k19-v6mr8513315pgn.254.1526304032925; Mon, 14 May 2018 06:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526304032; cv=none; d=google.com; s=arc-20160816; b=c4fb6kqWvFWqJzMiN/xSqnENP6cST1srIbYZ9LeltWPDmNWHIHy8Mh8NPDYyvzCvtZ 5WVDLh7dIuLduWE2wIKUvnpKZwhMD8EWz5QKhxA1JVeRFXI2qht0Q3NLS0JcrNwiVboG K/pzzdPtiYfw41y2xkTo8NsRx8RoJA2liBlaWTNNLEH2QkGEZsdjil0dxoUUuuTRuMiu JSM/SlCEtMYPaCJWS8T2tlIR/Is86rXVWTeVEhCP72b+LIdvEGUlj3BwQmhOdxqFWO4A VHrHXYheeBKHPKbvBhk8J2ipLGb+/z3hHomHpGFKJqtMWlQACwluZEaQJPYale7m3MdR FEwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=ofm1rjYy+3kvlT955HCLVn5QezrJPR/dtBEJLjAU0Xs=; b=MWXbsoj9jo0Y+ehiQseTOu+CB+nFiCYHxQTzyeBYSiJ1zH1sbWQ6lPhF+R/5mYKHjN DIfAnjB/v/Y9lJqiHqAQGPW1ZFP2/GeJ8ar4ey4dwZGsS2z22AgP5ZXumtzi5WMigDzO D0j4fjJdoQSWMx67ol5usWqMkI/Yr7b1q9DWNuB9MVn06kdT+OiFMJ35XUdeWNsKAm60 VIh5jOp246koLxH87dRm3tuIIsawAPw1txcQa6I6JTkfRCAWNve8tpg2gHoetxZhrbPB Exus86+XYkklqfycsLjDYPrmj8eQLtgZDrxIRZdG5cUy0XSF2w/cxJmoNTN6y8ukwzua koiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZwCSPG9f; dkim=pass header.i=@codeaurora.org header.s=default header.b=ePcBwaxv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3-v6si9759873pfa.181.2018.05.14.06.19.47; Mon, 14 May 2018 06:20:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZwCSPG9f; dkim=pass header.i=@codeaurora.org header.s=default header.b=ePcBwaxv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932286AbeENNMr (ORCPT + 99 others); Mon, 14 May 2018 09:12:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44738 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932241AbeENNMo (ORCPT ); Mon, 14 May 2018 09:12:44 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8C13660790; Mon, 14 May 2018 13:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526303563; bh=x6E7yG/TzCnUEqbNoMz1kfMxleQ+9V3mEq31rT0I64w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZwCSPG9fgl2bnG5SAsZhjsZrnEb6ZpNxFqZ6QNHRU4jBWM+mSBvc7rjSbfCvYRlho Ih0r04xJJfZof30O/HvbHx1sNnnwu3WF6MTnH9o2J71wXovU2Ah/SobLdDdyVSBgK5 iuMBaBAub4ybb4Xvk5dpCQSfaBDVmHy+HolpcMwo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lx-ilial.mea.qualcomm.com (unknown [185.23.60.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilialin@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 684D66085F; Mon, 14 May 2018 13:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526303562; bh=x6E7yG/TzCnUEqbNoMz1kfMxleQ+9V3mEq31rT0I64w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ePcBwaxvfgGdr6HrjsX+i+k2gmiLy1MXswPJyU80tBhp4e1QZvImsHDEVh+JeKIUm 6xe8eWI+0p8ya+TCj4HWtN+YfqW+Rt9b2fUONuyKSInbMTQaOOeGyriSzJhLTfyytf bwRAlqoYBdpbeyzbc/C+NWwzeF45ahJtYvWMV4VQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 684D66085F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilialin@codeaurora.org From: Ilia Lin To: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, viresh.kumar@linaro.org, nm@ti.com, lgirdwood@gmail.com, broonie@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, linux-clk@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, ilialin@codeaurora.org, amit.kucheria@linaro.org, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: [PATCH v6 06/14] clk: qcom: cpu-8996: Add support to switch below 600Mhz Date: Mon, 14 May 2018 16:11:52 +0300 Message-Id: <1526303520-5843-7-git-send-email-ilialin@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1526303520-5843-1-git-send-email-ilialin@codeaurora.org> References: <1526303520-5843-1-git-send-email-ilialin@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rajendra Nayak The CPU clock controller's primary PLL operates on a single VCO range, between 600MHz and 3GHz. However the CPUs do support OPPs with frequencies between 300MHz and 600MHz. In order to support running the CPUs at those frequencies we end up having to lock the PLL at twice the rate and drive the CPU clk via the PLL/2 output and SMUX. So for frequencies above 600MHz we follow the following path Primary PLL --> PLL_EARLY --> PMUX(1) --> CPU clk and for frequencies between 300MHz and 600MHz we follow Primary PLL --> PLL/2 --> SMUX(1) --> PMUX(0) --> CPU clk Signed-off-by: Rajendra Nayak Signed-off-by: Ilia Lin Conflicts: drivers/clk/qcom/clk-cpu-8996.c --- drivers/clk/qcom/clk-cpu-8996.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c index 390b369..3ea0446 100644 --- a/drivers/clk/qcom/clk-cpu-8996.c +++ b/drivers/clk/qcom/clk-cpu-8996.c @@ -77,6 +77,8 @@ enum _pmux_input { NUM_OF_PMUX_INPUTS }; +#define DIV_2_THRESHOLD 600000000 + static const u8 prim_pll_regs[PLL_OFF_MAX_REGS] = { [PLL_OFF_L_VAL] = 0x04, [PLL_OFF_ALPHA_VAL] = 0x08, @@ -104,10 +106,11 @@ enum _pmux_input { static const struct alpha_pll_config hfpll_config = { .l = 60, - .config_ctl_val = 0x200d4828, + .config_ctl_val = 0x200d4aa8, .config_ctl_hi_val = 0x006, .pre_div_mask = BIT(12), .post_div_mask = 0x3 << 8, + .post_div_val = 0x1 << 8, .main_output_mask = BIT(0), .early_output_mask = BIT(3), }; @@ -149,7 +152,7 @@ enum _pmux_input { .vco_mask = 0x3 << 20, .config_ctl_val = 0x4001051b, .post_div_mask = 0x3 << 8, - .post_div_val = 0x1, + .post_div_val = 0x1 << 8, .main_output_mask = BIT(0), .early_output_mask = BIT(3), }; @@ -190,6 +193,7 @@ struct clk_cpu_8996_mux { u8 width; struct notifier_block nb; struct clk_hw *pll; + struct clk_hw *pll_div_2; struct clk_regmap clkr; }; @@ -235,6 +239,13 @@ static int clk_cpu_8996_mux_set_parent(struct clk_hw *hw, u8 index) struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_hw(hw); struct clk_hw *parent = cpuclk->pll; + if (cpuclk->pll_div_2 && req->rate < DIV_2_THRESHOLD) { + if (req->rate < (DIV_2_THRESHOLD / 2)) + return -EINVAL; + + parent = cpuclk->pll_div_2; + } + req->best_parent_rate = clk_hw_round_rate(parent, req->rate); req->best_parent_hw = parent; @@ -246,13 +257,19 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, { int ret; struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_nb(nb); + struct clk_notifier_data *cnd = data; switch (event) { case PRE_RATE_CHANGE: ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, ALT_INDEX); break; case POST_RATE_CHANGE: - ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, PLL_INDEX); + if (cnd->new_rate < DIV_2_THRESHOLD) + ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, + DIV_2_INDEX); + else + ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, + PLL_INDEX); break; default: ret = 0; @@ -304,6 +321,7 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, .shift = 0, .width = 2, .pll = &pwrcl_pll.clkr.hw, + .pll_div_2 = &pwrcl_smux.clkr.hw, .nb.notifier_call = cpu_clk_notifier_cb, .clkr.hw.init = &(struct clk_init_data) { .name = "pwrcl_pmux", @@ -324,6 +342,7 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, .shift = 0, .width = 2, .pll = &perfcl_pll.clkr.hw, + .pll_div_2 = &perfcl_smux.clkr.hw, .nb.notifier_call = cpu_clk_notifier_cb, .clkr.hw.init = &(struct clk_init_data) { .name = "perfcl_pmux", -- 1.9.1