Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4370773imm; Mon, 14 May 2018 06:40:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoeojkQGxYKo7ksdysDRIade4wMHTM6Cl9fHq0v+RccAY+eu1S3E8FDyQ5E9mTnN5cWxEEp X-Received: by 2002:a62:4184:: with SMTP id g4-v6mr10611874pfd.51.1526305249642; Mon, 14 May 2018 06:40:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526305249; cv=none; d=google.com; s=arc-20160816; b=Unq8476shVH02xfqmaglF/9/SWZ0qO+tfAgIz82fD9Fy3k+9DC2y8f3KT94Z4HZ3Ch /+MBawHxqKp5W3OTZRB0u2KoCrrV1dNY+UBMwTFA9mdwi7nBR4YUYzoQ13+kpm4XAwMJ 6txDRDsJrfSYCR8nhi0ARl2CnEKP2u/k1PZtGdizqFpuOjKxjSD6Y4YMofEzTs6Gehu1 OtJ8LzGDStZ6Ar/sFZ01ySfkEp6Q35GVxAUvgfYcFuSkCZgmO76POwsFAFmxTCxxH6QR E98KSLt7KSQrtK3zCz3+65BTP4Ez5ByqWcjgPh6L+J4NUomddh8nJpG2ndP9CETl3v57 D96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=Kr+Isbhj5PgfARCnuEz7hsKGQL8leLMYRZnaE7jPE8E=; b=GzDPANQ9Qhp1stQANn+av4JnSh9nxDmxEaF3mFMR4+zZuFHDKV/4xuPvdEo38BUa4g hSPuTR17PRWh/n7Sh0JpkcLo4845kYf/hloHwGF5ZzsN/JpWOH7b3KGnLBQ8h9kR156C VdN9L2Vpet7RyU/ydSYsTFjLOm7e2SygvMJ6/VQJkaJKkGIuZoRPRI+ajyIVFm0voQE8 StfOdOQ8UcjGkCNX0Ci5sOt0yUXQufc1fFxExDvccTPlEtZ4c/4/461lXJYCv/5OZrZB qY3gu/LZ88sbUDQG13mbAB22dkOhYURja9GncRLJBYpRPAQgml77hxNSpXCt0PxJXL8L k3Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a4to5Oam; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c30-v6si6799867pgn.553.2018.05.14.06.40.34; Mon, 14 May 2018 06:40:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a4to5Oam; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbeENNil (ORCPT + 99 others); Mon, 14 May 2018 09:38:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:49750 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195AbeENNii (ORCPT ); Mon, 14 May 2018 09:38:38 -0400 Received: from devbox (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70CA820740; Mon, 14 May 2018 13:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526305118; bh=lSTSfmfL/KgIsZpSpNKk+mnxDvR/mirH8gXRfNhfJM8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a4to5Oam9E0mrWdukn5EB543IcvFmfXOE/1xM61s9klZIcXHTa5cAkBzoKN7bMASL tCxGeeZvdb7xlPg5RjOjPBzQpJbV47TvWa9hew3lNxyFiIzZ2QtG9ZBvBgtSv1a/FQ SG+WX20cKYiz7i91iyv/L973C+D0iel7SmfsMrP0= Date: Mon, 14 May 2018 22:38:33 +0900 From: Masami Hiramatsu To: Joe Perches Cc: Paul Moore , Eric Paris , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Jessica Yu , Kees Cook , Andy Lutomirski , Will Drewry , Balbir Singh , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org, linux-audit@redhat.com Subject: Re: [PATCH 01/18] kernel: Use pr_fmt Message-Id: <20180514223833.f3c2224e458e89949d3042d4@kernel.org> In-Reply-To: <28df5659605d7b2ace94deca3b831b462183303f.1525964381.git.joe@perches.com> References: <28df5659605d7b2ace94deca3b831b462183303f.1525964381.git.joe@perches.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 May 2018 08:45:27 -0700 Joe Perches wrote: > Sometime in the future, it would be useful to convert pr_fmt from a > default simple define to use a default prefix with KBUILD_MODNAME. > > There are files in kernel/ that use pr_, some with an embedded > prefix, that also do not have a specific pr_fmt define. > > Add pr_fmt for those files. > > There are some differences in output as some messages are now prefixed > with their KBUILD_MODNAME. > > Miscellanea: > > o Align multiline statements to open parenthesis > o Wrap and realign arguments to 80 columns where sensible > o Coalesce formats > > Signed-off-by: Joe Perches Kprobes part looks good to me. Acked-by: Masami Hiramatsu Thanks! -- Masami Hiramatsu