Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4405254imm; Mon, 14 May 2018 07:09:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrVu6LuatSC6uHCEhPSlzo2emm2PY8AQhF6f0/s3d0xEvxL9V1mdXtwRduHkG8MqONyITnT X-Received: by 2002:a62:a48:: with SMTP id s69-v6mr10725121pfi.134.1526306947014; Mon, 14 May 2018 07:09:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526306946; cv=none; d=google.com; s=arc-20160816; b=AhHX60d+9C6lZ+qCUWagIVL08Uxn9N9lacwD3jQiU9Qxo6Xf8jtORTPMEalJHE3dyw F/zCNJtWj0/BtQKLgEO5pB+9LlmnceS2v/ZbK5usR6cT3e1B8+76PbBsW+6fD+XUM6ed m5jkpGlamFDBbrO0d+YUwPby4VJGfoUAyp1WAnka8An9iMxF7vqxHFVx7UFDdOlLXna4 ZWHG9rz48NBqUm48O1rtiSydmWi3sNAUEehMAUAN/TVuzqiqzZs1n0O5hewMMkXbNLQa GmCMfB5uCKDuocnYnHZzm9EcxQx6he7y21XcvE4WpFd3FQAOnpIDjlMKIz2wLMCmKwHw Twlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=9ntijv+zeI4jbLSnK+bjoMUBZJVYgwIfcSJ0m27ILQ8=; b=gBTT252K38KGCVGYPYSuBvN6UibjHV3ivRvfhRwLCNhOaMsB342Lhsn+BGb1SUv8uY rLa7yrwJq8d8xwewfDGKfdALlfslfpumOkU6dDhKa0iwsd6ptqa4dEwc0yOlVYkY84qw w0rVgx1t8clpiK5/3SXARkZyXG1DZRsXkROeygDdznxKfznpFhomTZdqqprJbDOadHCC JiEc37S5kMjlSXyqtrincNYmXPjSV+MC/T22ahXDQBQmd6asaSFaPZzzSyIVfo7Xiqgu SHZaMHn9mOVSf0gB3ctYi/gQp6n70/YF6fybkIV5sL2P90ZrC+WbicQWW4tyMIQoWvs8 915Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o9-v6si10120018pfk.276.2018.05.14.07.08.47; Mon, 14 May 2018 07:09:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932534AbeENOIA (ORCPT + 99 others); Mon, 14 May 2018 10:08:00 -0400 Received: from mail.bootlin.com ([62.4.15.54]:50247 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932421AbeENOG6 (ORCPT ); Mon, 14 May 2018 10:06:58 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 4BE6A20376; Mon, 14 May 2018 16:06:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id E1D9F208C4; Mon, 14 May 2018 16:06:39 +0200 (CEST) Date: Mon, 14 May 2018 16:06:40 +0200 From: Maxime Ripard To: Danny Milosavljevic Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Andrea Bondavalli , Fabio Estevam , Icenowy Zheng , Philipp Zabel , Kuninori Morimoto , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls Message-ID: <20180514140640.oig6hqbh5utvzhmd@flea> References: <20180502210800.1971-1-dannym@scratchpost.org> <20180502210800.1971-4-dannym@scratchpost.org> <20180503144618.oojhvmey44dtg5fa@flea> <20180505085056.6c6011ca@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nskfsqj542gg4f7l" Content-Disposition: inline In-Reply-To: <20180505085056.6c6011ca@scratchpost.org> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nskfsqj542gg4f7l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 05, 2018 at 08:51:43AM +0200, Danny Milosavljevic wrote: > Hi Maxime, >=20 > On Thu, 3 May 2018 16:46:19 +0200 > Maxime Ripard wrote: >=20 > > Doesn't that mean that the controls will be shared between the right > > and left mixers now, which wasn't the case before? >=20 > Yes. However Chen-Yu said that except for debugfs that cannot be > observed by user space anyway. >=20 > It's nice to have the NEW controls have multiple channels, which is what > this does. >=20 > >And also, wouldn't > > the controls be called "Left Mixer Left Mixer Left DAC Playback > > Switch" (for the first one) now? >=20 > No. I checked using "amixer" - the names look fine, > "Left Mixer Left DAC Playback Switch". >=20 > With the patch series, amixer says: >=20 > numid=3D10,iface=3DMIXER,name=3D'FM Playback Switch' > numid=3D6,iface=3DMIXER,name=3D'FM Playback Volume' > numid=3D5,iface=3DMIXER,name=3D'Line Boost Volume' > numid=3D9,iface=3DMIXER,name=3D'Line Playback Switch' > numid=3D4,iface=3DMIXER,name=3D'Line Playback Volume' > numid=3D1,iface=3DMIXER,name=3D'Mic1 Boost Volume' > numid=3D11,iface=3DMIXER,name=3D'Mic1 Playback Switch' > numid=3D2,iface=3DMIXER,name=3D'Mic2 Boost Volume' > numid=3D12,iface=3DMIXER,name=3D'Mic2 Playback Switch' > numid=3D7,iface=3DMIXER,name=3D'Mic Playback Volume' > numid=3D18,iface=3DMIXER,name=3D'Capture Source' > numid=3D19,iface=3DMIXER,name=3D'Differential Line Source' > numid=3D8,iface=3DMIXER,name=3D'Left Mixer Left DAC Playback Switch' > numid=3D15,iface=3DMIXER,name=3D'Power Amplifier DAC Playback Switch' > numid=3D16,iface=3DMIXER,name=3D'Power Amplifier Mixer Playback Switch' > numid=3D17,iface=3DMIXER,name=3D'Power Amplifier Mute Switch' > numid=3D3,iface=3DMIXER,name=3D'Power Amplifier Volume' > numid=3D14,iface=3DMIXER,name=3D'Right Mixer Left DAC Playback Switch' > numid=3D13,iface=3DMIXER,name=3D'Right Mixer Right DAC Playback Switch' Great then :) Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --nskfsqj542gg4f7l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlr5l+8ACgkQ0rTAlCFN r3RI/Q/+PAO/voPZOI7mkTKuiCT0j4SLs3Xn9K1UojwPx0gbCrLScJBgCWpOuB8l erMFBAd0LiNbfl1SpWrpigb0euBUVZyy4UL6vMOFtuq6HgI4qP7ix25pYC/PXCPg Ph9hd91fztZePKz3cEhZwy2qkQR7EeBtwnKyjdOV3dokFarDZRT6QixUsLQTHvxa lVnGraTARzVY3JPuPCdfIPTQVAPlHm5BHBotXZlWHf7+LYmpyKAdBtY6JsnhzWSX UJq1A2HPylD/yl5mJm3UHKBlUS/C6sJQhjsYkycQWBSxV7smyLq1P2RQl8O5e6vx vnTYWGHjyIIotqNzavICLMAQTgLU1hDJFlHm3kj972W8D/mk1XOJshjC8RWCqbhg 8vNwAtMxMgsVynMXau6254EUd1OAGUsiodsPUubBvJaYA8HcIgz5bmcTMrQwXeny Rwlv9l7KOP7FTQhN3oboi95RKFzEZeFUz9VSD8WJdRwXgyTMuMRp2rJBW6eG1ai7 +cGulZJSyLV/7wlIY18JhqlNeVfbiTXe+FJCRZDD7m6X6HyPRY7K4/dSfezxNksE 1bt+u/j7tYuxdHGAJSvi+ZkXShkxpnG1DY/HV6Anq2DcXmY76fRWB8s+0dRyWume Dxyd75qYuX2KGYAfo/nGxnBO+VNgWbglm0l6bMUoCbiEPXuGjDs= =vAgz -----END PGP SIGNATURE----- --nskfsqj542gg4f7l--