Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180425203703.650160358@linutronix.de>
References: <20180425203020.594959448@linutronix.de> <20180425203703.650160358@linutronix.de>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Mon, 14 May 2018 16:35:50 +0200
Message-ID: <CAOFm3uGECug6Hr8_UJt5QTGd_=Fae_Hvm_1Y9xyJri008EoHEQ@mail.gmail.com>
Subject: Re: [patch V2 7/7] scripts: Add SPDX checker script
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>,
        Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thomas,
Sorry for the very late reply!

On Wed, Apr 25, 2018 at 10:30 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> The SPDX-License-Identifiers are growing in the kernel and so grow
> expression failures and license IDs are used which have no corresponding
> license text file in the LICENSES directory.
>
> Add a script which gathers information from the LICENSES directory,
> i.e. the various tags in the licenses and exception files and then scans
> either input from stdin, which it treats as a single file or if started
> without arguments it scans the full kernel tree.
>
> It checks whether the license expression syntax is correct and also
> validates whether the license identifiers used in the expressions are
> available in the LICENSES files.

Looking good to me! And the use of ply is sleek.
-- 
Cordially
Philippe Ombredanne