Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4634138imm; Mon, 14 May 2018 10:17:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqHpt21k+s/H1h+D3TLtfGioiZMes7l9U4wcikBn7TbrauUzaICGNIPAG59S5IQ6S1c1/Q/ X-Received: by 2002:a17:902:1744:: with SMTP id i62-v6mr10957171pli.267.1526318224965; Mon, 14 May 2018 10:17:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526318224; cv=none; d=google.com; s=arc-20160816; b=x1MROlYs29iL8U2+drmTkQ9wx/TqBG9uyHVB/oHR8tVKAlONQLWyc24tPP0e46yU7L pLdYVoggHcRO79v4DvN4834psaIQtYEUbpJzy5U0fTFfKc9vfr502rexiwhIvqQoWdgl vrr42jqY0WZa0Iomz1V0trSXJm6J6uOqEDT7101gUDG/KB6asB822jYEFQEoCyebSi7F NipUacjEfdj133F96+f+ThE7CWLvaejsLO8pEnJ84wdPnc+X6Vmn8e6qGRfaO4cQNMQN E5NLbOumvFHJbQTO+2XEmzUgVWbe0smIzhSGqgJlPSvLA4i9wPsUJ8rGbEhpN5SeZyq6 U5qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=pDf3QRNP9vyA3Jxv7+CS2DUsGMgDnrRbyrPMOfXQq5E=; b=Fjbtb6ZbrfplpTmsNCIEEfLtaYfE0/Co7O3qWLp7CZp8WLoJIrP+DBPTn4TacRkBVk 1RqLOXyvN+dT6cx7DgbbyMuVUCBhr7MrskJG6UbNRYrbOpuY/F9LV71g4J2Ef5LpylkN uInBR0xWbG9dRbzLg+HPGRGgy7SO+2vYoGfvKtqs0d7SEjVu0ggi//83S4Wt1YsJTfuT rikvdkXuKq41l27MQtrizrgDTBiTCqhtQ1PzCMeaXpobYJhb1atCp1XGUD01+7fc+Grk 4PEOkDYSNRcFkHQMH14IvueHxLInIOwwGYrdY7VJKHNC+wJePYgl8ZnrvOqsIyTocAdz 4Xgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=h1mtZwxO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8-v6si10860304pli.75.2018.05.14.10.16.50; Mon, 14 May 2018 10:17:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=h1mtZwxO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbeENPM0 (ORCPT + 99 others); Mon, 14 May 2018 11:12:26 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37989 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbeENPMY (ORCPT ); Mon, 14 May 2018 11:12:24 -0400 Received: by mail-wm0-f65.google.com with SMTP id m129-v6so15868857wmb.3 for ; Mon, 14 May 2018 08:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pDf3QRNP9vyA3Jxv7+CS2DUsGMgDnrRbyrPMOfXQq5E=; b=h1mtZwxOvliQ2ISvmsWOIH5/dYO4BuXE1lQDLaPwfvhwrd/v9PKyCWPspmlVdMkgG8 8S8tUHxiTiNcyZwDhMn1jFPtt9MbqY9CMjWwVEc7cS3YJr+URxS8mbVZ9BWN7kWCdjCY ZGjwZ0k89KYMTsAJ8UXocnU30MAHGhWuA709vwNS3BV+XVNQ2BibUK/DOFbd5VuvCiBn 2L+AD1KudS1wnmMxNLaKGDcbOVyLBiAgSBBQu+oqJwCm9aj5TISCZy16PXl3x0U5If64 fCT5ZqNag1lpWxxS87d49nAI1Vce/L7dEmwbCTLe/Atnxufw3yb0snpmqr5iA7CHhim3 PGfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pDf3QRNP9vyA3Jxv7+CS2DUsGMgDnrRbyrPMOfXQq5E=; b=kT8bP/T/xb6ESxRTz3tf+lHiD/ujbH1UIBXUN9GXFmCQx+Pt+gRtj7vdZoemLMW19m 4h3UolkKyzStS7GVlerXKXIBRgQdsSqc2PaOaQKTqcHAMDoo/geMG5O/udeJ2AfpdXVb KZtGA1g2iP91Ba/R+27VsxfF/g0HLz+ylWLEyxkp+zNfqyUWWxw+WuD4XrTAQdAj4Dp5 D1lmc4qRpkU/UaUxKoL5vie0D/5oaOIlxSv3gafjFJty0tNBKVV4qQGBIhP9Q/fLCMG1 lr5syJAw07ABCZmyzOYAiXKEGXoWCLdebn90jkZac/31Jx5tspco65ncIT3RW5HijaOu x6Jw== X-Gm-Message-State: ALKqPwedwNoyAaEXHsHcFkPCgNxDkXExzvXUPTRDWg6994iFMBvqQN3D Be61IjuBADYQo0JfFmGyuI1b9A== X-Received: by 2002:a1c:9249:: with SMTP id u70-v6mr5162655wmd.128.1526310743457; Mon, 14 May 2018 08:12:23 -0700 (PDT) Received: from localhost ([89.24.58.58]) by smtp.gmail.com with ESMTPSA id w6-v6sm11917468wra.16.2018.05.14.08.12.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 08:12:23 -0700 (PDT) Date: Mon, 14 May 2018 17:12:22 +0200 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 03/14] net: sched: add 'delete' function to action ops Message-ID: <20180514151222.GC1848@nanopsycho> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-4-git-send-email-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526308035-12484-4-git-send-email-vladbu@mellanox.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 14, 2018 at 04:27:04PM CEST, vladbu@mellanox.com wrote: >Extend action ops with 'delete' function. Each action type to implement its >own delete function that doesn't depend on rtnl lock. > >Signed-off-by: Vlad Buslov >--- > include/net/act_api.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/include/net/act_api.h b/include/net/act_api.h >index e634014..73175a3 100644 >--- a/include/net/act_api.h >+++ b/include/net/act_api.h >@@ -100,6 +100,7 @@ struct tc_action_ops { > void (*stats_update)(struct tc_action *, u64, u32, u64); > size_t (*get_fill_size)(const struct tc_action *act); > struct net_device *(*get_dev)(const struct tc_action *a); >+ int (*delete)(struct net *net, u32 index); Probably better to squash this to patch 14.