Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4646252imm; Mon, 14 May 2018 10:28:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqbedGHBSqkuMj9Ou3+vVZ00iEuRDPnEqlY5BTm4aX9Zb6TcuaHluqdRGiYqUdePDHUMEtb X-Received: by 2002:a17:902:321:: with SMTP id 30-v6mr2155347pld.122.1526318939803; Mon, 14 May 2018 10:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526318939; cv=none; d=google.com; s=arc-20160816; b=b/vGOAkWSbEL57phq0E8aDKqJuLkxHa2fJnlWlhw6sEliySzHU4V5DajYN+df1HXrY cdn/eDN2z0V/9kRz/lEnSDhUaF2T2SKhjyYEVbrOxXW3gjXEVIKASJYcUJmKqELFZW7p 7iIZDCEXFUd7MEn+50tW3uUWZMZ0fhw7Hm4x9A3LfNnFe8qvznHukuNtqvbpv81d+qxT e+wPQxAtynIRCniXqx254wyMyzTMcPiWYhgoBKbrFogdDHRO4rbGZxVKY/Md6EG9rC1f cMAc3Ax8ZAWd3SoeoJ0VpBSq6cvTHz00T8AzIThJX0l6rWvjkRtEU7W2cV1CxzfzKTkq ppog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=OO+eoDqyquoBfDmNhv1Nt3WHy+8pCLxNLPbptw8KRjA=; b=YQ/dnmrs/AjW9Wl8ZUMs69v3NvIpwEjZhyWncSqE2XosIJKsAxlf+rvsS7I94Vfw41 KwwJlZwndylPFAcHGTo4/EY5xtmnKRVUW+aF+EvQgN/I3D7kBo1PoNFlBOKnF7WDx80r dig1MulhI4Fg87fGdXd8k1XS/O3sqdZ9IOQ/lh20Q3X3WybLfcuNvyz7JRC6t73KpC80 6nRqoUJRyajbNN1Jms0c+Bqzl65Bln6b78WwrQoxdQ8fPAXFWFV4iE/+JSW3cgu2pARU iHKlMF1Ew2VFgStf4gdgJSgBKED2aICkBZfTFhJkIYHJcF3rWB0jz7sS2aqknKlQ5sd0 jd+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=MjOBGnq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i190-v6si7967603pge.408.2018.05.14.10.28.45; Mon, 14 May 2018 10:28:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=MjOBGnq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089AbeENQ2q (ORCPT + 99 others); Mon, 14 May 2018 12:28:46 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:51517 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753342AbeENQ2n (ORCPT ); Mon, 14 May 2018 12:28:43 -0400 Received: by mail-wm0-f68.google.com with SMTP id j4-v6so14637453wme.1 for ; Mon, 14 May 2018 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OO+eoDqyquoBfDmNhv1Nt3WHy+8pCLxNLPbptw8KRjA=; b=MjOBGnq0Gm4sHE5V/rPRIycXYdoYVQVEZxI54FyEfdVTFqwSjoJP0BNgr4pA/WCfvt GE1LMgmoi9azzJNOGcBQJAfppdXC2ovIdaaIqQ1ehMy24xpG1QjG5FtSeJq44OflGVgo T0qazHmMaDNdQ2/ZvlSC9gwkwm2AckHyxvVy+ebeNq7wvWe8r4DEGRcuDHlMSOn2ctg+ y2OQ4Ep3lRH2rmEJaM994f+kQl5/YTfAFZjsLELqbcfee4tyZL0s4/ZOfRHSgzO1xw6S iZ90j+yPMWy+4x4fBxbfTsPPIUA2uHEcGN6VPfJuVMflR+2a6Ik3ChPEp6uaL6s04IBl +irA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OO+eoDqyquoBfDmNhv1Nt3WHy+8pCLxNLPbptw8KRjA=; b=uhsAbx5YS868P5OHwa8vE4Zm/kqCD0QktEc3/6livgELT4B2FbGgwj0GzIS5DUzcq5 +egXfR5gBcPLQpoQJVH3t1UpsEiXgGDAi5eKCET6fcqDWUEjzSmSi19j2MKo0wSNQIsN xlOVKiQ77wHBcd37hvxptKB+ZQl972fXD+eH4NLAghYPzKWU2ng22owA5sds/MbxVl+W YEHa5mhUBACAXhetlIL0bLIK+JkG/ugL25EHfvWZ5wrwOnjILqUMEgxBoxnYpaTfCNM0 Lpj7ID8eDgkmmQOyVYgQzKU28F6Rruo4XWJ3udMzJRxhFi9QuHcbdKSxAbcwdOn4S3Gn O/zg== X-Gm-Message-State: ALKqPwdd88fu41amFmwo8+XhZ5T8/zS/bhEqzDSFU5sTBrIBcsbp94qy LEbGnjvaW8MewUSxNH9nCmgSjA== X-Received: by 2002:a1c:8795:: with SMTP id j143-v6mr6068202wmd.149.1526315321010; Mon, 14 May 2018 09:28:41 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id 132-v6sm13535877wmp.15.2018.05.14.09.28.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 09:28:40 -0700 (PDT) Date: Mon, 14 May 2018 18:28:39 +0200 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 06/14] net: sched: implement reference counted action release Message-ID: <20180514162839.GD2134@nanopsycho.orion> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-7-git-send-email-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526308035-12484-7-git-send-email-vladbu@mellanox.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 14, 2018 at 04:27:07PM CEST, vladbu@mellanox.com wrote: >Implement helper function to delete action using new action ops delete >function implemented by each action for lockless execution. Reading this sentense for 4 times. I still don't understand what you say :( > >Implement action put function that releases reference to action and frees When you write "Implement action put function" it is cryptic. Just say "Implement function __tcf_action_put()". >it if necessary. Refactor action deletion code to use new put function and >not to rely on rtnl lock. Remove rtnl lock assertions that are no longer >needed. [...]