Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4646962imm; Mon, 14 May 2018 10:29:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr2t1BCqBwv1NLXQKw9Ih2TmbmSHy6BRYV01hR/RyBiEnoPIi1ykimtXj5gb9Wt5tW6IBMS X-Received: by 2002:a63:7b1d:: with SMTP id w29-v6mr9284804pgc.417.1526318989673; Mon, 14 May 2018 10:29:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526318989; cv=none; d=google.com; s=arc-20160816; b=Kt1MtPYqWyATOJU/96H8CJ0U4duNdBYjC2koTpez+aDHl421raxoktAds0DgKcL2Mk Fbeb9jB890aBhyFB4JYNUWuzAPsAMd7jdrQAahp03Qg9hvmPl7C50dP1oaLMyhQzN2sw bZAAv8Uz7fi9CU0oNWZcKQQYci8W3z6NLNl8mLX+PCbQlHqgfu2yMVX/tSpo2K723yXD oxKaLYJI+/WVK2KH6QmJwAeUXsqx0rutdBtfB0eOo7mz8wJGZLlFYGbdGkaRUGMZUjC4 dU4tGhW6M7DV1V0MzBBakDtUoFVsFjpOgAZPu7S44htVr/vRtLvL/YbG7cvB22sQf1k3 iGOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:arc-authentication-results; bh=yIrz9KTzvqA53utFJ6bOofv40H+N1CeFd1i4rmYR4/k=; b=sSEejfMZHnViSixdSUPT2om+joCC2rOvO+zm0zN+trhDgPcOdKfhCTxrd1rZx90V5H BBSGqZxYxJc2i5X3XhtUAYdFI/Eui0inpfurxQ03nKGAqH03rc6umAUgXbLgViffjSAs /bUxAB6LVSGKWdZHfjtW46Iel7xdqtQYrOA7x/NdZXUppNIvZkOlUfFac8x9VTSdgAl3 Xxn+O9qH10NmcVo4cTEh87YB1KMZt3MO+eRf8rRdCzYYPgCZBXBBb9kZEUFMf82AK8zS sUav+RLYOW/eFgCQ+ydqM4TwqndYS3Ru5lTyP3Hzl8X8O7oEMc+Ggpw0As0bQFTZ3jPQ NY0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34-v6si9821121plm.495.2018.05.14.10.29.35; Mon, 14 May 2018 10:29:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932281AbeENQoS (ORCPT + 99 others); Mon, 14 May 2018 12:44:18 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34476 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429AbeENQoQ (ORCPT ); Mon, 14 May 2018 12:44:16 -0400 Received: by mail-wm0-f68.google.com with SMTP id a137-v6so12493227wme.1; Mon, 14 May 2018 09:44:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yIrz9KTzvqA53utFJ6bOofv40H+N1CeFd1i4rmYR4/k=; b=R8mjPNfSkh9Yrw6vBZy2bUW4sMQJWUBB3Fnpq+B6HOYIAUGoHVy1LNJeYh2jaEwvdN PNMhi3H60DrN3gGuwlXTGj11YKh8QH+jNk5vR7O4HXesRKhNS4fUGzbWtb5aVuZ5v5/b /GfgNgf14WLt0s1Wu08J6GCSRbxvVOtHH0Mcyug92Nhotf3rbsD1Xthp6STKuDejlOKE jYxnnMda0+EMPzUp3b5znnWYYGmnVrgPA2aPySDw7QhqytG6jQPttdWko0nfYwUf8tcM yxc6YbK+L6rXq7QFD8hlGu82FVi981iGc7uRk6SIFIOi7NIW8eSNlBgZLi3Wh2oLhdRr jQUQ== X-Gm-Message-State: ALKqPweWrKtJurtusqJXYxwbC1qT2XLzOCGCcSbFhn0BBTwbumA8WI5N ITsTsSlb8iKk3Xk9+S90MtTQJhyQ X-Received: by 2002:a50:b5e3:: with SMTP id a90-v6mr13483063ede.69.1526316254266; Mon, 14 May 2018 09:44:14 -0700 (PDT) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com. [74.125.82.47]) by smtp.gmail.com with ESMTPSA id b43-v6sm5276276edc.34.2018.05.14.09.44.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 09:44:12 -0700 (PDT) Received: by mail-wm0-f47.google.com with SMTP id a8-v6so14669384wmg.5; Mon, 14 May 2018 09:44:12 -0700 (PDT) X-Received: by 2002:a1c:c5cd:: with SMTP id v196-v6mr5445913wmf.16.1526316252481; Mon, 14 May 2018 09:44:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.142.19 with HTTP; Mon, 14 May 2018 09:43:51 -0700 (PDT) In-Reply-To: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-4-jagan@amarulasolutions.com> From: Chen-Yu Tsai Date: Mon, 14 May 2018 09:43:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs To: Jagan Teki Cc: Maxime Ripard , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 1:20 AM, Jagan Teki wrote: > On Tue, May 1, 2018 at 9:53 PM, Chen-Yu Tsai wrote: >> On Mon, Apr 30, 2018 at 7:40 PM, Jagan Teki wrote: >>> Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them >>> as default. >>> >>> Signed-off-by: Jagan Teki >>> --- >>> drivers/clk/sunxi-ng/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig >>> index 79dfd296c3d1..1fffd3bf6ff3 100644 >>> --- a/drivers/clk/sunxi-ng/Kconfig >>> +++ b/drivers/clk/sunxi-ng/Kconfig >>> @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU >>> >>> config SUN8I_DE2_CCU >>> bool "Support for the Allwinner SoCs DE2 CCU" >>> + default ARM64 && ARCH_SUNXI >>> + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST >> >> There is no reason to depend on DRM_SUN4I. There is no compile dependency. > > Since this CCU is for DE2 I've make DRM_SUN4I for that matter, any problem? Users may very well be just using simplefb, but with all the clock drivers enabled. That is a valid, if very limited, use case. So again, you should not limit this driver based on DRM_SUN4I. There is no compile dependency. > >> >> Also, this is needed on SUN8I as well, pretty much anything with DE 2.0. >> So you shouldn't limit it to ARM64. That pretty much breaks things for >> people with A83T's or H3's. In fact you should enable it by default for >> these as well. > > True, I've skipped SUN8I since this series for A64. And yet you are breaking existing users, which is a big no-no. ChenYu