Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4699701imm; Mon, 14 May 2018 11:25:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZroLUVR5RvwUGFlCPh0xO6vsKOxBByZFoqIe+otTjHZ2kfTi1E0+8UUNhCdzBmiqR8ZBODS X-Received: by 2002:a63:85c1:: with SMTP id u184-v6mr9424551pgd.442.1526322313015; Mon, 14 May 2018 11:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526322312; cv=none; d=google.com; s=arc-20160816; b=q62BoWBYRIHgSZnJ7wAE2+FRMzpUDFyxHr5VB82AkENu2UlbrXDqJI5isUEwtoGBUH WBagpluEEGY+1kj7WPj02mWICtX8lkC5l3qNzkkHlMOm9OG6K+NPRidjfrTJvYiWFtTC uUJn012fKzURw/dzxZ+k4o9Zw6fdDJHLRtRXJp3zCcj5kgClB8XprDrNaj66jNLqgRL6 W1AQ/WgEmtfH+F3BJ15Rnro2ZvXmBh3b/xlyiux/0ICWKz8N4e/JKPEPFMKMZwv923+5 sKnhCxb+TzI+QHrcNV6tI/DO6FjFYKtXCD42UbrRdAlXnI/qfVTQE/IOuZTBuhkoSNbd wKXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=watXx63Nmjfi30yI5ljA/z2Yv7yUOzf338gL3+ncNVc=; b=Fsjevn6MJxgsGTycQEvMTK1d65fPw0ZvgiXelEYl/HGNmUCHb90ELpOWFVX9SxRFP1 uan+QqfUXIem3Tt1b9t3cITaQ7tnoAzEs7eotKr5ZXfWqTPyu+vuf85jVF+gK18PIz7n cs14hkgbP1CmImDcbskAeutNIOj+VQxUA5AoiwgLgQsnABtZZoT1Yue9ZGKfXoH/5mS1 cviPklSoJrxBBJ3e3qpSlUP5WVbouw2Z7sLp2nFpsJNqCtD7rEMNFDW6TA6AKsMy8LYm oSbvA3IyafiR1QeZJIST6Ewopk3P9gWj2CfFGWXxXUw5fwb8KQHXxl4GGD771bH/kGAN h5mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=hdfwA+ha; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a18-v6si7999994pgu.59.2018.05.14.11.24.58; Mon, 14 May 2018 11:25:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=hdfwA+ha; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752054AbeENSYr (ORCPT + 99 others); Mon, 14 May 2018 14:24:47 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:57550 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbeENSYp (ORCPT ); Mon, 14 May 2018 14:24:45 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4EILLcc151277; Mon, 14 May 2018 18:24:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=watXx63Nmjfi30yI5ljA/z2Yv7yUOzf338gL3+ncNVc=; b=hdfwA+haTnYRh1wEdd86jR6ju/1+89tzzXljsgz5o6Aes7B7M4P5WZlXgFAIvGb9y3y3 6zeVE/lkfBwpDsOcs5YAdElxonwWDCad2Sa1JBUT3NXCblev67VWkl8Wz9Q0yY6ZtU6C T9l7puSiGnIdMZIbfmyYpBVgVDTNa6S0oUQtuS3BTZGInDKyqirNXD0MZMnt9RH4/a/W LxDf4pfrkobIfNZhkpwI2g9+zHwZUqfDdUZNIEScRvAxVna+1jeuniTMWJLbGg8fdzEd mH8ti91/1vUlKHs/WIpS5VZF6hpg3XfELQYa0l0bQEd4nvUXYICxv3iRvbO9dVmuwGlS 7Q== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2hxpvckwuf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 May 2018 18:24:40 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4EIOdF2016706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 May 2018 18:24:39 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4EIOdtL005225; Mon, 14 May 2018 18:24:39 GMT Received: from dhcp-burlington7-2nd-B-east-10-152-55-162.usdhcp.oraclecorp.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 14 May 2018 11:24:39 -0700 Subject: Re: [Xen-devel] [PATCH v2 1/2] xen/PVH: Set up GS segment for stack canary To: Jan Beulich Cc: xen-devel , Juergen Gross , linux-kernel@vger.kernel.org References: <20180509203318.2611-1-boris.ostrovsky@oracle.com> <20180509203318.2611-2-boris.ostrovsky@oracle.com> <5AF9862C02000078001C27B5@prv1-mh.provo.novell.com> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Mon, 14 May 2018 14:27:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <5AF9862C02000078001C27B5@prv1-mh.provo.novell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8893 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=796 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805140185 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2018 08:50 AM, Jan Beulich wrote: >>>> On 09.05.18 at 22:33, wrote: >> @@ -64,6 +67,17 @@ ENTRY(pvh_start_xen) >> mov %eax,%es >> mov %eax,%ss >> >> + /* Set base address in stack canary descriptor. */ >> + movl _pa(gdt_start),%eax >> + movl $_pa(canary),%ecx >> + movw %cx, (PVH_GDT_ENTRY_CANARY * 8) + 0(%eax) >> + shrl $16, %ecx >> + movb %cl, (PVH_GDT_ENTRY_CANARY * 8) + 2(%eax) >> + movb %ch, (PVH_GDT_ENTRY_CANARY * 8) + 5(%eax) > Is this meaningful / correct for the 64-bit case? I'd rather expect you to > write the GS base address MSR there. Yes, I should use the MSR for 64-bit mode and existing code for 32-bit mode. -boris