Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dexuan Cui <decui@microsoft.com>
To:     Stephen Hemminger <stephen@networkplumber.org>
CC:     "kys@linuxonhyperv.com" <kys@linuxonhyperv.com>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>
Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0
Thread-Topic: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version
 5.0
Thread-Index: AQHT6dQOF2Jt1OtZ802pCkKtamiImKQt6r+AgAGeN0CAAAMjgIAACSwg
Date:   Mon, 14 May 2018 18:55:50 +0000
Message-ID: <KL1P15301MB0006C2F8F9E32E736DAB082ABF9C0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
References: <20180512093033.12325-1-kys@linuxonhyperv.com>
        <20180513102409.4adc5200@xeon-e3>
        <KL1P15301MB00063E97D759B64F1CEC046CBF9C0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
 <20180514111755.371d1d46@xeon-e3>
In-Reply-To: <20180514111755.371d1d46@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-05-14T18:55:47.4868415Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2001:4898:80e8:c::70b]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;KL1P15301MB0054;7:nyBod1Mr7SMn0npe90h2udfXBvqy+FiGvfWTRkxXHSdXfE4GmpgUFrHUjIPZ0/CYdWVHJng5I0fJ84dj1V6PVEtqKQV4Alz3uAaw6ZzDQOU5sH94wkqKJNRrvUoDihH+v3YJr6zqVbfZN9pnQ8Oust5cgOEJVTco3HVYuUEcQTnJy/9CXnwgnbtnkGKHFVJwQnE2dqEpWvYZVsiLExTWMVLP03/g1vtG13RoR8BcS7slinj96Lwdypq5Mq9RNEuT;20:V3M4R/lQmPbq//pVMq5kLi4MCCwfg2ZZwtc0o1VewIs9eNb/LxZDrdYL3M1tKbkL/o0sSUdak//SE2kpzEjrPbuPQ+tAu3Ml/iR28MxRvH1otwZ/hq2EpcmRZfMD2uWJ7ww2GvTklNU/PB4ZYsXg8w7mnhv0GGkueYYy/zkgnUg=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7193020);SRVR:KL1P15301MB0054;
x-ms-traffictypediagnostic: KL1P15301MB0054:
x-microsoft-antispam-prvs: <KL1P15301MB005477C60F16D807D0059C3CBF9C0@KL1P15301MB0054.APCP153.PROD.OUTLOOK.COM>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:KL1P15301MB0054;BCL:0;PCL:0;RULEID:;SRVR:KL1P15301MB0054;
x-forefront-prvs: 067270ECAF
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(376002)(396003)(39380400002)(346002)(366004)(189003)(199004)(24433001)(10290500003)(105586002)(106356001)(5660300001)(99286004)(102836004)(97736004)(3660700001)(25786009)(229853002)(6436002)(3280700002)(446003)(46003)(11346002)(86612001)(86362001)(2900100001)(2906002)(68736007)(93886005)(8990500004)(81166006)(4326008)(10090500001)(81156014)(14454004)(8676002)(22452003)(55016002)(7736002)(486006)(33656002)(305945005)(6246003)(478600001)(53546011)(6916009)(476003)(6506007)(76176011)(74316002)(186003)(8936002)(6116002)(77096007)(7696005)(316002)(9686003)(53936002)(54906003);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1P15301MB0054;H:KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: EtEEZCuomqPEv9IFopmEj8z9PpiReaOSgwa2LvvKEZCY6BL/aEvVKQ7fQUJwfJOA6sGv2jNOQM+a/BZkGY7heMm5JATUV2S2ZlQnCz8yB3Fq4ifr3B9GFEgE2vsh+7su9t58odbIf2RZEJs4ODFAswR80RiUmbsDeaTHJxtcDx9RWKIZViHA3GCfSxVbhPEA+OmCssVWi6mgnDpyN8zPng==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b3802b23-5ccb-41dd-fe5b-08d5b9cc4fd7
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3802b23-5ccb-41dd-fe5b-08d5b9cc4fd7
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2018 18:55:50.1050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0054
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, May 14, 2018 11:18
> To: Dexuan Cui <decui@microsoft.com>
> > > ...
> > > Hate to pick o the details, but buffer is void * so cast is not neces=
sary here.
> >
> > Yes, it's unnecessary in C, though it's necessary in C++.
> >
> > I found the patch went into char-misc 4 hours ago, so it looks we may
> > as well leave it as is. IMHO an explicit cast is not a bad thing. :-)
> >
> > Thanks,
> > -- Dexuan
>=20
> Kernel developers like to be concise. In fact there is a smatch script th=
at
> perodically  gets run and more cleanup patches get sent.

I checked the "git log" and confimed you're correct: there are a lot of=20
patches that removed the cast from "void *". :-)

Then let me post a small patch for this.

-- Dexuan