Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4750371imm; Mon, 14 May 2018 12:20:50 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrWesl+VXiJLEDoGCXSQhpJ6jFds8DJ8xcdY24dJWFCGzZKbdFXd+gVRREMqzGXj62CjAiY X-Received: by 2002:a65:4688:: with SMTP id h8-v6mr5154548pgr.27.1526325650853; Mon, 14 May 2018 12:20:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526325650; cv=none; d=google.com; s=arc-20160816; b=iSc5tX1oiwreLKqzPG0OHF8BDlMofUzA9m2R930QvREZdfHesGGB9EWyCdsMvK0J44 aqv7ewT3Wq5sSuyx0KY0/5lJWDpa6aRjTV3kJY5mSFcue9XeKvcWRtm9XdSMG2WYXGiM 7AhDJ9+moyzJVewry2uuNNTKdGrB5dsZZ8V9lwwjXfDxApK58e877BQDvN3GMjj4R/4z 6LCQ2DZkfsA4LwI+Qz6xWbMRdAdt522UTnXkPLg4uaCZDdt6Ym3FKKZW0DKkQE/27ymW 1AtL7Vc+s2kMC52PJtgb8c8uke57mZOA0QQbrxKKWQeTs45kaa4Y6prn/9o1fe9MbbAN kJ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=xlHftW5inLhKC+G95NLXDaiA2zXVRGJaWb+xO6NuNiA=; b=Q9ClmhlrWxARdq93dijaYYBqJJBnLtmacQTPehLkK6IPaGZoQIW94av9temNd2bqk7 WzJPvQVinVpRxFDjWyJb/ND+wq4C5uozaj/JgiOKjD8E2UAiQBJ4hINf4+VvOjWmKLru AE0uhvCf84LJCmVGl0BsG8F8b7ywDzmFzgeGyP5+wfzP1ZLOZpm2ML8QQITRU0MeEINo UeuFrMewuxNzOwvVVcOQIWZOEF7O3EJceVFV13v/AggLP46/FE4mzqCmZMDq/hRTqbNU jnIvQEMhz+qkGIlJaWx/ucshgPlmHtmSh6LeDctWN5mR4EHsYe8G5q3wObV4xVr1JVO+ 4jEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NUkfITBe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d21-v6si6239045pll.147.2018.05.14.12.20.36; Mon, 14 May 2018 12:20:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NUkfITBe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbeENTTE (ORCPT + 99 others); Mon, 14 May 2018 15:19:04 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:41970 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118AbeENTTB (ORCPT ); Mon, 14 May 2018 15:19:01 -0400 Received: by mail-qt0-f195.google.com with SMTP id g13-v6so17645150qth.8; Mon, 14 May 2018 12:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xlHftW5inLhKC+G95NLXDaiA2zXVRGJaWb+xO6NuNiA=; b=NUkfITBeRDNMBIlTlK+QLuL8joJtyYLahcc+9QUXn8dxBzVBAhbcFyEIUagdHa7kBy GFmBBogxGbSwqT93aMBGH1biwyfQQhaJUM1g6yiLEVHTFdKJCqwPD7HTz3ArvEB3g06E oy4pya303zoaPfWmc7D5L61Gqf4VMTJ2gN2nyirBPZ7cHECJ/yqla9NmuUhBmjj3Lroa FmDqrk7+4FGapKokzs33InX+dwm7afL7FoRPsFBUn5q1ZrsXwIBP+PVdk1mWD+cBETSN 0YnhBpYl6eDLLWihJCmtY7F/oppoAVEKm47CWGde/DqvddLF+q/NCz44dgeU3ltgCmVF Ng0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xlHftW5inLhKC+G95NLXDaiA2zXVRGJaWb+xO6NuNiA=; b=jAeD1teVbk+/870Rdsu8g5Gn+lesFqxp+iCsvq3AeSKBROKjQYN3B8OnyDi4AfVzNN tQCpA2g1i+rcZhIlb5C4fyINOX41JAyAx0+XNi722b3Ea/+fzHbO02lp8FpyrUenLd2D wBMofXyZxrJ+0BxiZVHAMG5f+rXKx4AS7FAcdUCWTlDDl/Oj5Zo8dc2L3ueGWGpuzeTu 8e9xH6laZJmQIl+kxrQIZos0WJPudfFrd55/rWddGaGg+sz+XEXwCd8TQ3Z3Hiuc+kvK lrExCae6/4PjQUww5LLLQamjzOMuxJkvOCl9FcwXY3vncNRinucG+VQrjiIhe2EVhyJo fiVg== X-Gm-Message-State: ALKqPwc9EHqASaxqBek1OeiZWdDLPOZTFD0FOma3lq/GWxuzum1+/8wr UnvlTPE1ASoUBLIGuskNSA== X-Received: by 2002:a0c:f8c9:: with SMTP id h9-v6mr10451902qvo.122.1526325073981; Mon, 14 May 2018 12:11:13 -0700 (PDT) Received: from kmo-pixel (c-71-234-172-214.hsd1.vt.comcast.net. [71.234.172.214]) by smtp.gmail.com with ESMTPSA id r189-v6sm7254593qkd.38.2018.05.14.12.11.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 12:11:12 -0700 (PDT) Date: Mon, 14 May 2018 15:11:10 -0400 From: Kent Overstreet To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH 01/10] mempool: Add mempool_init()/mempool_exit() Message-ID: <20180514191110.GB8869@kmo-pixel> References: <20180509013358.16399-1-kent.overstreet@gmail.com> <20180509013358.16399-2-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2018 at 03:11:45PM -0600, Jens Axboe wrote: > On 5/8/18 7:33 PM, Kent Overstreet wrote: > > Allows mempools to be embedded in other structs, getting rid of a > > pointer indirection from allocation fastpaths. > > > > mempool_exit() is safe to call on an uninitialized but zeroed mempool. > > Looks fine to me. I'd like to carry it through the block branch, as some > of the following cleanups depend on it. Kent, can you post a v2 with > the destroy -> exit typo fixed up? > > But would be nice to have someone sign off on it... Done - it's now up in my git repo: http://evilpiepirate.org/git/bcachefs.git bcachefs-block