Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4824733imm; Mon, 14 May 2018 13:52:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrH1ofZ35SHyC6BBlpI4q4Yx8ToeuMNxgbnr71hnbGTLdx1IgRPklWWbikHySyebiUp8L/f X-Received: by 2002:a17:902:7406:: with SMTP id g6-v6mr10880847pll.237.1526331160187; Mon, 14 May 2018 13:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526331160; cv=none; d=google.com; s=arc-20160816; b=t5TUwfNV6T3io6un4+oA9qro/dD4lrVPzntm9DPOyPcmY4PScIccJrekhGKs26chuW DjGLvueFUHqzjU5mbaNLLICeBu4g6dCMgr93hzx34LnUsY3mATokkDKOYYjZ/WH10b84 MOpcvfnD+SaAQDJBBLWdy9xciMNKFn0CCi/CgjoEMBbScxtVEOYq2lPZGhteoBIBVCKE IGkqEfusPOZmdghSjHMuscrcPdo8iAUBM7kDvymK3LElgqHnN4nZSQNxEKJ52vkmamYS AOLdaTOi68EhQAGyJaJmy/zPFanXIwC61dQH/lip8Hmu94mx0IzrVr0OsEROH5/r0vJA /WfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=ykGbiou+vZDmRk/m4S00f4p5JQbb4tuud6LTVMO+ZJc=; b=Yvgfinn6sgqDgyUHF3bo8EXzvTYWmL6f7xlzwUCr1PJBv6bF0loJLzXgjUr7PbAOjE siRUiyrOtL8z0wu7Hv5Ns/EMln9jOxq9SLeO1UzjYhK1RQfdstUaA3WnRE/DGft0jy+f mSfQXvmCj2vMrZw9MeNhSIjrVd5KKqye0P+JT3TPzVvI9s1r7S1yOUjAInOeU4wFwwD5 SKQmsXVxgCj78sWP6YXYQU3aSr6N3jsn8n5l908vwKxLIqVblczUEwbt6//d7Gmv0D+S u18XULBF/7ZoHyx4nBb/8EK93vnRt31YpgikaY0qvGkReuPVFH28OgvFaEkVC6JEXmLw SHEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2-v6si7944662pgc.495.2018.05.14.13.52.26; Mon, 14 May 2018 13:52:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbeENUv5 (ORCPT + 99 others); Mon, 14 May 2018 16:51:57 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34242 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbeENUv4 (ORCPT ); Mon, 14 May 2018 16:51:56 -0400 Received: by mail-oi0-f42.google.com with SMTP id l1-v6so12002606oii.1 for ; Mon, 14 May 2018 13:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ykGbiou+vZDmRk/m4S00f4p5JQbb4tuud6LTVMO+ZJc=; b=WADsm03Sc4oosQa3aHnYSV621OeApU33K+ylI839vzWQW377Gg8axwFfy1vPV5nAbT SGrYUClAc7oBzr8ksLuCi3rs0xNd7L7RXmERfNo4L0wQmnfel14HITAx39iuamM2SeJq aUCIdBexxV9pzYBoZZIVWBiR0ei7rxpxwzMuW7jEu+B8bRQN2veCya2dBNoMMl9eXCq2 IhStogpO+PuZmIIc4vJ0yR+SGwUj9/SZdyAcPyoxJEhM9JVcSuTkoQ+i7JBS+NFNgHpc 1CijtFykHiWb9C/ezAwf6JriNV1SXH1txfEbIoYo8SyWprs2sYQF00K6ol8wyhVBAlwc mx1w== X-Gm-Message-State: ALKqPwc9q3IoY98h3M/vAwhYp8dixHehV/PMUEYUGOlFerz+I5EqksEw kpOfQNJPffPf++8WRy7WbWU5cE6g1BQ= X-Received: by 2002:aca:bb46:: with SMTP id l67-v6mr7138560oif.19.1526331115523; Mon, 14 May 2018 13:51:55 -0700 (PDT) Received: from ?IPv6:2601:602:9802:a8dc::d2dd? ([2601:602:9802:a8dc::d2dd]) by smtp.gmail.com with ESMTPSA id h11-v6sm6566326ote.72.2018.05.14.13.51.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 13:51:54 -0700 (PDT) Subject: Re: [RFCv2 PATCH 0/3] Salted build ids via linker sections To: Andy Lutomirski , Masahiro Yamada Cc: Mark Wielaard , "H. J. Lu" , Linus Torvalds , X86 ML , LKML , Nick Clifton , Cary Coutant , linux-kbuild@vger.kernel.org References: <20180329180112.11055-1-labbott@redhat.com> <1522413619.15770.88.camel@fedoraproject.org> From: Laura Abbott Message-ID: <42e86b87-b09e-c3e9-8328-7fa418efb627@redhat.com> Date: Mon, 14 May 2018 13:51:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2018 07:49 PM, Andy Lutomirski wrote: > On Sun, May 6, 2018 at 11:59 PM Masahiro Yamada < > yamada.masahiro@socionext.com> wrote: > >> 2018-03-30 21:40 GMT+09:00 Mark Wielaard : >>> On Thu, 2018-03-29 at 11:01 -0700, Laura Abbott wrote: >>>> I'm still mostly looking for feedback whether >>>> this would be acceptable for merging or if we should just persue a >>>> --build-id-salt in binutils. >>> >>> Personally I would go with this approach. It seems simple and it might >>> take years before a new linker option is available everywhere. > > >> Indeed. This series is easier than --build-id-salt. > >> If you do not see any better solution, I can accept this. > > >> BTW, when I read >> https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo >> I thought "we could reverse the symlink direction from debug file to >> build-id file)" >> sensible (but I understand it is not easy to change this way). > > >> If two packages share an identical image, >> one package can borrow the image from the other, >> then the storage space will be saved. > >> So, having identical ID should be advantage, >> but we actually see only disadvantage... > > > > >>> To simplify things I think you could just always add the extra vdso >>> .comment initialized to something like KERNELRELEASE. Which distros >>> seem to update anyway to include their build number, so they wouldn't >>> need to do anything special to "update the build salt". >>> > > That's what I was thinking, too. Would that solve Fedora's problem? > Yes, that seems reasonable.