Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4837193imm; Mon, 14 May 2018 14:06:44 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrU99U8D9cFRijAOWUAV8U7Th8QPUfcQxcHebT/dNzl1JN3QVItY6Mj1SA4di4aQo5xKMcN X-Received: by 2002:a17:902:229:: with SMTP id 38-v6mr11428092plc.384.1526332004686; Mon, 14 May 2018 14:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526332004; cv=none; d=google.com; s=arc-20160816; b=Oa0ENeOLmq6R4EBekwnbgKo97ClXvcPk+YMKrXmuOOVBn3JoX2KhLlqK3ST1mcnYsV UgdHpqGgetGWubslJnAcOvzNSbUllAGp6esLlcCgAj/xtCaUSR4lQncrXJuGSZRwSgTq OglZ6Mm+3zlyjccOkZNAkWW43JJJ9aug9Z1LvyT3PYrmrjIBQXsHDlvC9/b41rz45s1L lB5kplbT01doX0/msol+5fGcbdHv+zC5V1tNuCWpZfQD94ZUzG73f+eLfUv+h3z8B+k3 KQTVx0sW9QMLpB8FN7OFzUjXVTK10zfU1z7f+M8ZrpCN8Ljm+Hu1utKIjrCxaZIIz0Rs 6imw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=VCEEpn8sv1YMBz27ZuE0ZMbe5o2C7FuWXwzeIqwf/IQ=; b=ntcI7tfIfkJE0N7qoozc/arlSxzxaQIyml83xhZvGbJ44Clio7MKZ97l5y9XdmmD86 7yvEXzdlifhHu6u+1m6FAyAqZGoFepmjyHZVv6GB0bVT9bkXB4A3xPqVJVQyhKUl+yQY 1e/j46mGYgNSVPL/vBQv+tJv3WdERBlH4GTlM7xarDGyWMl6K0HhZLY2wzY0ENkEJUwT 9lBoKy76b29wnEvWTZjE+6McMKrLlDPlDpyqlaWfqNw4nohtLnkpgPfpfBysP7bVq7j4 SI4JKHSxuRFWmCxx1WXUyr3HAdNEN4tPb6hsq2cGFtEtxkjo+GKqMpvwRmyAExLilvWO PIEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ChQvefbr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5-v6si10653923pfi.88.2018.05.14.14.06.30; Mon, 14 May 2018 14:06:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ChQvefbr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbeENVFp (ORCPT + 99 others); Mon, 14 May 2018 17:05:45 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36671 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbeENVFm (ORCPT ); Mon, 14 May 2018 17:05:42 -0400 Received: by mail-wr0-f193.google.com with SMTP id p4-v6so13786063wrh.3 for ; Mon, 14 May 2018 14:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VCEEpn8sv1YMBz27ZuE0ZMbe5o2C7FuWXwzeIqwf/IQ=; b=ChQvefbr4CUzbTDQd2wRmFxaVtPF6WDfuHUo1MpRDE9MeXrwy8zDEuDl4RZrFAQiIo R+pqobwaUFt/LmaSrxHGmGShl3FJDxo8zKmtpleLGLUMwEsJZ5qb4gZxTQDIhYrlBGgu HjYxNOg/DG5se7nnusQxdnh9f0e9lpAsFCZge7uYcSKqxZt9wRu4hP2RPPUkhEtjjIDJ zx1GRoDqD+Z05j6n6sxCd3dGAdmSDxjsBKmvhxp8egXKH3dU2BRZqntfWzKyI+xG6wXG jFiH6hY7dnTdbl4FTUuYsIHC0yeW/r4Wh4sVmZkhCuxqlaxls78A4TThxtbCsYgbHxoh 0ZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VCEEpn8sv1YMBz27ZuE0ZMbe5o2C7FuWXwzeIqwf/IQ=; b=ix1kAVJuEHZPdd9JBtVcrGpYDzPKpASXx1GjUGGm41YBXlC8ZfJEGGNTkeHaBoGBj0 dMlw7EOD7YDQQuiiDETKlw30DRsri2u+1ocWTE97OIpXJk7zMyJ+n4UHHv+vezvhWnPO mWwI+LUAIF7Isrex33qzxUyfO+YkWIRPMkixAYHB6iDZQTeToIAe1n+ogJ/9r6jFY2Y1 1kJirrZ/055p0nJtq2N0yMaXhqJWyfP2H8Y1hxlf4FNJCwoYPMkcip0LFf4Z9xQffNnR LRg0K+c296QEyUSyPaiPSXlcpwi2IA+MURyQzGf77aXvzAX+jmW6jeGlkVaBycDeRtKN jCYw== X-Gm-Message-State: ALKqPwepk8HO3KxvASfAyZobn3a5mRMHmRjrOzup6periYFXaQYmq+Ht /rJjvT3WS4ljx8/fgmlPpZGARro+zyzfJoj45lc= X-Received: by 2002:adf:9d8c:: with SMTP id p12-v6mr8011520wre.14.1526331941506; Mon, 14 May 2018 14:05:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.130.49 with HTTP; Mon, 14 May 2018 14:05:40 -0700 (PDT) In-Reply-To: <20180514110342.23683-1-jorge.sanjuan@codethink.co.uk> References: <20180511152537.32267-5-jorge.sanjuan@codethink.co.uk> <20180514110342.23683-1-jorge.sanjuan@codethink.co.uk> From: Ruslan Bilovol Date: Tue, 15 May 2018 00:05:40 +0300 Message-ID: Subject: Re: [RESEND PATCH v4 4/4] ALSA: usb-audio: UAC3: Parse Input Terminal number of channels. To: Jorge Sanjuan Cc: Takashi Iwai , alsa-devel@alsa-project.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 2:03 PM, Jorge Sanjuan wrote: > Obtain the number of channels for the Input Terminal from the > Logical Cluster Descriptor. This achieves a useful minimal parsing > of this unit so it can be used in other units in the topology. Usually 'patch resend' means resend without any changes, and if there are updates in the patch - it's a new version. By the way, as I already said in comments to patch 1/4 [1], I verified this patch successfully. Reviewed-by: Ruslan Bilovol Tested-by: Ruslan Bilovol [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-May/136044.html > > Signed-off-by: Jorge Sanjuan > --- > sound/usb/mixer.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > index 431f3c319839..99804cd4aed6 100644 > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -904,8 +904,12 @@ static int check_input_term(struct mixer_build *state, int id, > term->id = id; > term->type = le16_to_cpu(d->wTerminalType); > > - /* REVISIT: UAC3 IT doesn't have channels/cfg */ > - term->channels = 0; > + err = get_cluster_channels_v3(state, le16_to_cpu(d->wClusterDescrID)); > + if (err < 0) > + return err; > + term->channels = err; > + > + /* REVISIT: UAC3 IT doesn't have channels cfg */ > term->chconfig = 0; > > term->name = le16_to_cpu(d->wTerminalDescrStr); > -- > 2.11.0 >