Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp5095656imm; Mon, 14 May 2018 19:34:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrfc7uM/8zPM+JAkq2scc7k3gElMbaAssektZelMyA31VeiJzg6FnZj+Oj/erU36lBqu36A X-Received: by 2002:a65:5c47:: with SMTP id v7-v6mr10459150pgr.425.1526351645629; Mon, 14 May 2018 19:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526351645; cv=none; d=google.com; s=arc-20160816; b=Tz+b+HAUP+B4WR9kVbnoc05fV4x61Cy36qg2ky9qxstI5GxpnVeGdDhE+UYcZ5sd9R Ub08sHZk9Samwlus5AMhjwlKVvqimtwCGVOHQwEgqEnWyH/rz05mKWecVHZBS91VReyp QY3ibdcCDjscL3fVBNF3G4YxxFSAJoCFkMbKuimerK4Nn/aFqZXbH524i/UHWqOGpS8H AYob1ea4z3uMtwR2FU83HM8UVBre49zzhYlb58TqJmIZpEQO0/fexHciicAZJKkz20v7 zn51kjQHWIWutrrAimRS5sMlcP6akdU/V4Hih1XhDJB16gep+NINGQdeaTBkTvBTG+5K w/Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=R9WqpVuDQkctVKDBroDPcC52dxXYYxya7CweeiIXRlI=; b=ee+QT1g7SNHzTIiv2m0UmEybEOkNk4xALCTHREGfQqy0mohH/8kPG8Sfqly+Bb2lT1 bmCOSr6PTCxzc0F9L9Y69C9qlr4k+QsneYDGHHj1rs6Ylv9c/wsN0qaapArOqQmadEme r0/qBww23PMZ85Osh9RWRgbNbkGPGd1L9We0m2dnd7TbytFxxukIPKq+aJsL26Wei9In 5Xb4g3qtSYk82MkGkxbB3z8+WXpniZFabpsoE0VjTTeP3z0V3WlOM9dLMmFhL2/2Q4e/ yKIC45/YFFVbB6yf08y+e/YrF5YSCWLYeY1TqvskZV7VjegeqV999cWBvJjOTQAU1x7S rRKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=RRAxsLJ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h185-v6si10754580pfc.348.2018.05.14.19.33.50; Mon, 14 May 2018 19:34:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=RRAxsLJ8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbeEOCdi (ORCPT + 99 others); Mon, 14 May 2018 22:33:38 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:42804 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbeEOCdg (ORCPT ); Mon, 14 May 2018 22:33:36 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4F2Vjuo105334; Tue, 15 May 2018 02:33:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=R9WqpVuDQkctVKDBroDPcC52dxXYYxya7CweeiIXRlI=; b=RRAxsLJ8viX6XBJpc8dyVOJwyMBtPMEioR2JgLLrN9bP6EghYBAX6cU+oLi2XW2zE4ky sKhFiJO1DGgeE+gwGyEq2cf6J1TVlyR3OPuYCe8Oj+US4Z42BWPgYPKqD+rR6dzzMPni q3+kXgim4kxGvIjrDzbTuadmn6FzNhmQb37hfeNWT45GscnlbnaZB40BeT+uDiEjEEj+ 4JE3jP9wZkhYHD26GZp1ve6UxmqkNX1aDnzQf7BODJLwr1dIPV9cg0ohleuSczIv0Y7X rUo7UPfivHoa076vbgiWQq+vMf6ZsPR82vn1iqCPbzQQbj16V3VHiAJqhppWfCe5njSO dw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2hx29w6cx4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 May 2018 02:33:32 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4F2XVXq002608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 May 2018 02:33:31 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4F2XTdX002149; Tue, 15 May 2018 02:33:30 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 14 May 2018 19:33:29 -0700 To: Kees Cook Cc: "Martin K. Petersen" , Boaz Harrosh , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libosd: Remove VLA usage From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180502225545.GA45533@beast> Date: Mon, 14 May 2018 22:33:27 -0400 In-Reply-To: <20180502225545.GA45533@beast> (Kees Cook's message of "Wed, 2 May 2018 15:55:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8893 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=581 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805150023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, > On the quest to remove all VLAs from the kernel[1] this rearranges the > code to avoid a VLA warning under -Wvla (gcc doesn't recognize "const" > variables as not triggering VLA creation). Additionally cleans up variable > naming to avoid 80 character column limit. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering