Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp218589imm; Tue, 15 May 2018 00:13:18 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo4ZwEUs1ey4nCkCx/Si3JNWUMB6NYAeuNP4y87hdsR8dbBH2srwzI0jvacyXLfYWVryc/i X-Received: by 2002:aa7:80c6:: with SMTP id a6-v6mr13806622pfn.120.1526368398329; Tue, 15 May 2018 00:13:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526368398; cv=none; d=google.com; s=arc-20160816; b=t9/5zlJTu4ivrNSJhKYV1YoTaa2Yp/4XoJwVp9TSPSdhQHJKNJCpp1nGNeJpv6UhRM 59busXTupk0U/RbvM88cE2mfDS02fpmVzfdg8Uyi4CiOioHIf7uGOlVNyaCdDlqkSq4w FytlKzscybgW0Q2YK29HW5xoYgRFtFMbq7+ks2p0v12onTzy3bVDIrmnf/A8qeFtnb/7 12MJNQzrjP6hehyZ7E9uvpU1Zp/UKz4neyz440wc2ERNNVDHinLDXF4pAgY0TzePRhpY kc8xbhV5qpMta3I3Ara7MjiOt5P+DcEXBpWkdqZVQtRRmU8jrpALCVd2YL2i/APpTZkl gGVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=yjvMPw5zZzDgjlapyPjIswgb0ldKaOksDtmgl5NWOQU=; b=dHmmtDXXtjPxlBSTbwuyc2/AYbrEIfbuj5tZNNByS/mv1WQzECNM7/K/kCpN6fcY33 5UQ7oyA+klxfadhRSdO47u1Sr5h55FlpbKj91kQ7a4ihPl3Tx70jKOr+RjjnF2fFUvrh ERiwWtnJlJGg6gWup17+Rgg1uukKqfQxpFk2G8E3RBb6+d/fYpM8ajZrjB3ogIhmNTT5 V3YOGHhR5M8Jsk027MaMoMWW8/0+Oj+w931FgLPMnMNYgvSz9g+T1V2tK9TqksY9oDg/ 3/0B9VpEJrYuLcGp4sWlv3qncnmuDORn4MwTmHNbIm+q+64FCCphwnoCB8pHK5QBXGIk 8EiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YcTUPDPb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e124-v6si11115682pfe.80.2018.05.15.00.13.04; Tue, 15 May 2018 00:13:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YcTUPDPb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbeEOHMs (ORCPT + 99 others); Tue, 15 May 2018 03:12:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:52824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbeEOHMr (ORCPT ); Tue, 15 May 2018 03:12:47 -0400 Received: from dragon (unknown [45.56.152.100]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC6DC21746; Tue, 15 May 2018 07:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526368366; bh=5UhvTNLVErfDzlbo/YPgx/Qzyng9jy2KBQD7sA4zmvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YcTUPDPbHVo3zrTLSkY8sfPn3jRFYFLe8jLTwWJfUKUwdXB9KR8fH40qGXWux6fZa sCDbACIU3+/A/2OLf0j/8lgzN1pBeF6LrCGcGKFENNLreSDp4VgkoiVOdSfWy/3Kli fT8/TatFCbAooDY55+9o2cxSlk20TRIm3dwtog3g= Date: Tue, 15 May 2018 15:12:01 +0800 From: Shawn Guo To: =?iso-8859-1?Q?Hern=E1n?= Gonzalez Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx6qdl-phytec-pfla02: Use IRQ_TYPE specifier Message-ID: <20180515071200.GO26863@dragon> References: <1526254115-3999-1-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1526254115-3999-1-git-send-email-hernan@vanguardiasur.com.ar> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 13, 2018 at 08:28:35PM -0300, Hern?n Gonzalez wrote: > Replace magic number with the proper IRQ_TYPE specifier to improve DT > readability. > > Signed-off-by: Hern?n Gonzalez > --- > arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > index c58f344..1b79ee7 100644 > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi > @@ -115,7 +115,7 @@ > compatible = "dlg,da9063"; > reg = <0x58>; > interrupt-parent = <&gpio2>; > - interrupts = <9 0x8>; /* active-low GPIO2_9 */ > + interrupts = <9 IRQ_TYPE_LOW_LEVEL>; /* active-low GPIO2_9 */ It should be IRQ_TYPE_LEVEL_LOW. I fixed it up and applied the patch. Shawn > > regulators { > vddcore_reg: bcore1 { > -- > 2.7.4 >