Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp280441imm; Tue, 15 May 2018 01:22:41 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqbMfF/FoWFAR9xB+qpNazO0DsiH9J/g88kn9ELZk7LJcXrCk5D+26gEwmOc7l2Bb1XUlZ6 X-Received: by 2002:a17:902:3281:: with SMTP id z1-v6mr13300781plb.226.1526372561469; Tue, 15 May 2018 01:22:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526372561; cv=none; d=google.com; s=arc-20160816; b=wfVZ4j5lgggp2E76D3MFchw8zvpQGimUbT1QxsqailPTI+igDshq9F1qejn6lEjCXy hPK1swTKCWfDEyQetludOmewPbZ7hVDyyW8G9vDpUz3C4r55T0M5K+rkGWM0JI5DMK5X p2TTHYswu+CWW2f8uWXIF5lXIHe8as2GU1w2M0X0lRYsyimlVFGvM9wrIjGMmGDJDSwj XR//hSt6q4n+WT22sY3HPZ8EQmyLpPyze7t/Etm5zRx0HemZ6K5x3yQgUcTF8kjQmJgY BQXkpL2ZV/R0EP4cslRAyxl2J+W0KALndMAHMP64XFu0VkurcferrDJWsfjVVWPwdK7Q hbOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=h/K/0Ebzs3Z9lfUlQe5Hf4ynFq5GrCdNyjl/HVdD5wI=; b=o4aJpsWsi4QQEzzc8L+0eFORTmWV/hDWBVXXWPRaWIyZeaTk1EunptGcwmjrdCzSAi zG5t6WjRmIQls17ZGua4VOrOx6aVSH7Yx2zxHGIWIpwVdEvqF4s3/HcqzFymYhAkAsLF IAUOM5GqQgCPudRGR9Itx9Li37A1koZ/vM9EtkiUBM3RRFdGxelHIyas9rSs6P12hzga LNbGLvQrDQqIol92/9LZw5Hzo9zIqav6BIK0uCU2gqwuaF9h59AmIAh4VRD/T6Wo2xP7 +uS4YeNt/Gq3Vwn3DxsLemYesNd0ysg9TiWMKRhQwE3iUbFuQLaAYA8caRN9FyMRELlM +xhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=bYTe6l2r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n25-v6si9441006pgc.42.2018.05.15.01.22.27; Tue, 15 May 2018 01:22:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=bYTe6l2r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbeEOIUt (ORCPT + 99 others); Tue, 15 May 2018 04:20:49 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:55253 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbeEOIUq (ORCPT ); Tue, 15 May 2018 04:20:46 -0400 Received: by mail-wm0-f67.google.com with SMTP id f6-v6so17779491wmc.4 for ; Tue, 15 May 2018 01:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h/K/0Ebzs3Z9lfUlQe5Hf4ynFq5GrCdNyjl/HVdD5wI=; b=bYTe6l2r46N+qAa9Q3JfGws5EidXf0Ab0gWORBWZqYce/4MFRjPHIitpNFtxxgwf11 eLfOzrFr/5Vv36dAAVzmzyhctX8Z9DCr21/U5RHb+Bmljh5RiHgmrZr59FhXXE+E9I4p sbE4Z6ukg5JT8XPtbZpjdu4S1W2PV0DMDlov/RR5Wgcuw/YmwG5RyVNxcMRuflsSFk1d l2Q+GKk6XOewv4ixwHrctr+8Bd+dNvtctGWkbNmZmw2pavjePiOCDJp2PQnHSq7THnIy Rfk6nKqrfYHRHnMyd2T8mvPQUFR2/F+8OKsA9Yg1GIB8SLFMI+qUNdGzZgd1Fs2ZgePY 5zkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h/K/0Ebzs3Z9lfUlQe5Hf4ynFq5GrCdNyjl/HVdD5wI=; b=igbjaO5sePMznCrAwfwn0g+PxMLepRcffqj6Rn44XtNfxzWrX82Cuxc4TmBX6SVeE1 Hztjk7CEeMxESKPMMSZzSm8zOW+SUWZ2FtQsN8gMBhgfoWjwjvImE2Mj+MJZY4hS/2uj DEYjd5SotgSpxjdEaA//Ekbonru0APq7XnpO354xdG09zi0x4Cc1qHL4tv8MebpwmcTo 5QlE6rosw3kiC+z/vCgYKkBL1JE0ZALdA+MHI8o31/oKFBh/odbAicxyYpQyn76ZKQVJ sfkDZl6JSw/abKzt4KIvhT+xO/dcmBhRmcfFJRLbHBO3BK7S9CH7wXi3yGlXZJadyR2q lbww== X-Gm-Message-State: ALKqPwdNJ9428krZZGaV8OakU0y68rlUWZI5hsZUaQDyIUVLkGkGFi2E oN7Ff7emMdYfKNUI/MPoLYZRVQ== X-Received: by 2002:a1c:eace:: with SMTP id g75-v6mr6847061wmi.76.1526372445399; Tue, 15 May 2018 01:20:45 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id 75-v6sm16925894wmw.37.2018.05.15.01.20.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 01:20:44 -0700 (PDT) Date: Tue, 15 May 2018 10:20:43 +0200 From: Jiri Pirko To: Jamal Hadi Salim Cc: Vlad Buslov , netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 00/14] Modify action API for implementing lockless actions Message-ID: <20180515082043.GH2134@nanopsycho.orion> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <23f37e5a-dd30-0ad3-a5ab-df22bf0ad7f9@mojatatu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23f37e5a-dd30-0ad3-a5ab-df22bf0ad7f9@mojatatu.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 14, 2018 at 08:03:20PM CEST, jhs@mojatatu.com wrote: >On 14/05/18 10:27 AM, Vlad Buslov wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any >> possibility for parallelism. This patch set is a first step to remove >> rtnl lock dependency from TC rules update path. It updates act API to >> use atomic operations, rcu and spinlocks for fine-grained locking. It >> also extend API with functions that are needed to update existing >> actions for parallel execution. >> >> Outline of changes: >> - Change tc action to use atomic reference and bind counters, rcu >> mechanism for cookie update. >> - Extend action ops API with 'delete' function and 'unlocked' flag. >> - Change action API to work with actions in lockless manner based on >> primitives implemented in previous patches. >> - Extend action API with new functions necessary to implement unlocked >> actions. > >Please run all the tdc tests with these changes. This area has almost >good test coverage at this point. If you need help just ping me. Oh, that reminds me. Vlad, please run also: tools/testing/selftests/net/forwarding/tc_* Thanks!