Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp329911imm; Tue, 15 May 2018 02:17:04 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqQKUUB4bMHI16sjY3qv3l4Npv6e5uHgaFNApWlCSVTMt5uXXW+nbwMjkVMvyumiKHLIco4 X-Received: by 2002:a63:7311:: with SMTP id o17-v6mr11650594pgc.238.1526375824699; Tue, 15 May 2018 02:17:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526375824; cv=none; d=google.com; s=arc-20160816; b=Mk++Gw+rtAA9tpNzBQ3Yy9miyHPzoz0M5vU4Z/5Drzjrkw1OXqelSREjizU1nWLcsL pJj0d+6BzQ06tUQObATXXJ8qjQXp6uUxHt+ncSUIEnwwXCIM0fXVeQqunAaXUu+XP0yA rtsBsJC83AmOf0BWjfPp/r4y75VaES4gk5sLddvloZ0KljzEen0nvdi2dvGbsUzsncu4 PzONiDWXsKVXmVJWBsnS26NYumaYKaZsRqvbLyvw9NHf/KoC4vlWx4GuyeQNGBMaFvcb NpJ2EbBZl1OzSfXm/yxVG4Ou9bFTSabqccpAbVFst1mTali7sTDux0voNdnxUaaXNRLG obBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=4vg+TDkxutdpWiYap1dlF6WbrKzcU3vUYrFjSLwONlU=; b=c+3QL0Qfy0wcTyHjsLbdlHBqmwGkMScTURVn3M3vfGRauurVhUZ3+JZ4cMPdMWKsfb 2zaE7xL1xuhlHTozf/ML7uXH5Tx1MQX3NmskKYq38PVJcIZCnZNZzj4eJlmsvkjLH0rD 40uM5hrqNZktd/RCmQvPxFH/5j0V2rUasu2zt7Rl0AWszZl3rMfkQhoZ0pxptHHp7RV2 5DBkC7OP4B78RiVxwZjlstcCYTdqmQI9hdpI6gh1gAnnBj83HkY8MdBSwGJnTomQ31v8 OsxEFXQRXSGoEv2YO3jC0atpROE3C78JOC/3gqwKKWSD+UIxYK1T5gN7JjLpy5/CLywC GanQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s88-v6si11552859pfe.290.2018.05.15.02.16.49; Tue, 15 May 2018 02:17:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbeEOJQI (ORCPT + 99 others); Tue, 15 May 2018 05:16:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:53699 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbeEOJQF (ORCPT ); Tue, 15 May 2018 05:16:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F3A90AF16; Tue, 15 May 2018 09:16:03 +0000 (UTC) Date: Tue, 15 May 2018 11:16:03 +0200 (CEST) From: Jiri Kosina To: Dmitry Torokhov cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Douglas Anderson Subject: Re: [PATCH] HID: i2c-hid: check if device is there before really probing In-Reply-To: <20180509191215.77406-1-dmitry.torokhov@gmail.com> Message-ID: References: <20180509191215.77406-1-dmitry.torokhov@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 May 2018, Dmitry Torokhov wrote: > From: Dmitry Torokhov > > On many Chromebooks touch devices are multi-sourced; the components are > electrically compatible and one can be freely swapped for another without > changing the OS image or firmware. > > To avoid bunch of scary messages when device is not actually present in the > system let's try testing basic communication with it and if there is no > response terminate probe early with -ENXIO. > > Signed-off-by: Dmitry Torokhov Applied, thanks. -- Jiri Kosina SUSE Labs