Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1526378007.2724.2.camel@suse.com>
Subject: Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error
 case
From:   Oliver Neukum <oneukum@suse.com>
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc:     Tuba Yavuz <tuba@ece.ufl.edu>,
        GregKroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
Date:   Tue, 15 May 2018 11:53:27 +0200
In-Reply-To: <1526319669.9159.20.camel@codethink.co.uk>
References: <20180406084305.210085169@linuxfoundation.org>
         <20180406084309.317246829@linuxfoundation.org>
         <1526319669.9159.20.camel@codethink.co.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Montag, den 14.05.2018, 18:41 +0100 schrieb Ben Hutchings:
> 
> Shouldn't this bump the V4L2 device's reference count, i.e.:
> 
> 	v4l2_device_get(&usbtv->v4l2_dev);
> 

<censored>

You are right. Mixing refcounting sucks. I am preparing a patch.

	Regards
		Oliver