Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp624084imm; Tue, 15 May 2018 06:51:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZocU4of3ooIZuqz82JPLfqaegiUDLJ6X4Fl0vEDZ9nmfU8YBOeIvarLBddW6Q6l1AZbTOcE X-Received: by 2002:a17:902:ea:: with SMTP id a97-v6mr14300701pla.28.1526392274951; Tue, 15 May 2018 06:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526392274; cv=none; d=google.com; s=arc-20160816; b=MEHfVlnkMFOBcRmhygbowUOW0wDfZo+/9hWcg41Wfpf/IsbTdQrw692I+JAQOYwtFt hiD91bCj7pDsWOOwsdt+U4GxhEGyQkU6N8FJkWnMQjHXocI3Ja8+/QHv+ExsEDtjl7RN fgsJmeXD8KVWJOGoAEMsHFTEYrwq/4X7LfxNiLsV+CD6pDJqDYC5ZOH+Vvrr/wcePMz5 JLhsFxuBUNS7xJBNcyTMxKx2hl856a7Hcyt31HRvsBqKe4njj9iZdH9z7cEjIrMrno57 PHHeOBots7Mn12RwWtTQkQWXZIatjsNRN1agSV6ssCGwXuL6zc3R5pvBS1YNW9YBcCRV Ifmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=yQAHGJJT0btZwGViMA+ff5A+c79KI+4db1gZMW+u4Ig=; b=0hm5XWYkolsOhVdw4AVzt0szfGk8IHILKcoSWRP6O37aQiSz9MfLmClgKME4CdJyYh 9kionNjYoAenhJkYlV6ck0l3FMKtUQ9YrHEnrzDdOKdgVhqANLvhtZgAfq+WH6k2YeJS x2d1odwApYYNNLDvy6EoL90bWfGOtrYqh2S95+tUzg9jowIE9GOUiVo2cvfaOtlSFWmP bDCCEzT+7xTre2/8fnZwkw3W/u12IBvgWqpKfGtQ8xLiQOqny6G5I2xkrAlI0OvDMn6h EZzqzFtt+p9ZZnDm+mWXTA4jhnFWlAkuibRIpkY7l3MNJZuGkajmcwNs7JYfsxwc9u1F q/MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3-v6si71673plb.478.2018.05.15.06.50.47; Tue, 15 May 2018 06:51:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbeEONPY (ORCPT + 99 others); Tue, 15 May 2018 09:15:24 -0400 Received: from foss.arm.com ([217.140.101.70]:60390 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbeEONPW (ORCPT ); Tue, 15 May 2018 09:15:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C60380D; Tue, 15 May 2018 06:15:22 -0700 (PDT) Received: from dupont (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7DCC3F23C; Tue, 15 May 2018 06:15:20 -0700 (PDT) Date: Tue, 15 May 2018 08:15:19 -0500 From: Kim Phillips To: Ulf Hansson Cc: Mathieu Poirier , Alexander Shishkin , Alex Williamson , Andrew Morton , David Howells , Eric Auger , Eric Biederman , Gargi Sharma , Geert Uytterhoeven , Greg Kroah-Hartman , Kefeng Wang , Kirill Tkhai , Mike Rapoport , Oleg Nesterov , Pavel Tatashin , Rik van Riel , Robin Murphy , Russell King , Thierry Reding , Todd Kjos , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH 1/4] amba: Export amba_bustype Message-Id: <20180515081519.22751a39c49e63224da3acac@arm.com> In-Reply-To: References: <20180508140628.f30774c70c4c481bff3f8000@arm.com> Organization: Arm X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 May 2018 08:59:02 +0200 Ulf Hansson wrote: > On 8 May 2018 at 21:06, Kim Phillips wrote: > > This patch is provided in the context of allowing the Coresight driver > > subsystem to be loaded as modules. Coresight uses amba_bus in its call > > to bus_find_device() in of_coresight_get_endpoint_device() when > > searching for a configurable endpoint device. This patch allows > > Coresight to reference amba_bustype when built as a module. > > Sounds like you are fixing a bug, don't your want this to go for > stable and then also add a fixes tag? How do you consider this a bug fix? What commit would the fixes tag reference? The introduction of the amba bus? Not only aren't busses required to export their bus_type, but that commit predates git. Kim