Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp636669imm; Tue, 15 May 2018 07:01:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoNIVi+nEabapOZVc0RFo06uP/HcM1vkgdXVgzU9nQr0wqX7KuBAllHpgj2/XMk8+WMLPbP X-Received: by 2002:a62:b909:: with SMTP id z9-v6mr15327652pfe.254.1526392919215; Tue, 15 May 2018 07:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526392919; cv=none; d=google.com; s=arc-20160816; b=IFii5Bfx6c8bQbRp96i23Gk4HLB3ECuZDkbe4tb7sIDEUuPQcX1seaTatriEkgBXj5 gdZC4hIv78Es1Ukc8HaxNYpezNWlJbKuqPRsF/p3+GFQ+WScUO+CavYDbJcux9IWEEYq neIfew0c+c0KgG/pHdTVaCxzLLvTDBa57FcP6Dp0NL/pQA75GQ5x/OrPsH5hxcxWz9fj gdV3Qn7A8drewKnAUaaltgfFYct04lAvhYldwkCxbIyX0Gzrl3kTKSmyMCGFVDkjmtDk 3UVL72LxAVz5cvzjeWFvYXrK+Dst2DlCm9ZoRELvhK799JOwJ7MftaiHZ9Nlh3c+EO5n +ysQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=bBbWtU47FmjCnzeSu/08qw589vIflVTI0p46XU1xAd4=; b=tCLtIzqdgmFP5Ph16O7oL7PYWgeiNbRogTyiVh3r/5kG5c9wsoJEawnNzkdnUeJASD 7Z5QfxrlKxSeFbOoendbQzNEXe+qbHO5RpySvzdxIho6jqXC3mKbIs4t/K0viPGqw+Kr PfinrN5GUXifl0MyepO2xyo0RYjaKNuv6JTYgz/4R/eg4Bt5LnpIkkqr/PMmOomeKQt5 ub0YpE5+3GN5YUfJX10kQ4UTiQuvn4MRRt5XVfjAacIupOOXUsUFeX3poZy86xu5deBe PyguIbdI/J3CmbNdlegzOv4vJYo7iyhtUystvyQc8cD1FZm3sqzibHDVJ2vqxKeS02en H0tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=P16hxjuC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4-v6si69614pgq.603.2018.05.15.07.01.00; Tue, 15 May 2018 07:01:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=P16hxjuC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbeEONqG (ORCPT + 99 others); Tue, 15 May 2018 09:46:06 -0400 Received: from 8bytes.org ([81.169.241.247]:46554 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbeEONqF (ORCPT ); Tue, 15 May 2018 09:46:05 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 7EC89446; Tue, 15 May 2018 15:46:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1526391963; bh=KRv6odRqLFZK/xIrdbB21m4Yn4prB4Z4K1EPHs1QOks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P16hxjuCY84YkqDKc1yGbgiNOSwgnwwYz4G5iT0BDMwH/9wGoernzvNv0KrEEf9KU SsRkpnuZT5g90v1tRm89vgbw3dEtzGGOMXv4ho63kXhBi0BUWd5Kwr0PanfKT4qfyU DH0mauG1gl+Os4Ct9IedMTrWdyerSlNSHlHFxRiOLxLrHYrYRe3FIn5+QHTi3BrLz5 1kj3nPPCQLef06cOIvSZxNYkXs4jkH/QVrong2P+fpfEdaGBip7aJJE0bhPmXSgD/B gedM5hUpE526m34Zfeaw35qV8Sen2RGndRSSHDspmmiAGCHINE8d+iklbQn+k0owsY 4LPyiIhpbGHug== Date: Tue, 15 May 2018 15:46:03 +0200 From: Joerg Roedel To: Gary R Hook Cc: Randy Dunlap , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Message-ID: <20180515134603.GD18595@8bytes.org> References: <152631818082.18929.13970142119193316487.stgit@sosxen2.amd.com> <152631842907.18929.8819955271544326298.stgit@sosxen2.amd.com> <5e45f38e-cb45-d4a1-f351-30543f787290@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e45f38e-cb45-d4a1-f351-30543f787290@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote: > This was brought up a few weeks ago in, I believe, version 3 of this patch. > That question was discussed (because that's what I did the first time out), > and _someone_ _else_ asked about why I didn't just do it the way I've done > it here. You don't have this problem if you put the code in amd_iommu.c in an IOMMU_DEBUGFS ifdef. Joerg