Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp776718imm; Tue, 15 May 2018 09:02:18 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoBzvHuNt//xB1ANBG2MGLDBvkgOB9ZffV2OdWfAwMdr6J3Zjf8knEuEHFPFmGLgdsRFP7d X-Received: by 2002:a17:902:6b47:: with SMTP id g7-v6mr15083770plt.251.1526400138177; Tue, 15 May 2018 09:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526400138; cv=none; d=google.com; s=arc-20160816; b=R9QZt1g0DMPW6Bz7DlbyJ2sCZpQxxGr1GOxGiUV/uX4LOcP+axU2azR2K/tHo1PedS /mmpDBiOKx2X4yYb7rMeCjSCaqQbcqewv7XgJprI/sFgekH4nEi3MMak5Mn/vps/WeJj k6SRj0dTt9vphojUqBcs2PVpc0J7SXh8ZB6Bdrv7IemIWOAHxcvO8MefawttNGYQw38T jVP7UBnfeQ1R4jQpuHGFyThZRdjq78Dyvx0STg9y2EtBpX+BG1jXwSZV3zpUrrcg3IU+ NO5Izfyx2rzFtNqEb132wWxcvVV3nnjYdo+LiupBiwllaxW4DZC6mRGIqeZ33Fc1C2IZ nuNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=hUrBYC4naDd/OdF2G0AowDC6h9AJBvK7VwW5pnuHfUI=; b=sbWlAaF19mankJvFS2wiMSW0GKujOHFE5v5yS5QmXXtNPYlPMjYd6OvJcXtf+XIhoA 6lWHKuSl8Zw31l3xxq4jxwDZa7zsiSLAXYmj+gHpFv1duiJOichoU7uan90dy6cmRpAo HUaExRKXheGdzDmhmcx5NCIMiwH33Zy97yjepMgt1JQ+rL1qXQ8G2WJCWK2p1kaJyKFL e9YMMjIjnwSBuZ0PTTjAO/Pn/b1iaXJYQvFD+2pNCebAaHJ4K2Dvf9ZozTx2xh6ufM3b PE39iQFVLQ7VQUVypXdBUGirv7HDlax8ekIqUiD8081Ky71pmUvoOFEphuPMVZGXb9sI 2ZIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6-v6si277134pgr.369.2018.05.15.09.01.21; Tue, 15 May 2018 09:02:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbeEOP66 (ORCPT + 99 others); Tue, 15 May 2018 11:58:58 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49534 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750810AbeEOP65 (ORCPT ); Tue, 15 May 2018 11:58:57 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4FFsmYE120292 for ; Tue, 15 May 2018 11:58:57 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j00860m2q-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 May 2018 11:58:56 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 May 2018 16:48:43 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 15 May 2018 16:48:40 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4FFmdpT43057176; Tue, 15 May 2018 15:48:39 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A46EAE055; Tue, 15 May 2018 16:38:00 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BDB6AE051; Tue, 15 May 2018 16:37:59 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.152.224.46]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 15 May 2018 16:37:59 +0100 (BST) Subject: Re: [PATCH v5 05/13] s390: vfio-ap: register matrix device with VFIO mdev framework To: Tony Krowiak , pmorel@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1525705912-12815-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1525705912-12815-6-git-send-email-akrowiak@linux.vnet.ibm.com> <5471b194-d7ca-c9c6-132e-fa9539fe44f0@linux.ibm.com> <4688078d-3e13-5201-582f-52576b25defa@linux.vnet.ibm.com> <1f9117bd-ed14-bde4-fdbd-cb3733c8c633@linux.ibm.com> From: Halil Pasic Date: Tue, 15 May 2018 17:48:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18051515-0008-0000-0000-000004F6BDBE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051515-0009-0000-0000-00001E8B2503 Message-Id: <1fb8d1ab-02d5-c170-08e8-a77526fbb7c4@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-15_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805150161 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2018 05:16 PM, Tony Krowiak wrote: > On 05/15/2018 10:17 AM, Pierre Morel wrote: >> On 14/05/2018 21:42, Tony Krowiak wrote: >>> On 05/11/2018 01:18 PM, Halil Pasic wrote: >>>> >>>> >>>> On 05/07/2018 05:11 PM, Tony Krowiak wrote: >>>>> Registers the matrix device created by the VFIO AP device >>>>> driver with the VFIO mediated device framework. >>>>> Registering the matrix device will create the sysfs >>>>> structures needed to create mediated matrix devices >>>>> each of which will be used to configure the AP matrix >>>>> for a guest and connect it to the VFIO AP device driver. >>>>> >>>> [..] >>>>> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c >>>>> new file mode 100644 >>>>> index 0000000..d7d36fb >>>>> --- /dev/null >>>>> +++ b/drivers/s390/crypto/vfio_ap_ops.c >>>>> @@ -0,0 +1,106 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0+ >>>>> +/* >>>>> + * Adjunct processor matrix VFIO device driver callbacks. >>>>> + * >>>>> + * Copyright IBM Corp. 2017 >>>>> + * Author(s): Tony Krowiak >>>>> + * >>>>> + */ >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include "vfio_ap_private.h" >>>>> + >>>>> +#define VFOP_AP_MDEV_TYPE_HWVIRT "passthrough" >>>>> +#define VFIO_AP_MDEV_NAME_HWVIRT "VFIO AP Passthrough Device" >>>>> + >>>>> +static int vfio_ap_mdev_create(struct kobject *kobj, struct mdev_device *mdev) >>>>> +{ >>>>> +    struct ap_matrix *ap_matrix = to_ap_matrix(mdev_parent_dev(mdev)); >>>>> + >>>>> +    ap_matrix->available_instances--; >>>>> + >>>>> +    return 0; >>>>> +} >>>>> + >>>>> +static int vfio_ap_mdev_remove(struct mdev_device *mdev) >>>>> +{ >>>>> +    struct ap_matrix *ap_matrix = to_ap_matrix(mdev_parent_dev(mdev)); >>>>> + >>>>> +    ap_matrix->available_instances++; >>>>> + >>>>> +    return 0; >>>>> +} >>>>> + >>>> >>>> The above functions seem to be called with the lock of this auto-generated >>>> mdev parent device held. That's why we don't have to care about synchronization >>>> ourselves, right? >>> >>> I would assume as much. The comments for the 'struct mdev_parent_ops' in >>> include/linux/mdev.h do not mention anything about synchronization, nor did I >>> see any locking or synchronization in the vfio_ccw implementation after which >>> I modeled my code, so frankly it is something I did not consider. >>> >>>> >>>> >>>> A small comment in the code could be helpful for mdev non-experts. Hell, I would >>>> even consider documenting it for all mdev -- took me some time to figure out. >>> >>> You may want to bring this up with the VFIO mdev maintainers, but I'd be happy to >>> include a comment in the functions in question if you think it important. >>> >>>> >>>> >>>> [..] >>>> >>>> >>>>> +int vfio_ap_mdev_register(struct ap_matrix *ap_matrix) >>>>> +{ >>>>> +    int ret; >>>>> + >>>>> +    ret = mdev_register_device(&ap_matrix->device, &vfio_ap_matrix_ops); >>>>> +    if (ret) >>>>> +        return ret; >>>>> + >>>>> +    ap_matrix->available_instances = AP_MATRIX_MAX_AVAILABLE_INSTANCES; >>>>> + >>>>> +    return 0; >>>>> +} >>>>> + >>>>> +void vfio_ap_mdev_unregister(struct ap_matrix *ap_matrix) >>>>> +{ >>>>> +    ap_matrix->available_instances--; >>>> >>>> What is this for? I don't understand. >>> >>> To control the number of mediated devices one can create for the matrix device. >>> Once the max is reached, the mdev framework will not allow creation of another >>> mediated device until one is removed. This counter keeps track of the number >>> of instances that can be created. This is documented with the mediated >>> framework. You may want to take a look at: >>> >>> Documentation/vfio-mediated-device.txt >>> Documentation/vfio.txt >>> Documentation/virtual/kvm/devices/vfio.txt >> >> This is what you do in create/remove. >> But here in unregister I agree with Halil, it does not seem to be usefull. > > If that is in fact what Halil was asking, then I misinterpreted his question; I > thought he was asking what the available_instances was used for. You are > correct, this does not belong here although it makes little difference given > this is called only when the driver, which creates the matrix device, is unloaded. > It is necessary in the register function to initialize its value, but I'll > remove it from here. > I questioned the dubious usage of ap_matrix->available_instances rather than asking what is the variable for. If I've had this deemed damaging I would have asked if it's damaging in a way I think it is. For example take my comment on 'KVM: s390: interfaces to manage guest's AP matrix'. Regards, Halil >> >> >>> >>>> >>>> >>>> Regards, >>>> Halil >>>> >>>>> + mdev_unregister_device(&ap_matrix->device); >>>>> +} >>> >>> >> >