Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp785394imm; Tue, 15 May 2018 09:08:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrQQJ4UNiY6jnzyk/IAjaC3sh+FudVXlliaaQQ/ueEwHRzPC/fbPmnh+Klip1iMz/XodWod X-Received: by 2002:a17:902:6505:: with SMTP id b5-v6mr15028985plk.147.1526400517243; Tue, 15 May 2018 09:08:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526400517; cv=none; d=google.com; s=arc-20160816; b=Qi986rE5jKEB1/sZLSBaIvbue/ffGljWRs08ClfmSL6/AKcVnu+fqr+kkeivd/NX01 QtF9g3jUH0m9h1V4qgcBHqZyJs18TabTR7Y+Q1olj5v+kW+PbvQBZz3IwFsCNuEgn//U eLPj5gSzV8tq4hImFg2hhMuco8PoyxGCd0REF42y5/t3xsD+N7AgDHzts0fWio+1dxxd OjwkvBgS3Gd57/MdgVfaJkjuKgFYZTb+ZVh2BchEUTyfhhBcQR3WK6rbV5JLF8G/xh/B qJjsahaT9rtYNUG3VwEz0UxEQ6AA4qlhHhV83/kEIXqZTsl/uUdpq2oKsuGSuag/YaGK EpDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature:arc-authentication-results; bh=aCUM8a74YQI8iUVd4LnbR3+gLMae3RVuiNchzcc9A0c=; b=Tvw7inQZHNzHWbskjskVcD0YayE1ueq1OglV8Ay0G26ta/XQhBfT0JFMcgBKL2aU2Q LG+iAZoO34Nbya8F7kyoZ5wlHYbBRbcwVozs2gQRd4d3RpX8e//uqtD7s6kIyHYBBgIB uXb4jg0rCxiWLVUSfg9aKhtjXCqb9F9M6luXqaPG18zhKdWT0MA2WLvVPSYIS950fzjd gZiUNvUhO/7KPLssBfGGEpQfLtj+SABtCZYhi4vlpfZQW1O7DeJuvFYTITfjDLXBiolH 5uC/YKu1pFCm6yMubh1m4GlHwLP5HBxkmFSoOYrdeyl+FqwbowUyjrE+40oEHa5xK8tu DxGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=POUqw44M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v137-v6si290733pgb.117.2018.05.15.09.08.22; Tue, 15 May 2018 09:08:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=POUqw44M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbeEOQHb (ORCPT + 99 others); Tue, 15 May 2018 12:07:31 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:41502 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbeEOQHa (ORCPT ); Tue, 15 May 2018 12:07:30 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4FG14hG174272; Tue, 15 May 2018 16:07:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : content-transfer-encoding; s=corp-2017-10-26; bh=aCUM8a74YQI8iUVd4LnbR3+gLMae3RVuiNchzcc9A0c=; b=POUqw44Mo0zCaI39RRroxXeAVRuMbcDX/3aFRlcBAQGNIBpZOYz0qGPCaUMlqOLXi8wg qmSQRuJUlzcfxGFhg5QgLOpMeRdK6yIed9CxcVwPcgIz8LMtIuIX/yGd+5OtGluhqgXL +zia0uEKNTiE4Qxj0wVJztiPpZ3iHiWI4108AbiBKIJ8k+2+eQJmEXi4WGFhKwhMR//E IFn79jFWx1dPBA7dAgicH0JrELUkWAx6MdYbSjdg7qzo9dx+KWYGXzMjKO196vJKzLvK /GA++Mp2HIb5SF2mmvkfvNAgX6aDs8par2Pu2xKpCTCjaQcsD4CGHwxd8UZUiqywIRpt LQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2hx29w158r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 May 2018 16:07:00 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4FG7030024392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 May 2018 16:07:00 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4FG70UF027287; Tue, 15 May 2018 16:07:00 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 May 2018 09:06:59 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id DDFC76A00D5; Tue, 15 May 2018 12:06:58 -0400 (EDT) Date: Tue, 15 May 2018 12:06:58 -0400 From: Konrad Rzeszutek Wilk To: Paolo Bonzini Cc: "Raslan, KarimAllah" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "rkrcmar@redhat.com" , "david@redhat.com" Subject: Re: [PATCH v2 00/12] KVM/X86: Introduce a new guest mapping interface Message-ID: <20180515160658.GA12122@char.us.oracle.com> References: <1523829198-13236-1-git-send-email-karahmed@amazon.de> <1523880592.22952.9.camel@amazon.de> <34b4c91d-46f0-1205-5850-f13ccb70d496@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <34b4c91d-46f0-1205-5850-f13ccb70d496@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8894 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805150162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2018 at 02:27:13PM +0200, Paolo Bonzini wrote: > On 16/04/2018 14:09, Raslan, KarimAllah wrote: > >> I assume the caching will also be a separate patch. > > Yup, do you want me to include it in this one? I already have it, I > > just thought that I get those bits out first. >=20 > It's the same for me. >=20 > Paolo >=20 > >> It looks good except that I'd squash patches 4 and 9 together. > > Yup, makes sense. I should have squashed them when I removed the=A0 > > lifecycle change! > >=20 > > Thanks for the review :) > >=20 > >> But I'd like a second set of eyes to look at it. Did anybody else end up reviewing these patches? And would it make sense to repost a new version with the #4 and #9 squashed? Thanks. >=20