Message-Id: <200308291622.h7TGMQGG010465@turing-police.cc.vt.edu>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test4-mm3 
In-Reply-To: Your message of "Fri, 29 Aug 2003 08:35:40 PDT."
             <20030829083540.58c9dd47.akpm@osdl.org> 
From: Valdis.Kletnieks@vt.edu
References: <3F4F22D3.9080104@freemail.hu>
            <20030829083540.58c9dd47.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_445810014P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date: Fri, 29 Aug 2003 12:22:26 -0400
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1926
Lines: 62

--==_Exmh_445810014P
Content-Type: text/plain; charset=us-ascii

On Fri, 29 Aug 2003 08:35:40 PDT, Andrew Morton said:

> Meanwhile, I'll alter Valdis's patch so that it warns, but does not fail
> the make.
> 

I've sent Andrew an updated patch (attached) which issues a warning if the
final depmod actually fails.  The user won't know there's a problem till the
very end of 'make modules_install', but at least it will give them a hint of
where to go for self-help.  

--- Makefile.hold	2003-08-27 01:52:20.000000000 -0400
+++ Makefile	2003-08-29 11:52:15.542286300 -0400
@@ -209,7 +209,7 @@
 RPM 		:= $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
 		    	else echo rpm; fi)
 GENKSYMS	= scripts/genksyms/genksyms
-DEPMOD		= /sbin/depmod
+DEPMOD		= /sbin/depmod.old
 KALLSYMS	= scripts/kallsyms
 PERL		= perl
 CHECK		= sparse
@@ -612,7 +612,14 @@
 endif
 .PHONY: _modinst_post
 _modinst_post: _modinst_
-	if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
+	@if [ -r System.map ]; then \
+		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE)   ; then \
+			echo "*** Depmod failed!!!"; \
+			echo "*** You may need to install a current version of module-init-tools"; \
+			echo "*** See http://www.codemonkey.org.uk/post-halloween-2.5.txt"; \
+			exit 1; \
+	 	fi \
+	fi
 
 else # CONFIG_MODULES
 

--==_Exmh_445810014P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQE/T33CcC3lWbTT17ARAoPVAKCERc4cvB5UaKK/lptZx/WZvet3gACeOuZw
axTKcjTY2rn1Wi/+vz8Dkig=
=faSS
-----END PGP SIGNATURE-----

--==_Exmh_445810014P--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/