Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1123136imm; Tue, 15 May 2018 14:13:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo2ljQ8aBtefMWHWW2gOZRcW+F0Q7GkoGgwD75buK495N2/LLVZMD7JJs9zcUYHsgsFaGH0 X-Received: by 2002:a63:8849:: with SMTP id l70-v6mr13776923pgd.49.1526418813489; Tue, 15 May 2018 14:13:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526418813; cv=none; d=google.com; s=arc-20160816; b=mrsTutdjCAq/Q1ug5JS+5jkryWSxRDbjHhdVP7vZeaL/jgBquAiIOUsAzro9z9R/AA I3fPtvkUBLla+WL27a4LZgmQDO192aacz7BHVmoWS0Puqy8Ekz9YbYQNoqmlLCNevl9c wS6QYZj3fkAjQ2BR/JPAQp5e5MuFk3ttJYiyv6yYh/mE6VzzJP6GoIFUPAXs+MiOEo+X F4EXAcdxrn+qfYZil7jOxsb89Z37m/dXRCvgqyxezaHX0J2FThrZhsLMVY7vSyGB1qf5 kBJAufhegZhCDF3WkOcBA/FzjnZ3Gxbo0n/hSB4QiMmk/3PqIORGUgRzPWZQbaSwkipQ efrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=zCc1i84OI0tVFjC8H1CU2G7F1a93xzp1a1wUEn8/DbU=; b=LwQze0f3bJxdikFNHKN0ea3l55mOQoWPhLeqApE/wYSHCtGDRM1jApOz5YNatQKCfw ZNhtvX47FfPBjBhngnG3fyfydSzl0X19cH739OwFLZmSyw2sbQ1iFKtBOPdbQDztnMW8 n4w83GzyNhFBWm/3VIlGgOW7mC/q6dt7p4yIbxzF+DcwrGx0uzw/T0B6UNOpZ21CoASG dXf/D2+oJervsTrjIzrqLIBRMh1SUZrudQosZ2FKRgGbb4ihW/Q5bD1GCsDhFXKxupJJ qmNjD3S5Zj9VpePB3CMoMgVUuA+YG2hwYWKIi3xZLz4ExfwMu0uz1yg5SFMMRILaJNDJ YNBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r9-v6si949489pfg.247.2018.05.15.14.13.18; Tue, 15 May 2018 14:13:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbeEOVMn (ORCPT + 99 others); Tue, 15 May 2018 17:12:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59498 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354AbeEOVMm (ORCPT ); Tue, 15 May 2018 17:12:42 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C2573D07; Tue, 15 May 2018 21:12:41 +0000 (UTC) Date: Tue, 15 May 2018 14:12:40 -0700 From: Andrew Morton To: Pavel Tatashin Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mhocko@suse.com, linux-mm@kvack.org, mgorman@techsingularity.net, mingo@kernel.org, peterz@infradead.org, rostedt@goodmis.org, fengguang.wu@intel.com, dennisszhou@gmail.com Subject: Re: [PATCH v5] mm: don't allow deferred pages with NEED_PER_CPU_KM Message-Id: <20180515141240.c7587ed53a0ff32ff984e3d2@linux-foundation.org> In-Reply-To: <20180515175124.1770-1-pasha.tatashin@oracle.com> References: <20180515175124.1770-1-pasha.tatashin@oracle.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 May 2018 13:51:24 -0400 Pavel Tatashin wrote: > It is unsafe to do virtual to physical translations before mm_init() is > called if struct page is needed in order to determine the memory section > number (see SECTION_IN_PAGE_FLAGS). This is because only in mm_init() we > initialize struct pages for all the allocated memory when deferred struct > pages are used. > > My recent fix exposed this problem, "my recent fix" isn't very useful. I changed this to identify c9e97a1997 ("mm: initialize pages on demand during boot"), yes? > > Fixes: 3a80a7fa7989 ("mm: meminit: initialise a subset of struct pages if CONFIG_DEFERRED_STRUCT_PAGE_INIT is set") > Signed-off-by: Pavel Tatashin And I added cc:stable.