Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1271775imm; Tue, 15 May 2018 17:03:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqRWUyfm4O9Cz2tBPspU0wuNbgxI0emR1fEiX+96lO6pwKwESJ6t9YfqyETFdKZyoQvmR8G X-Received: by 2002:a63:7514:: with SMTP id q20-v6mr13804527pgc.127.1526429003285; Tue, 15 May 2018 17:03:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526429003; cv=none; d=google.com; s=arc-20160816; b=U8J9Iztr7hFpWFEv+CfFAaT7VbMesK7H/scJQDO4PnRSOjFvRIy5btQo6uqXLj3SOe 70yc++aOem8hhuoEZ5qyX5LlTN7dsOCpK/ept1dv+3l2eybBtuVy0fr/Wry9s0+sP/b+ MKeJWdXEVJCD1YdxVXUtBinZTANt7VjK6M4w44dvPNNj8UgKfj6mIXSzkkhMCiAT9N48 4MVL+tgCs6P3FooOoF4WhOUygI1IDRqSvHHimfAzS003QTSspA1odHkhTYcFM0dcFCfN 7cQ54ROK2p512H3MUFFU410BCf1Cr4JToIlTRLKL1pp2RHGH3bRkQh55iwGrpXWqa6NH UuYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=5TXmWpco/b131jbxGx/i8kPHsQ98+v3nkoboyZfb0+8=; b=UfxR1P3C0xo+QeL3VghpXAK4UMmMZO2V5P+I6/4eBQhRtdVRhGHpspFE43lBZKJB6w jaN4fx1gtfiM6fhAxZsGQ9oW03AVPFcNaRQ8YxcUYOrA3Cqx/9G//cWReTWsnjK3E/9E AhzIR98zdziSXs0N37eNrzTqyO2W7N+XUC3qbG9tDMg/y6DuFxDJcbzQAqn+DB0T5W56 26tY4hiufeloFuuZI/ZhCV12xVrR3qwvVQeQbVi82A+MpYvE+G194wyYuXA4BK3l+1Jk QkMpV1D4XJH9oP9h/lzxQBWMJo11H737ZRdEFT4+3OlQ2hHurw2Fjac6060z8rrVXvWn +/UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=g/cc4QVo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l10-v6si973279pgn.304.2018.05.15.17.03.08; Tue, 15 May 2018 17:03:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=g/cc4QVo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbeEPACs (ORCPT + 99 others); Tue, 15 May 2018 20:02:48 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:49191 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbeEPACo (ORCPT ); Tue, 15 May 2018 20:02:44 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id w4G01TAA015373; Tue, 15 May 2018 19:01:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1526428889; bh=5TXmWpco/b131jbxGx/i8kPHsQ98+v3nkoboyZfb0+8=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=g/cc4QVoxU8ASGANKjlt1iJzBuw7TXqdKAXG5Yj/n1XIJa3OrwLazyWRiPwXXbbl0 wLH1znjuNWntwYCUHWxGZEs8/7s5Ho7wdMgsrixhU8UoRr2GH2sn4bnpmSqRsGjX79 ANiHG7A+JeaMJywqBT0ubgWQqRPLezyX7sh8TBQQ= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w4G01Twl004698; Tue, 15 May 2018 19:01:29 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 15 May 2018 19:01:29 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Tue, 15 May 2018 19:01:29 -0500 Received: from [128.247.59.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w4G01SRi031364; Tue, 15 May 2018 19:01:28 -0500 Subject: Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register() To: Florian Fainelli , CC: Andrew Lunn , Vivien Didelot , "David S. Miller" , Nicolas Ferre , Fugang Duan , Sergei Shtylyov , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Woojung Huh , Microchip Linux Driver Support , Rob Herring , Frank Rowand , Antoine Tenart , Tobias Jordan , Russell King , Geert Uytterhoeven , Thomas Petazzoni , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Simon Horman , Maxim Uvarov , Sekhar Nori , open list , "open list:RENESAS ETHERNET DRIVERS" , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , "open list:USB NETWORKING DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" References: <20180515235619.27773-1-f.fainelli@gmail.com> <20180515235619.27773-3-f.fainelli@gmail.com> From: Grygorii Strashko Message-ID: Date: Tue, 15 May 2018 19:01:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180515235619.27773-3-f.fainelli@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2018 06:56 PM, Florian Fainelli wrote: > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in drivers that strictly adhere to it. > > Signed-off-by: Florian Fainelli > --- > drivers/net/dsa/bcm_sf2.c | 8 ++------ > drivers/net/dsa/mv88e6xxx/chip.c | 5 +---- > drivers/net/ethernet/cadence/macb_main.c | 12 +++--------- > drivers/net/ethernet/freescale/fec_main.c | 8 ++------ > drivers/net/ethernet/marvell/mvmdio.c | 5 +---- > drivers/net/ethernet/renesas/sh_eth.c | 11 +++-------- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 5 +---- > drivers/net/ethernet/ti/davinci_mdio.c | 8 +++----- for drivers/net/ethernet/ti/davinci_mdio.c: Reviewed-by: Grygorii Strashko > drivers/net/phy/mdio-gpio.c | 6 +----- > drivers/net/phy/mdio-mscc-miim.c | 6 +----- > drivers/net/usb/lan78xx.c | 7 ++----- > 11 files changed, 20 insertions(+), 61 deletions(-) -- regards, -grygorii