Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1629864imm; Wed, 16 May 2018 00:18:06 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqmDaDpbv7HGCRDvJFpsQK5B9nw48tsKCDAqfHcN0U8jUjztlRUOnTnrGbQFHtOeYCwvRc0 X-Received: by 2002:a63:6407:: with SMTP id y7-v6mr14689296pgb.373.1526455086893; Wed, 16 May 2018 00:18:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526455086; cv=none; d=google.com; s=arc-20160816; b=NKMghOG4x0rHaODNS55UMlqSRvQpXxa48F1BE0SzOiZ7yqqnLIcPP18o+SHXSqWyvf GhDJXO0eUBH1e1NUlVaqCENRjpUGXgOSZxQp7lntZyw9B2Az/olq6i7EfbLmueIE8x+O 2yh1MjUS28QASjsvqa3MEQTjNiCjZirm22ZyfRGJE5fZbLyLLCIswG/DM+Ha1Rx0N3qz fkFzsuY/D2kAE5lwjCSbb71uKVHTohdCmId4wTtDn6/W+zOyDIeMUKYo6UX2aR+ckiCY TNk+bCyfFyUe8HHxx/y3SBWHM7V3NAyW5wYVnplwrr20HgGSWQI1/XaYBtrn81lteEyw buRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=+EmUk8Az0OQnj0nnB3rxpdCt2LGhBQuY0rrC+SqwPUo=; b=dcmgkSaebQ6nJ2SeQJLfwjLYKo0srLRbLJi0Q/n4auwwDRXmMHLR2fbJe3EYg+xH6l rpfm6/TT5ZupH+kn7ML72dOiudUSyzq5WY18zDSqB9bmAQIawXtHRvvEWXYGsppDTUY7 rrc0p6aKScmld3SMHiNztbMZfI2Pl734hZpfzEgNuJW2fQctgJhJuh4wgCEPls/lGLGO 8FjN50juHUjmavTjQTGaAo+AS1WBY8Dtp0DhRMPm2T97ziwRC2AyTGs/TvPcM4ZEW5gF FeMKNE8v2ywMjkgiuxqc7SRKWgN9YVQAJXmGdyDeEgP7xpY6YG5E341c0u1AFt0NTxLC E+5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eFWPpVCC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si1883178plb.558.2018.05.16.00.17.52; Wed, 16 May 2018 00:18:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eFWPpVCC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbeEPHQ4 (ORCPT + 99 others); Wed, 16 May 2018 03:16:56 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36488 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbeEPHQz (ORCPT ); Wed, 16 May 2018 03:16:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+EmUk8Az0OQnj0nnB3rxpdCt2LGhBQuY0rrC+SqwPUo=; b=eFWPpVCCbfgBo8gJwgdJPircC JRbbXHtOPDRqisqyb8DNTWgyqkFy2vNl4UJS4VaJpYSCx2rWMFSV4khnPDoEDXOS1Sx1//6S4cCi5 njvOF/obXHQUV/XMvwsa6B4dPjP5Ga/glP/Vvr+3g+ofm9X2ji/6Rm55rN5pg7QJBLVJXX2JtwEaf vYuY8Z595xIjZfemJ2eKNKKLz/z2oeoPOyFY41nDv3CeVzxs2rQlarch+N+QFs3dqndAaAec3vKD1 2WPWdCpoma7ZzUEKeYZo1oBGQZw2a8kzhQaLmYJCstj+oXydCtC11jvmKrVX4cGrRTAIOT+4ZAFyi Vq5c7lX4w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIqfy-0004x1-O4; Wed, 16 May 2018 07:16:42 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6CD6B2029F1C1; Wed, 16 May 2018 09:16:40 +0200 (CEST) Date: Wed, 16 May 2018 09:16:40 +0200 From: Peter Zijlstra To: Srinivas Pandruvada Cc: tglx@linutronix.de, mingo@redhat.com, bp@suse.de, lenb@kernel.org, rjw@rjwysocki.net, mgorman@techsingularity.net, x86@kernel.org, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, juri.lelli@arm.com, linux-kernel@vger.kernel.org Subject: Re: [RFC/RFT] [PATCH 02/10] cpufreq: intel_pstate: Conditional frequency invariant accounting Message-ID: <20180516071640.GU12217@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-3-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516044911.28797-3-srinivas.pandruvada@linux.intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 15, 2018 at 09:49:03PM -0700, Srinivas Pandruvada wrote: > intel_pstate has two operating modes: active and passive. In "active" > mode, the in-built scaling governor is used and in "passive" mode, > the driver can be used with any governor like "schedutil". In "active" > mode the utilization values from schedutil is not used and there is > a requirement from high performance computing use cases, not to read > any APERF/MPERF MSRs. In this case no need to use CPU cycles for > frequency invariant accounting by reading APERF/MPERF MSRs. > With this change frequency invariant account is only enabled in > "passive" mode. WTH is active/passive? Is passive when we select performance governor? Also; you have to explain why using APERF/MPERF is bad in that case. Why do they care if we read those MSRs during the tick?