Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-10-git-send-email-vladbu@mellanox.com> <20180516074332.GB1972@nanopsycho>
User-agent: mu4e 0.9.16; emacs 25.3.50.2
From:   Vlad Buslov <vladbu@mellanox.com>
To:     Jiri Pirko <jiri@resnulli.us>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, pablo@netfilter.org,
        kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org,
        daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org,
        linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org, kliteyn@mellanox.com
Subject: Re: [PATCH 09/14] net: sched: don't release reference on action overwrite
In-reply-to: <20180516074332.GB1972@nanopsycho>
Date:   Wed, 16 May 2018 10:47:32 +0300
Message-ID: <vbfd0xw11pn.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2018 07:47:38.6645
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dad6b78f-ebec-4547-c124-08d5bb014d2a
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4702
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wed 16 May 2018 at 07:43, Jiri Pirko <jiri@resnulli.us> wrote:
> Mon, May 14, 2018 at 04:27:10PM CEST, vladbu@mellanox.com wrote:
>>Return from action init function with reference to action taken,
>>even when overwriting existing action.
>>
>>Action init API initializes its fourth argument (pointer to pointer to
>>tc action) to either existing action with same index or newly created
>>action. In case of existing index(and bind argument is zero), init
>>function returns without incrementing action reference counter. Caller
>>of action init then proceeds working with action without actually
>>holding reference to it. This means that action could be deleted
>>concurrently. To prevent such scenario this patch changes action init
>
> Be imperative to the codebase in the patch description.
>
>
>>behavior to always take reference to action before returning
>>successfully.
>
> Where's the balance? Who does the release instead? I'm probably missing
> something.

I've resplit these patches for V2 to always do take/release in same
patch.

>
>>
>>Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
>>---
>> net/sched/act_bpf.c        |  8 ++++----
>> net/sched/act_connmark.c   |  5 +++--
>> net/sched/act_csum.c       |  8 ++++----
>> net/sched/act_gact.c       |  5 +++--
>> net/sched/act_ife.c        | 12 +++++-------
>> net/sched/act_ipt.c        |  5 +++--
>> net/sched/act_mirred.c     |  5 ++---
>> net/sched/act_nat.c        |  5 +++--
>> net/sched/act_pedit.c      |  5 +++--
>> net/sched/act_police.c     |  8 +++-----
>> net/sched/act_sample.c     |  8 +++-----
>> net/sched/act_simple.c     |  5 +++--
>> net/sched/act_skbedit.c    |  5 +++--
>> net/sched/act_skbmod.c     |  8 +++-----
>> net/sched/act_tunnel_key.c |  8 +++-----
>> net/sched/act_vlan.c       |  8 +++-----
>> 16 files changed, 51 insertions(+), 57 deletions(-)
>>
>>diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
>>index 5d95c43..5554bf7 100644
>>--- a/net/sched/act_bpf.c
>>+++ b/net/sched/act_bpf.c
>>@@ -311,9 +311,10 @@ static int tcf_bpf_init(struct net *net, struct nlattr *nla,
>> 		if (bind)
>> 			return 0;
>> 
>>-		tcf_idr_release(*act, bind);
>>-		if (!replace)
>>+		if (!replace) {
>>+			tcf_idr_release(*act, bind);
>> 			return -EEXIST;
>>+		}
>> 	}
>> 
>> 	is_bpf = tb[TCA_ACT_BPF_OPS_LEN] && tb[TCA_ACT_BPF_OPS];
>
> [...]