Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1677051imm; Wed, 16 May 2018 01:10:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrrHqh3vxhmwSmNhJkO6f3dS3tuZQmZu0czzfI4fHAxGI6MViV9cEjwCnTjPhx0V6UQfrq0 X-Received: by 2002:a62:679a:: with SMTP id t26-v6mr19103399pfj.24.1526458257777; Wed, 16 May 2018 01:10:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526458257; cv=none; d=google.com; s=arc-20160816; b=wcHcDVUzR55jUkeKcdlnEgY3pDWPg2RLxzKSHfv/ylkxvOKxDuX1B/6aXDtm99GnEd GKR3VK1DBr+opoF9cEJrATOc9QkJxgMBNF2DVMlIZJMZZLI0mTXC+h+JD4wK+7arVxLt CC4/jvJRgWDxVzqqvmXMsdXVpQWL5hl0iv5aTqtvJiDLMu1gDVOzA84c6EUDtd5oG7nz cnSS2bETtXk1P8mwx1+aXfxSTpHCEziy/lDIQZxZOZZyG8U0M1YzPRnmrgf1hb+We4yL EAHlUkWjo2m0ZEeesv7LpGm/tpQki2rnh6leMJBn0/sRu1T6m9EtotGECcoZy/e3L0TK dYZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=LZr4uqclhJ7Yn6443lGJMR8L+pHj5hhHa8HZm1itTIM=; b=Xp1Znthue+Mmk+7coJ/DGhihYRpvbv87xisj5+2BXq4T23HPAJGXqQ0vhEygHb4lQM Mo+8WSe/bYHGoUuk2U2g/pcQezVA/chVULmlDJlKPxThvEH8p4cZ6BV/5IuFBiukmT8W z4UMYkOEtwtrF0AVhHiGzkaNNXBnDTIxmXrBW/pyiw6Pln9EiClKm40TLD+foE/78DMy /D4P7xcmdb9/u5J9ALBQyj8Zjl11wrAPwlApY9ssSrGvscrD1H2/wJp7ZD8ya6A/MSaz MLOj3DdgWUL0HjfumftxVqvLf1oxQPyWqKuuhX8hwVFXgN7I+3P1+zRnlkq2RqWoVH2t pM9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bDoBx8wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10-v6si2011743plv.1.2018.05.16.01.10.43; Wed, 16 May 2018 01:10:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bDoBx8wf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbeEPIJI (ORCPT + 99 others); Wed, 16 May 2018 04:09:08 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:36156 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeEPIJD (ORCPT ); Wed, 16 May 2018 04:09:03 -0400 Received: by mail-ua0-f194.google.com with SMTP id b25-v6so1993774uak.3 for ; Wed, 16 May 2018 01:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LZr4uqclhJ7Yn6443lGJMR8L+pHj5hhHa8HZm1itTIM=; b=bDoBx8wfEqfJAMNDgog+PWJLWnOuTWxIYDi7ck6+wfRA9XfV44DC3kePzJBsfb0Gin JJyHwJgFBzpSjZ3+swnS7eqChUHSGYau8IR4p0zBsRZkRD64bWvNXuNEXmbyToZiV9EX 4cJrPXPESRm3jnRaTkmjvJpui7wozMnVnu9UE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LZr4uqclhJ7Yn6443lGJMR8L+pHj5hhHa8HZm1itTIM=; b=o0bKDjagn4pSucVWoU8gpxdYdnihFB8O3F5Mx788higVHp8dxttbO6paflcA6bjkhT OE+ZmEn+eQBPEwh/WYPToVcxMywoHVR1t0Jrku+zTTKdEt1mj1LP6afrq0b72oYXAQQ1 2yhuIwn9Ycpe2749R+7o8z+fTslcoLYi4QIwnRk2VHTbsF19IQY4+MBQrJ6MdCPG6U/m ugjxAAGLKEXmsBhpyTrFyJl7jHYmxjLQAvZHTq5+I3qInxXAUuke8x5Q7EQcha6J5Pfg 9sq8GA7DDs20eIx+Yl37IxQCKlMvGrw1iSvTHbuWnD9/cd1oUvusFNnOYlKeZajtakIf vCbw== X-Gm-Message-State: ALKqPwflUsiaS3HG4gnCX0Z6yo8q5p0g/j+qzScPVYX66k9j5uAfLzLe QvILgfzjyTtz8i+Y5gFyumu/vVVN/z8= X-Received: by 2002:ab0:4987:: with SMTP id e7-v6mr19625973uad.20.1526458142434; Wed, 16 May 2018 01:09:02 -0700 (PDT) Received: from mail-ua0-f180.google.com (mail-ua0-f180.google.com. [209.85.217.180]) by smtp.gmail.com with ESMTPSA id d21-v6sm303247vke.22.2018.05.16.01.09.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 May 2018 01:09:01 -0700 (PDT) Received: by mail-ua0-f180.google.com with SMTP id i3-v6so1981254uad.4 for ; Wed, 16 May 2018 01:09:01 -0700 (PDT) X-Received: by 2002:a9f:309a:: with SMTP id j26-v6mr19573596uab.71.1526458140803; Wed, 16 May 2018 01:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20180308094807.9443-1-jacob-chen@iotwrt.com> <20180308094807.9443-10-jacob-chen@iotwrt.com> In-Reply-To: <20180308094807.9443-10-jacob-chen@iotwrt.com> From: Tomasz Figa Date: Wed, 16 May 2018 17:08:49 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver To: Jacob Chen , Shunqian Zheng Cc: "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Mauro Carvalho Chehab , Linux Media Mailing List , Sakari Ailus , Hans Verkuil , Laurent Pinchart , =?UTF-8?B?6ZKf5Lul5bSH?= , Eddie Cai , Jeffy , devicetree@vger.kernel.org, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Chen Jacob , =?UTF-8?B?6ZmI5Z+O?= , Allon Huang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacob, Shunqian, On Thu, Mar 8, 2018 at 6:49 PM Jacob Chen wrote: [snip] > +static const struct of_device_id rkisp1_plat_of_match[] = { > + { > + .compatible = "rockchip,rk3288-cif-isp", > + .data = &rk3288_isp_clk_data, > + }, { > + .compatible = "rockchip,rk3399-cif-isp", > + .data = &rk3399_isp_clk_data, > + }, > + {}, > +}; We need MODULE_DEVICE_TABLE() here. Best regards, Tomasz