Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1771479imm; Wed, 16 May 2018 02:50:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrCebX2ryiOyc2WM1LQaUuw07WMSPq8axpWwR7kECHOae02v9cdtMABfhsd9CvM+v8P1crZ X-Received: by 2002:a62:568f:: with SMTP id h15-v6mr174057pfj.131.1526464256852; Wed, 16 May 2018 02:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526464256; cv=none; d=google.com; s=arc-20160816; b=ZNrqDA1lgNdcLSPR/Stduq5DGnRALFu39EhZ2fSUT2wvKmd1tH2qltNpTePWl8hegJ I/J2zmKTq98XYri10laJDgoHBQ02j0dwGwbjihyhXhagRXzP3BTf24puLSONitNwzisw LYnyUkuOb2yDzasLURmx6wHccvllDZAZRxA1AwE76e48m4jCpIMNqp5rDQK10Fn+JiDN F4WuV0tTGhKJO34TfdofaFCrnAGYiNyVAHPgb82xdZLZrkTqL146MH0oY/VVsWYTfKNp Ml1nakFibYTMh+40FzqylDCJ4NhbBshuxWNTtPFkPuZThDagOoOW5C6fbvPlxawrLLNO uGeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=hXXt0SZKdzSWIzmznJe5UqhVyRgDHcAb0SPBypWbTn4=; b=OssZWvSXJCPkf3BRwzsn2p5fMCMlJpDhZ+om+ZkSwp9tSUX4wJWN0B+jyKqA5daNLB c6X0tK0S/wDrWwmfxE6y0r0QEIZSx3l56cb063xxxkfcw4q9fRYbgijc+eatXKBmAqZ9 qotSMS+qz2ZFnxWaf9cXz7K57jKVDZLXE/J7Em62cyxa6KDKYPtSZRCOVhfIxguCRmNT x6KcTvtH6BflkTZj3DuR0p3l/wtIEIMzPppNbcJ1jKnjt0zRkjMu3cglT9XB2z/pSzoH 4LHtU9F7jXmUh/VWiLkpWBJF2u6UJvk/Gg96BoeG0oteLC7aW+y/ZEVLFqZDKVFhkou4 3GRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=UoQwWQKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5-v6si2259770pll.123.2018.05.16.02.50.42; Wed, 16 May 2018 02:50:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=UoQwWQKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbeEPJtx (ORCPT + 99 others); Wed, 16 May 2018 05:49:53 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:54100 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbeEPJtv (ORCPT ); Wed, 16 May 2018 05:49:51 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4G9joxM027688; Wed, 16 May 2018 09:49:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=hXXt0SZKdzSWIzmznJe5UqhVyRgDHcAb0SPBypWbTn4=; b=UoQwWQKeMniKIcesNGYCVzOiD31t8mo5W14dJroGiBaoAHZxIvrBgKxqstd/A2o43Cdg qVSsqktJdiCfQHPlCpQ/iv+cqXRduYMHoIMOVxSOxKSIdSQdmIR//fcZcOMst7TNjxDW udawLYqhF1fjBI6jJGRhGdiAVezTIvDcsAHiMi/VAU/q4jdLU981hSDrVimKbzxiHgws 4sWGjj1KFNdWEtMlpL4+L3IVXfniau5ohGit4lR/aINBiLNqzN0xWcSAig/9ltCrGQcm qetBRXCh2cBSsteMOJU/oEuWw0qcPBdoMUyoqJQ32jzAS0caM2PRa8qt85qvh/2nfx9o Kw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2hx29w420p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 May 2018 09:49:28 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4G9nRTJ016034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 May 2018 09:49:27 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4G9nQrt020530; Wed, 16 May 2018 09:49:27 GMT Received: from [10.182.69.179] (/10.182.69.179) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 May 2018 02:49:26 -0700 Subject: Re: [PATCH] nvme-rdma: clear NVME_RDMA_Q_LIVE before free the queue To: Sagi Grimberg , keith.busch@intel.com, axboe@fb.com, hch@lst.de Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <1525420958-9537-1-git-send-email-jianchao.w.wang@oracle.com> <7096b02a-956a-6765-7839-227c154d8336@grimberg.me> From: "jianchao.wang" Message-ID: <8bba6171-cfe8-3442-7b03-693e34dc096d@oracle.com> Date: Wed, 16 May 2018 17:49:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <7096b02a-956a-6765-7839-227c154d8336@grimberg.me> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8894 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=806 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805160099 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sagi On 05/09/2018 11:06 PM, Sagi Grimberg wrote: > The correct fix would be to add a tag for stop_queue and call > nvme_rdma_stop_queue() in all the failure cases after > nvme_rdma_start_queue. Would you please look at the V2 in following link ? http://lists.infradead.org/pipermail/linux-nvme/2018-May/017330.html Thanks in advance Jianchao