Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1779215imm; Wed, 16 May 2018 03:00:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr/CBlpXCgrnkVZlZn0HvEhFLyFcYU1w3KhJHPxEXlF/2CwacNFFxqFev1D2JMLPY4Vgk3g X-Received: by 2002:a65:4188:: with SMTP id a8-v6mr186607pgq.118.1526464807862; Wed, 16 May 2018 03:00:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526464807; cv=none; d=google.com; s=arc-20160816; b=vymHHdqLUTAM+xQtAqOL2FxnnfiPNeWKFexQsXPVEuRHGb0OxNjaIDpFpTR5UeDq9e 57Cmpp1XSyzgWeqB2cwNq9nf5f6zNET0ZB+sMFBRMMyWlV5gG70jXLWsh/Xi322YYhd3 OAYhEAM0AO58+w5bCVMm6rI9Dw6O8oA7tHXwrG1JPiQREylYEOtGvFfHbd//k5TmtnUn Y31Q6STqexSK0fpYc9rabURoyAOxw0zs6BzvAxkfQjutctivzZp5GBoKgrqKjtEhFGuu zTeY1Nirkf0HWw3c/mtlT/gVQHP+X53yZzWeGVW2LW2WAAh6pq1QgH8uvvgjEMqPeAQj 6R0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=HMCPmYykmvnCT8ZRK8uE70tbafRndyn2d1/GuaZ5ehQ=; b=VgRr20cpK9IWGn28A/tqA6qhnACv1PlR6MeFyfxpCFPtGrcNDAT8n/GoGcD2VoWKfX vwSe/SQ3+PcvtVQ3Vd9IG9rmKNHDTXso3KB4nIN/eBHY44JK1OVT/+SpDM7XAXvzVJXI gXTZODM0vll+A3fc15wj8CckoGLFsc2282bMsBwGNbJQNZUMHJwjxHRWVHGPKIDRy7yO m/SHn3YJTdOinNGPqVw0k/da/eHsPb66/HrCw578uMdydgs7QnX9AtYjSfWaXT3QE1f5 TC2pRa+7aRXGZXq7nqLMaOlIxvugkKyIYe3KJggxwnaZQ6FGzCeL0nJForBnyDF8mwkZ Yf4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GeEXPUB2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q137-v6si2392958pfc.68.2018.05.16.02.59.53; Wed, 16 May 2018 03:00:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GeEXPUB2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbeEPJ6Y (ORCPT + 99 others); Wed, 16 May 2018 05:58:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:57292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbeEPJ6U (ORCPT ); Wed, 16 May 2018 05:58:20 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D48C6206B7; Wed, 16 May 2018 09:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526464699; bh=6DHYJ3gJScCBwlNhKx8MXVSQV2EVRde53WOMbES3NTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GeEXPUB2H+9qBhUy8OQ7CDAt2qePyKZK9k4yoF+pd8i+zGD8wHLCJQmVAwO1BBAlv nfVLfIiOv1Dd+mzZsV7W0iIcexQOpBpo7haM8BF49PCHKcM/W179n94xdwIJMMuMJP nL/FRn7yXm4uVJCP+L4eJyOlU1W78g87zC6UGQ8Y= Date: Wed, 16 May 2018 11:58:02 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Andrew Morton , Alexander Viro , linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Jiri Slaby , linux-ext4@vger.kernel.org, Alexey Dobriyan , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Subject: Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show Message-ID: <20180516095802.GA16090@kroah.com> References: <20180516094346.20506-1-hch@lst.de> <20180516094346.20506-42-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516094346.20506-42-hch@lst.de> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 11:43:45AM +0200, Christoph Hellwig wrote: > Just set up the show callback in the tty_operations, and use > proc_create_single_data to create the file without additional > boilerplace code. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman