Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1787376imm; Wed, 16 May 2018 03:07:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqxNc57UZIVmiSDIpBZSLo8Ev3IkITkMX268XdclSnqFHZpqXup0Mhb3zGtIrbzKjgeohlr X-Received: by 2002:a17:902:5c6:: with SMTP id f64-v6mr276781plf.50.1526465239011; Wed, 16 May 2018 03:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526465238; cv=none; d=google.com; s=arc-20160816; b=yixheLrvbpXz0pQm7j44fFNFrnLWk2Imohs8IBt4EXwG1tS4DQttuuznSb+w/P/NkS 6cJuoUHBS3eMnfQYeji8vhaUoxKjsZpLjRfb2vGBaJFcFfoxU52LFKBblIsIObyJRtHy wwmnvWZ2OwGtJGC++hQLcsPLsz6utNQ8nlHsV1/pI2qq+BPX0WHh86muqP6cDAK+qG9d sFEhJUP+zVg/wrleyfVGin9xRyDiiN/XlvNEbX8IiboFB1LQbolXLBlUMDX9VC9q/jPj Bb1YqeYt9CAUiTzBmh10NPUWfI+DZwFHuo8ukib2RQKgYoD4NQOI1wvk8gncU9UMw73p J2Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=tP6ANtwpZ1e1aewoR17BAzsT2nTWWQksvoQUzYIj2dc=; b=YnyQTRY2gmi0s/zP2uKsnjdcGpTZcmN7T03trG3L0GAOrNdGRZ/Csdw4U8uZZ9wsj8 qFqHyVDqYqdmbQcw3ppDtLeQV/bFMhRRD2LYm29E8vacVEMLX0zoWGptBCi2u6UBEKHX C+Tf0okkbrLu5d4L2ml6VrLGJk16Cq54eGXUq4dgbX3DjsisJiIBeNxXorm1KrqyDB3K 8L1SzEKoKzJYnBWObp0gsfY9CvySqNbMD1UL+SOLTfaPkSHEcnS8uPpEjZGhJbwXlkED +LmEHeU/sFbnNqhcGvtI/BqG+VBUqxC8ojkUxqP/RBywnVCNU23XcIBpC7B2Sa6YawZf 8tpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 43-v6si2302615plb.511.2018.05.16.03.07.04; Wed, 16 May 2018 03:07:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753116AbeEPKGv (ORCPT + 99 others); Wed, 16 May 2018 06:06:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753164AbeEPKFr (ORCPT ); Wed, 16 May 2018 06:05:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8199A40214E2; Wed, 16 May 2018 10:05:46 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-8-19.pek2.redhat.com [10.72.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC6D72024CBB; Wed, 16 May 2018 10:05:41 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org, mingo@kernel.org, lcapitulino@redhat.com, keescook@chromium.org, tglx@linutronix.de Cc: x86@kernel.org, hpa@zytor.com, fanc.fnst@cn.fujitsu.com, yasu.isimatu@gmail.com, indou.takao@jp.fujitsu.com, douly.fnst@cn.fujitsu.com, Baoquan He Subject: [PATCH 1/2] x86/boot/KASLR: Add two functions for 1GB huge pages handling Date: Wed, 16 May 2018 18:05:31 +0800 Message-Id: <20180516100532.14083-2-bhe@redhat.com> In-Reply-To: <20180516100532.14083-1-bhe@redhat.com> References: <20180516100532.14083-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 16 May 2018 10:05:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 16 May 2018 10:05:46 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Functions parse_gb_huge_pages() and process_gb_huge_page() are introduced to handle conflict between KASLR and huge pages, will be used in the next patch. Function parse_gb_huge_pages() is used to parse kernel command-line to get how many 1GB huge pages have been specified. A static global variable 'max_gb_huge_pages' is added to store the number. And process_gb_huge_page() is used to skip as many 1GB huge pages as possible from the passed in memory region according to the specified number. Signed-off-by: Baoquan He --- arch/x86/boot/compressed/kaslr.c | 71 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c index a0a50b91ecef..13bd879cdc5d 100644 --- a/arch/x86/boot/compressed/kaslr.c +++ b/arch/x86/boot/compressed/kaslr.c @@ -215,6 +215,32 @@ static void mem_avoid_memmap(char *str) memmap_too_large = true; } +/* Store the number of 1GB huge pages which user specified.*/ +static unsigned long max_gb_huge_pages; + +static int parse_gb_huge_pages(char *param, char* val) +{ + char *p; + u64 mem_size; + static bool gbpage_sz = false; + + if (!strcmp(param, "hugepagesz")) { + p = val; + mem_size = memparse(p, &p); + if (mem_size == PUD_SIZE) { + if (gbpage_sz) + warn("Repeadly set hugeTLB page size of 1G!\n"); + gbpage_sz = true; + } else + gbpage_sz = false; + } else if (!strcmp(param, "hugepages") && gbpage_sz) { + p = val; + max_gb_huge_pages = simple_strtoull(p, &p, 0); + debug_putaddr(max_gb_huge_pages); + } +} + + static int handle_mem_memmap(void) { char *args = (char *)get_cmd_line_ptr(); @@ -466,6 +492,51 @@ static void store_slot_info(struct mem_vector *region, unsigned long image_size) } } +/* Skip as many 1GB huge pages as possible in the passed region. */ +static void process_gb_huge_page(struct mem_vector *region, unsigned long image_size) +{ + int i = 0; + unsigned long addr, size; + struct mem_vector tmp; + + if (!max_gb_huge_pages) { + store_slot_info(region, image_size); + return; + } + + addr = ALIGN(region->start, PUD_SIZE); + /* If Did we raise the address above the passed in memory entry? */ + if (addr < region->start + region->size) + size = region->size - (addr - region->start); + + /* Check how many 1GB huge pages can be filtered out*/ + while (size > PUD_SIZE && max_gb_huge_pages) { + size -= PUD_SIZE; + max_gb_huge_pages--; + i++; + } + + if (!i) { + store_slot_info(region, image_size); + return; + } + + /* Process the remaining regions after filtering out. */ + + if (addr >= region->start + image_size) { + tmp.start = region->start; + tmp.size = addr - region->start; + store_slot_info(&tmp, image_size); + } + + size = region->size - (addr - region->start) - i * PUD_SIZE; + if (size >= image_size) { + tmp.start = addr + i*PUD_SIZE; + tmp.size = size; + store_slot_info(&tmp, image_size); + } +} + static unsigned long slots_fetch_random(void) { unsigned long slot; -- 2.13.6