Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1825757imm; Wed, 16 May 2018 03:45:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpapb8A5zFbkhWVY55nKciaR6ruwL4LwDR8DM9luxh6bqKI5ZwnPx8SOXpUCaQI9J7AZYew X-Received: by 2002:a63:7c55:: with SMTP id l21-v6mr316031pgn.148.1526467534361; Wed, 16 May 2018 03:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526467534; cv=none; d=google.com; s=arc-20160816; b=dgduzYnUkSx54rRZ40WtgBS3Za1utsQQ2q8tzrrQYZjSec8OKXrLIY3X4ETMtkLk+o l38cat46ZboY7nY2l5OILQh8RKu7JkFTLTqYokGDdu7/y/udbD0SDXtJ/tVog5cBHMmm YwdasO1SqRR6zs847S0ObaVRgmeIUc80Q7nR9g2feDjJRk9fsBQRePw39Y8zDQImJPlp 3+lz1DbPcz+S4HtDdVomohX+V1oUHg2NMW8H1l2Ls+yiKZx9W0oeShy4avndfEb7hWti 3wuESLJXLuy1ca3PtNVzG2d3rQnWHKTuNeWJp3n6VMeMQuFkXpQwSxoJKJwWR+9PCmeu qTWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=aFC4NLRqp+df4b+KbbGYtbQJwovmY2ah6u+ErbdA+Ks=; b=itG1QRXSnXXQYQvA8wJFdvLykpx5UfgRr84Mi1zSJ6L+HzdJXg8ll3JYtpYqQdg3qA DJtSJPPHQscb32vWeRr2wRQPFRr9tRuSSd2x6xqaLydUx37StztxVi/82axNxKsgQ3+m RPangOYzNbHCyP66A3S8KyHx9iazAUnT836Djx03EKFdW0djzBbx6npx3y3PPhCCSKCv FcXOJ2uvwZWqkEfboZfWLv9GP6jW62GKkgBHtcrTv7r/JpKIVlmTtFtolVyNVBRfIe/0 Ko9sbxvlKg6Tsf+BOrj0mfHkRTCQPI73GNn/3ZQWUGuloamfZVDO3oFh0650/m4HgN6C jCAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=PAkKXxSV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l61-v6si1847762plb.507.2018.05.16.03.45.20; Wed, 16 May 2018 03:45:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=PAkKXxSV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbeEPKnd (ORCPT + 99 others); Wed, 16 May 2018 06:43:33 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45920 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbeEPKna (ORCPT ); Wed, 16 May 2018 06:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aFC4NLRqp+df4b+KbbGYtbQJwovmY2ah6u+ErbdA+Ks=; b=PAkKXxSVtPsAo9omC7spQLko4 Fr1PsKyaIIYOLfvCoJ7EjKm3GkDUjmAJ4pVcnoYgeEbz0M1DFe+jaXYE1DYZplMolZW7xZHJ+7LJH u21MbhFoRnCIj0CZ821ECMUJ7JtwIvwtH7NEukSBnlgZbPtR/CXdsq2HjOQwwPGYzIJGqNGbjpEme CE/2RzpT4mKfR6rFoU9wPQCaixsmWvMzcfNWblQOBuNzCtdk7c6EjrJdB72W8Dm75v1xw5UI3Tgjx e6anIhuoNq4DB9vo/Vj87P7VV4zaMIrl16G3mZHtuJbqULLq5g9TfM3tKNkhLXmhxiacTw6j10Rgp 7BP2MWuyA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIttr-0006kM-3V; Wed, 16 May 2018 10:43:15 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6FB862029F869; Wed, 16 May 2018 12:43:13 +0200 (CEST) Date: Wed, 16 May 2018 12:43:13 +0200 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Srinivas Pandruvada , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Len Brown , "Rafael J. Wysocki" , Mel Gorman , the arch/x86 maintainers , Linux PM , Viresh Kumar , Juri Lelli , Linux Kernel Mailing List Subject: Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits Message-ID: <20180516104313.GC12217@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-4-srinivas.pandruvada@linux.intel.com> <20180516072202.GV12217@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 11:15:09AM +0200, Rafael J. Wysocki wrote: > So if the "cached" thing is the last "not boosted EPP", that's why it > is not updated here. Sure, I see what it does, just saying that naming and comments are wrong vs the actual code.