Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 May 2018 14:58:14 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Greg KH <greg@kroah.com>,
        Paul Menzel <pmenzel+linux-usb@molgen.mpg.de>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell
 XPS 13 9370
Message-ID: <20180516115814.GB11469@kuha.fi.intel.com>
References: <9365397f-7206-728e-ee76-146629bfd186@molgen.mpg.de>
 <20180515160047.GB26720@kroah.com>
 <69da4aa4-3d4b-0ffc-81ce-500713cd3743@molgen.mpg.de>
 <20180516080226.GC3536@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180516080226.GC3536@kroah.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, May 16, 2018 at 10:02:26AM +0200, Greg KH wrote:
> On Tue, May 15, 2018 at 06:47:37PM +0200, Paul Menzel wrote:
> > Dear Greg,
> > 
> > 
> > As always, thank you for the prompt response.
> > 
> > 
> > On 05/15/18 18:00, Greg KH wrote:
> > > On Tue, May 15, 2018 at 04:34:03PM +0200, Paul Menzel wrote:
> > 
> > > > Linux 4.17-rc5 shows the error below on the Dell XPS 13 9370 with Debian
> > > > Sid/unstable.
> > > > 
> > > > ```
> > > > [???]
> > > > [    0.440240] usb: port power management may be unreliable
> > > > [    0.441358] usbcore: registered new interface driver usb-storage
> > > > [    0.441367] usbcore: registered new interface driver usbserial_generic
> > > > [    0.441369] usbserial: USB Serial support registered for generic
> > > > [    0.441383] ioremap error for 0x3f799000-0x3f79a000, requested 0x2, got
> > > > 0x0
> > > > [    0.441518] ucsi_acpi: probe of USBC000:00 failed with error -12
> > > > [???]
> > > > ```
> > > > 
> > > > 1.  Are the ioremap and ucsi_acpi error related or is a separate report
> > > > needed?
> > > 
> > > The ioremap error is what causes ucsi_acpi to fail the probe call (-12
> > > is "out of memory".)
> > > 
> > > > 2.  Do you know the reason for the ucsi_acpi error?
> > > 
> > > the call to ioremap failed.
> > > 
> > > Does this device really have a working typec connector?
> > 
> > Just to avoid misunderstandings, no device was connected to the laptop
> > during my test.
> > 
> > But, from other boots, the Dell docking station TB16 kind of works with it,
> > so I???d say the USB Type-C connector is working.
> 
> Ok, good, this might just be the acpi tables not set up properly for
> this type of connection.  Odd that the tables show it should work,
> Heikki should know more about this.

The firmware probable has not implemented UCSI on this board. I think
Dell always supplies the ACPI device node for UCSI in their acpi
tables. The _STA method in that device node is then used to inform the
OS if the interface exists or not. The return value for _STA comes
probable from BIOS, so this is most likely a BIOS problem.

Please note that UCSI will only supply status information to the
operating system, so the USB Type-C ports will function normally even
without it. The ports are handled in firmware on these platforms.

Paul, do you have the latest BIOS?


> > > Does normal USB devices work with it?
> > 
> > Sorry for being ignorant, but could you please tell me what normal USB
> > devices are?
> 
> If you plug a USB typeC device into this port, does it work?  A docking
> station is a little bit "different" in that it usually uses the PCIe
> connection, not the USB connectors.  Or at least that's how my Dell
> docking station works last time I tried it[1]
> 
> thanks,
> 
> greg k-h
> 
> [1] When the power supply for the docking station is bigger than the
>     laptop's power supply, you begin to wonder what is in that thing and
>     stop using it after a while...

Br,

-- 
heikki