Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   KY Srinivasan <kys@microsoft.com>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?iso-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
        Mohammed Gamal <mmorsy@redhat.com>,
        Cathy Avery <cavery@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
 definitions to common header
Thread-Topic: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
 definitions to common header
Thread-Index: AQHT7SmWDbZrizy7jECQPkLAHPanXqQygJ6g
Date:   Wed, 16 May 2018 15:52:45 +0000
Message-ID: <MW2PR2101MB1113225D3DBAF5A62FAA990AA0920@MW2PR2101MB1113.namprd21.prod.outlook.com>
References: <20180516152131.30689-1-vkuznets@redhat.com>
 <20180516152131.30689-2-vkuznets@redhat.com>
In-Reply-To: <20180516152131.30689-2-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d45a500b-d9f7-42a8-b496-08d5bb45114e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2018 15:52:45.7959
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0892
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
> Sent: Wednesday, May 16, 2018 8:21 AM
> To: kvm@vger.kernel.org
> Cc: x86@kernel.org; Paolo Bonzini <pbonzini@redhat.com>; Radim Kr=E8m=E1=
=F8
> <rkrcmar@redhat.com>; Roman Kagan <rkagan@virtuozzo.com>; KY
> Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; Michael Kelley (EOSG)
> <Michael.H.Kelley@microsoft.com>; Mohammed Gamal
> <mmorsy@redhat.com>; Cathy Avery <cavery@redhat.com>; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v4 1/8] x86/hyper-v: move struct hv_flush_pcpu{,ex}
> definitions to common header
>=20
> Hyper-V TLB flush hypercalls definitions will be required for KVM so move
> them hyperv-tlfs.h. Structures also need to be renamed as '_pcpu' suffix =
is
> irrelevant for a general-purpose definition.
>=20
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>  arch/x86/hyperv/mmu.c              | 40 ++++++++++----------------------=
------
>  arch/x86/include/asm/hyperv-tlfs.h | 20 +++++++++++++++++++
>  2 files changed, 30 insertions(+), 30 deletions(-)

Vitaly,

We should  coordinate on this; I have patches in flight that conflict with
the changes here.

Regards,

K. Y
>=20
> diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c
> index 56c9ebac946f..528a1f34df96 100644
> --- a/arch/x86/hyperv/mmu.c
> +++ b/arch/x86/hyperv/mmu.c
> @@ -13,32 +13,12 @@
>  #define CREATE_TRACE_POINTS
>  #include <asm/trace/hyperv.h>
>=20
> -/* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */
> -struct hv_flush_pcpu {
> -	u64 address_space;
> -	u64 flags;
> -	u64 processor_mask;
> -	u64 gva_list[];
> -};
> -
> -/* HvFlushVirtualAddressSpaceEx, HvFlushVirtualAddressListEx hypercalls =
*/
> -struct hv_flush_pcpu_ex {
> -	u64 address_space;
> -	u64 flags;
> -	struct {
> -		u64 format;
> -		u64 valid_bank_mask;
> -		u64 bank_contents[];
> -	} hv_vp_set;
> -	u64 gva_list[];
> -};
> -
>  /* Each gva in gva_list encodes up to 4096 pages to flush */
>  #define HV_TLB_FLUSH_UNIT (4096 * PAGE_SIZE)
>=20
> -static struct hv_flush_pcpu __percpu **pcpu_flush;
> +static struct hv_tlb_flush * __percpu *pcpu_flush;
>=20
> -static struct hv_flush_pcpu_ex __percpu **pcpu_flush_ex;
> +static struct hv_tlb_flush_ex * __percpu *pcpu_flush_ex;
>=20
>  /*
>   * Fills in gva_list starting from offset. Returns the number of items a=
dded.
> @@ -71,7 +51,7 @@ static inline int fill_gva_list(u64 gva_list[], int off=
set,
>  }
>=20
>  /* Return the number of banks in the resulting vp_set */
> -static inline int cpumask_to_vp_set(struct hv_flush_pcpu_ex *flush,
> +static inline int cpumask_to_vp_set(struct hv_tlb_flush_ex *flush,
>  				    const struct cpumask *cpus)
>  {
>  	int cpu, vcpu, vcpu_bank, vcpu_offset, nr_bank =3D 1;
> @@ -81,7 +61,7 @@ static inline int cpumask_to_vp_set(struct
> hv_flush_pcpu_ex *flush,
>  		return 0;
>=20
>  	/*
> -	 * Clear all banks up to the maximum possible bank as
> hv_flush_pcpu_ex
> +	 * Clear all banks up to the maximum possible bank as
> hv_tlb_flush_ex
>  	 * structs are not cleared between calls, we risk flushing unneeded
>  	 * vCPUs otherwise.
>  	 */
> @@ -109,8 +89,8 @@ static void hyperv_flush_tlb_others(const struct
> cpumask *cpus,
>  				    const struct flush_tlb_info *info)
>  {
>  	int cpu, vcpu, gva_n, max_gvas;
> -	struct hv_flush_pcpu **flush_pcpu;
> -	struct hv_flush_pcpu *flush;
> +	struct hv_tlb_flush **flush_pcpu;
> +	struct hv_tlb_flush *flush;
>  	u64 status =3D U64_MAX;
>  	unsigned long flags;
>=20
> @@ -196,8 +176,8 @@ static void hyperv_flush_tlb_others_ex(const struct
> cpumask *cpus,
>  				       const struct flush_tlb_info *info)
>  {
>  	int nr_bank =3D 0, max_gvas, gva_n;
> -	struct hv_flush_pcpu_ex **flush_pcpu;
> -	struct hv_flush_pcpu_ex *flush;
> +	struct hv_tlb_flush_ex **flush_pcpu;
> +	struct hv_tlb_flush_ex *flush;
>  	u64 status =3D U64_MAX;
>  	unsigned long flags;
>=20
> @@ -303,7 +283,7 @@ void hyper_alloc_mmu(void)
>  		return;
>=20
>  	if (!(ms_hyperv.hints &
> HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED))
> -		pcpu_flush =3D alloc_percpu(struct hv_flush_pcpu *);
> +		pcpu_flush =3D alloc_percpu(struct hv_tlb_flush *);
>  	else
> -		pcpu_flush_ex =3D alloc_percpu(struct hv_flush_pcpu_ex *);
> +		pcpu_flush_ex =3D alloc_percpu(struct hv_tlb_flush_ex *);
>  }
> diff --git a/arch/x86/include/asm/hyperv-tlfs.h
> b/arch/x86/include/asm/hyperv-tlfs.h
> index a8897615354e..3d4ce3935a62 100644
> --- a/arch/x86/include/asm/hyperv-tlfs.h
> +++ b/arch/x86/include/asm/hyperv-tlfs.h
> @@ -713,4 +713,24 @@ struct hv_enlightened_vmcs {
>  #define HV_STIMER_AUTOENABLE		(1ULL << 3)
>  #define HV_STIMER_SINT(config)		(__u8)(((config) >> 16) &
> 0x0F)
>=20
> +/* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */
> +struct hv_tlb_flush {
> +	u64 address_space;
> +	u64 flags;
> +	u64 processor_mask;
> +	u64 gva_list[];
> +};
> +
> +/* HvFlushVirtualAddressSpaceEx, HvFlushVirtualAddressListEx hypercalls
> */
> +struct hv_tlb_flush_ex {
> +	u64 address_space;
> +	u64 flags;
> +	struct {
> +		u64 format;
> +		u64 valid_bank_mask;
> +		u64 bank_contents[];
> +	} hv_vp_set;
> +	u64 gva_list[];
> +};
> +
>  #endif
> --
> 2.14.3