Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262161AbTH2Ul0 (ORCPT ); Fri, 29 Aug 2003 16:41:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262196AbTH2Ul0 (ORCPT ); Fri, 29 Aug 2003 16:41:26 -0400 Received: from mail.kroah.org ([65.200.24.183]:38790 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262161AbTH2UkQ (ORCPT ); Fri, 29 Aug 2003 16:40:16 -0400 Date: Fri, 29 Aug 2003 13:40:17 -0700 From: Greg KH To: Arnd Bergmann Cc: OGAWA Hirofumi , Martin Schwidefsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390 (5/8): common i/o layer. Message-ID: <20030829204017.GA2580@kroah.com> References: <200308292032.h7TKWats006188@post.webmailer.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200308292032.h7TKWats006188@post.webmailer.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 23 On Fri, Aug 29, 2003 at 10:31:47PM +0200, Arnd Bergmann wrote: > OGAWA Hirofumi wrote: > > > Shouldn't the above use BUS_ID_SIZE instead of DEVICE_ID_SIZE? > > Right. Actually, all uses of DEVICE_ID_SIZE in drivers/s390 are wrong. > I'll take care of that. > > The only other user of DEVICE_ID_SIZE right now is drivers/usb/core/file.c > and I'm not sure if it's used in the intended way there. > Greg, maybe you want to get rid of it as well, or move the definition > into file.c. I'm deleting it right now... :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/