Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2354182imm; Wed, 16 May 2018 11:32:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpg6SB5XW6YjnppIaR5STD39olElax10H7VFAJJ355o1NLcHT3EvZmlpGGKW5lJ+7EqbCp7 X-Received: by 2002:a17:902:b702:: with SMTP id d2-v6mr2007733pls.228.1526495534383; Wed, 16 May 2018 11:32:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526495534; cv=none; d=google.com; s=arc-20160816; b=Dgqvg6cGO871wyTe/9ueEYpLpCCtJN//ugr5Zw1N2acuw5d/+vXcj0FC9WcveoFiqv gAqTCn/cLeJFCMlXY0yWCr1eJmkyaD/kzF9BG0+mwBUYsfPSOXKnEklYi5Lt1rKTdhN0 iKMUhzTVO/OywUMJh24k3hfEM7CjjGCufR/3epzOjxdSrzG1Ucgkm1qtB5woj1gEsu+T 6Uyy4v1pGlSdmsjuK4sd0AqHZ7x+8FO84EBUghEiNxGmRDKd4/L2DqT69tGeCAZvaI6j XstLOAP1WXJkHSO12/hSJMvmbIyypoCPXf5u+AZRWA4mMwPRaYw2jf0GPHWbhhYggkkN skPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=n+SkWUzUncpHKhkUueOmNrGSEZ3YzrqdA5JXiH8Q4so=; b=JBot7fJ/He3eryTD+V3sk0bgUNa8cfowVLsj1SKoUtk/srClVGRK57R4GuoyuQ+zA8 WE6ZPQcGOrEf6gF5mkf62q1T6brL5OAF/QXTNhj3aIE638TpBKhfVRla4l06VwOyIL77 repvor4H+nnOSwHdrkc+AmD5dYE0BonRhYlXD3MJl6FJGOfUkzkxkp6UhgcnIHlPx6T5 n7uFb03BUVQqBj8ORuT06S/kB8qdc3CicavhXz4LrhfYKEZ5psHyWMyaNH+zvWfx6KNh YXSr+4XvgLkbv/5RCY516RQnaLUFbzTfnsOVjT1liBzQxVQfT7+h/CfV/DUh/mJ5Qteb VPog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LQThFv5k; dkim=pass header.i=@codeaurora.org header.s=default header.b=LQThFv5k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j19-v6si3012629pll.518.2018.05.16.11.32.00; Wed, 16 May 2018 11:32:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=LQThFv5k; dkim=pass header.i=@codeaurora.org header.s=default header.b=LQThFv5k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbeEPSaZ (ORCPT + 99 others); Wed, 16 May 2018 14:30:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60460 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbeEPSaX (ORCPT ); Wed, 16 May 2018 14:30:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EB542602BA; Wed, 16 May 2018 18:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526495422; bh=j+oSyEkRxCaCNixAI884iD6WABLWyIsiT/fOQkate3k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LQThFv5khbqAfvhSrsvHaiLqAhVX48SiwoNImRMdQjZ2cHZn/Ww9k4GdUssv0569U djiA/ifARfDzA4elWohH+Nyuy0BDlFIwHG2lvKlCmcOFAmFbT+UibPJ2dSHC/MFR4/ Akna8h8PIYnGcN6lRwKCraTZCRzvHFQ+V8NPpzRc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AD0F7601D4; Wed, 16 May 2018 18:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526495422; bh=j+oSyEkRxCaCNixAI884iD6WABLWyIsiT/fOQkate3k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LQThFv5khbqAfvhSrsvHaiLqAhVX48SiwoNImRMdQjZ2cHZn/Ww9k4GdUssv0569U djiA/ifARfDzA4elWohH+Nyuy0BDlFIwHG2lvKlCmcOFAmFbT+UibPJ2dSHC/MFR4/ Akna8h8PIYnGcN6lRwKCraTZCRzvHFQ+V8NPpzRc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AD0F7601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Jones , Bartlomiej Zolnierkiewicz , "open list:EFIFB FRAMEBUFFER DRIVER" , "open list:FRAMEBUFFER LAYER" , open list References: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 16 May 2018 14:30:20 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/2018 2:23 PM, Sinan Kaya wrote: > + if (win_start <= base && win_end >= base + win_size - 1) { > + base += window->offset; > + break; > + } I should probably add window->offset!=0 to the if statement in order not to break non-translating case. Any other comments? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.