Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2354349imm; Wed, 16 May 2018 11:32:24 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpPomqbPVZOVa5lIYzMetfb24ix/L7DzTSAg3BWZEC37gF/qm+mtf8exmivbe1UTahyA0L5 X-Received: by 2002:a62:581:: with SMTP id 123-v6mr2098787pff.38.1526495543958; Wed, 16 May 2018 11:32:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526495543; cv=none; d=google.com; s=arc-20160816; b=B7wD68aoqJidOZVyk3GmUiZtiGNpD01F8blKg15NFpHK3njH60RudR1GqhLeANjBnp WZ9luEc+b/4Heuy8s6WX0bNhXD9KIsJrvYCJF1ucHLHIdWqDISG97GmayHYHRah16g4P IBxT5YgjHMkiB9+N9xYZVATPyPV+J0+WNRwx9+M6Rp5D+cd5+JD8srPs8IunmmWpzWKz nuzI7LBqO4971owQoKg/tkowjV+D0+lE/v/Y4m5xVrH+n4LC67ByX7RQlHGIdVsnvVOv fmn4eSiJdF2ocHgLSlwLThBXHdnf3l3TvER8i5VFa8BB1/CofurovO4sMhdBsW7VNeUN JjnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=LFzvero5n1qjwiohqaBbNay9KgtmC3yy+2O6z1a+qqI=; b=fFZYum7ftN/98d34mxM9JcR7oUZZLciilg3WM+oIoZ1uryteevnnK6L9r46jQAvk99 iPxqoTCIF3Wn5XG6Dr1SwF0iCpzxR+QBr89C4ge9CbMPF/t6Pt00OxB9ze4bgsYuFv8m cRynCELrkdBqs2Hp20YWDkO6o0FpP20KNzkNl4sIcWLs6Fp3Tpv1YzX7MT9jfrTwX8xH Tbl4y4wnq1H9ekvIrmi02csCSoL6AzafmOyO5pXj77gFKfehenwatsBEx8vm+XPR96+n 1JxqSgKGQx2FuMHJ4Y+WHrxgiQAvk+PEhZE4CiuiajqSSlN69qCmb1qRmVC6H3AFSv6Y dn7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dfyWJ804; dkim=pass header.i=@codeaurora.org header.s=default header.b=dfyWJ804; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10-v6si3184726plo.150.2018.05.16.11.32.09; Wed, 16 May 2018 11:32:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=dfyWJ804; dkim=pass header.i=@codeaurora.org header.s=default header.b=dfyWJ804; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbeEPSb7 (ORCPT + 99 others); Wed, 16 May 2018 14:31:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35520 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbeEPSb5 (ORCPT ); Wed, 16 May 2018 14:31:57 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7A137609D1; Wed, 16 May 2018 18:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526495516; bh=oLkw9nKH/kyMr/i2W3hE05UW3uBcpN5wBzrg+RPdrY8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dfyWJ804B8J0LpDs3fWVfT5DE37js5a5OTvBLbZKu71e8h+W3OsQEZdUCB1/oiULI QgMJl3s3TWNDSNa4aF/i1t/dBWQqC39L5NwM5jvEN0+iWtkgBJILZ3AE2aUSSIAz45 sYj93mAD1O4kUUx88Vd984QLB3NLPC4Vronq+/Sg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.222.143.167] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2889E602BA; Wed, 16 May 2018 18:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526495516; bh=oLkw9nKH/kyMr/i2W3hE05UW3uBcpN5wBzrg+RPdrY8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dfyWJ804B8J0LpDs3fWVfT5DE37js5a5OTvBLbZKu71e8h+W3OsQEZdUCB1/oiULI QgMJl3s3TWNDSNa4aF/i1t/dBWQqC39L5NwM5jvEN0+iWtkgBJILZ3AE2aUSSIAz45 sYj93mAD1O4kUUx88Vd984QLB3NLPC4Vronq+/Sg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2889E602BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Jones , Bartlomiej Zolnierkiewicz , "open list:EFIFB FRAMEBUFFER DRIVER" , "open list:FRAMEBUFFER LAYER" , open list References: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: <3120434b-9831-bf33-25b8-11aba1c1b648@codeaurora.org> Date: Wed, 16 May 2018 13:31:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2018 01:23 PM, Sinan Kaya wrote: > + win_start = window->res->start - window->offset; Can you guarantee that window->res->start is always >= window->offset? > + win_size = window->res->end - window->res->start + 1; Use resource_size() instead. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.