Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2365606imm; Wed, 16 May 2018 11:43:08 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrTJK3pwCT2KV/Jzq7UVJQG+TLi9BZe+hiTknotHA0EJ+yBAd62xmaEHxw0LQVpB5+oLrMz X-Received: by 2002:a17:902:7896:: with SMTP id q22-v6mr2069238pll.243.1526496188758; Wed, 16 May 2018 11:43:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526496188; cv=none; d=google.com; s=arc-20160816; b=qBvLlRQbSfkwQwa6aiLtqA9ZMeOSikpM+6WC0AmkWJGR9LTo3zIp5oq5asNIgRPZ0/ 9vvAs+XiFqV/CEcI7NTfKleufc778mCyuu4U5Cu4thdedyKFM5Von1UHjoS+9039VIlF i6b2yrL58ZojmZSD85uYNZpE8I7clD0MjljxqcmZbwXXbauAvPdL4E5IPkELN1vdVnrg ap5yLWpGzw9Kd1ujsQbkJsfgk86en35II8e23/e0OENFYHXCK7hEfWXXTNgf4+VNzAiu j9uuDz9tefVLDRnweWszV3bHVtOJxgKaZNjvhfkJXeO3+adyNnEcccfwWjfEux4J8uJg P4Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=9QlCjF/D0evXWRGHFClb6JnFHJbbbzeMZbCKRuwkhPI=; b=rw1SynYSct+B3NK/prQMLQDAR1lhetTUcBjJPqk+1OiepqBEKGXu84p/kOWaCR0gri IjKebXiSt6sEnr2GsudcVxnXIspoqvEXZOxpqRUqaWAo+ldbp51OIQPPPKZODNrsDRpE Pf+BV7edUm7ZIKb33j4oks+KTfrBUzwUCTwYefo/p7Ga6yaPJ9RTbgtcrbPgRM4pgR3f zPNoDdeaP4VR/ZhSTY5Joi0yqTEy677HLySEtDQlCqWRxyWBXgEqCE1imiI5K4y6a4yJ CXvYKehvHvv8xhDWvVnXmwq0JnSxasyje61kZJsD3k3Ou/mB5z7alcknHaYznENLnN7a BM5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=VKs6Al+S; dkim=pass header.i=@codeaurora.org header.s=default header.b=VKs6Al+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13-v6si1136826pgq.616.2018.05.16.11.42.54; Wed, 16 May 2018 11:43:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=VKs6Al+S; dkim=pass header.i=@codeaurora.org header.s=default header.b=VKs6Al+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbeEPSlR (ORCPT + 99 others); Wed, 16 May 2018 14:41:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40054 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbeEPSlP (ORCPT ); Wed, 16 May 2018 14:41:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B61FF6055C; Wed, 16 May 2018 18:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526496074; bh=f+0okIhFajPHMp1zPU392BxLy9HJ4VP/NRy0psiQhQg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VKs6Al+S1rn1fv5rOe8Fq97dSs7Jcc/5OE7NdZQsI7pd3HrzOxtiC5LvcKVLkxtRD 2p+ikaFD/ouddVp2gmydrcTdm8xqg+9RF2azPvjev0qLUS3gWb1os9oH3UVKBs9mBE gtVaK59lerl5NEZEKPHoBLjeBYlPXdV6FZ+Nk95Y= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5DD4B6055C; Wed, 16 May 2018 18:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526496074; bh=f+0okIhFajPHMp1zPU392BxLy9HJ4VP/NRy0psiQhQg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VKs6Al+S1rn1fv5rOe8Fq97dSs7Jcc/5OE7NdZQsI7pd3HrzOxtiC5LvcKVLkxtRD 2p+ikaFD/ouddVp2gmydrcTdm8xqg+9RF2azPvjev0qLUS3gWb1os9oH3UVKBs9mBE gtVaK59lerl5NEZEKPHoBLjeBYlPXdV6FZ+Nk95Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5DD4B6055C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: Timur Tabi , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Jones , Bartlomiej Zolnierkiewicz , "open list:EFIFB FRAMEBUFFER DRIVER" , "open list:FRAMEBUFFER LAYER" , open list References: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> <3120434b-9831-bf33-25b8-11aba1c1b648@codeaurora.org> From: Sinan Kaya Message-ID: <9f8ea8f6-6005-1b46-4d75-4f89e04ad9c1@codeaurora.org> Date: Wed, 16 May 2018 14:41:12 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3120434b-9831-bf33-25b8-11aba1c1b648@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/2018 2:31 PM, Timur Tabi wrote: > On 05/16/2018 01:23 PM, Sinan Kaya wrote: >> +        win_start = window->res->start - window->offset; > > Can you guarantee that window->res->start is always >= window->offset? > Resource offset is generally 0 when not translating or a positive number that you subtract from the resource start to reach to the translating window. Having a bigger offset than resource start should be considered a BIOS bug. >> +        win_size = window->res->end - window->res->start + 1; > > Use resource_size() instead. > I'll fix it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.