Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp2509504imm; Wed, 16 May 2018 14:09:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpBnhBDP6VHL9D3I5VegMzJ1AVCV4vR3Ew7ZtIRXoQNt4rWLbzkvJr31Dh65W0v/oBCZMYE X-Received: by 2002:a17:902:8c81:: with SMTP id t1-v6mr2460610plo.310.1526504988574; Wed, 16 May 2018 14:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526504988; cv=none; d=google.com; s=arc-20160816; b=SmN++caKgjqvop5MguZ8B1wuSS5h1PZTQ9te3Ab2eJdafIqFG8XfgE2nQzTFcQdiQA yc+CzyAEd9zkxBP9NMRAmk43eHlhbzvw0qPg6zi7MgtFgcMaxRAGdoqwwDaJdjHL7JQX iL3X8u9nYXhTDJs6MrU1b2tGJE89O1iduOLpwAriVLK5DyvfeZXGWf68I5Sw99sVu0HF j9LM9y84wE8V2KUflP31H5VA6aDyqbP+bgrfgf1IBdC+ofe8qhSrSg9TJJMAKRkmG85s Xt0wHl4o9k0s4upemi4eZDY36+Tn5NlpU96CdN3FC01CBIKrr+D66+PA8Z3L5//PoltA 89QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=9RW6g4wY0ZhHMPYq0BTOuj4d2etwvoSjT9Xng2IFcU4=; b=jmP5mr3tiYSUGp2OruUdUPJ7LtJh5PPt2ZV1TGFqhSD0b/+6Sa9gkAJ/QQGFA0OYL7 xMoV0bmS2R+4WYJTR9xXSK66v35s7Nbua2fBOZlNmm8c3J4Ak46+M2U2uFCrygnoqhrC rqU9YdFwrZwCAfqXfeTHfU0wWT62oFioA+ere9UW3mqDEuhn24BbAs5+EeUh/q7pTGYD v67grDqWae4mlmMG2A96UQnQOZQscrJ3WEslZuBEBULaupXf4VJdoQhRhCTvKpU0C8PN lSJpUwPr1zzX60tElnmpvEeODOqEtSywANpfJElE12xuuO1PS3pk7UrJzFpuV62XHtSH WaAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=WvXVJyJc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k17-v6si3471071pfj.310.2018.05.16.14.09.34; Wed, 16 May 2018 14:09:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=WvXVJyJc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbeEPVI7 (ORCPT + 99 others); Wed, 16 May 2018 17:08:59 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:55354 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbeEPVI4 (ORCPT ); Wed, 16 May 2018 17:08:56 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 4F25FB00940 for ; Wed, 16 May 2018 23:08:55 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1526504934; x=1527368935; bh=X5 3Kl5f+R/zDnoFjhDEW/l7kg7G4vUYC0rOrOmHxvl8=; b=WvXVJyJcLMHEjPu5Z4 X/WRUW2OXJ0JqwIMWDNfnXKQQW9HMDfDKjsJ1ZmUJH2yz2kFEv5AzmIYbAMasqz0 0sRWNAON9ZcOnpiq/nBymV+sUqdTIZF2twnUfl8jC7c9p2vz3ZwvAgcxQ14NAN6J xxQq+7OyCWvu8nD3pOT5RjaxA= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZMCPr9s4c11r for ; Wed, 16 May 2018 23:08:54 +0200 (CEST) Received: from localhost.localdomain (unknown [192.168.123.79]) by mail.micronovasrl.com (Postfix) with ESMTPSA id 79DECB0098A; Wed, 16 May 2018 23:08:52 +0200 (CEST) From: Giulio Benetti To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, Giulio Benetti Subject: [PATCH v6 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Date: Wed, 16 May 2018 23:08:42 +0200 Message-Id: <20180516210842.5874-4-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180516210842.5874-1-giulio.benetti@micronovasrl.com> References: <20180516210842.5874-1-giulio.benetti@micronovasrl.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On m41txx you can enable open-drain OUT pin to check if offset is ok. Enabling OUT pin with frequency_test_enable attribute, OUT pin will tick 512 times faster than 1s tick base. Enable or Disable FT bit on CONTROL register if freq_test is 1 or 0. Signed-off-by: Giulio Benetti --- V5 => V6 * frequency_test_enable handled as a boolean drivers/rtc/rtc-ds1307.c | 96 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 2797d01bfa1d..b2e87845d860 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1053,6 +1053,96 @@ static int m41txx_rtc_set_offset(struct device *dev, long offset) ctrl_reg); } +static ssize_t frequency_test_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct ds1307 *ds1307 = dev_get_drvdata(dev); + bool freq_test_en = 0; + int ret; + + ret = kstrtobool(buf, &freq_test_en); + if (ret == -EINVAL) { + dev_err(dev, "Failed to store RTC Frequency Test attribute\n"); + return ret; + } + + regmap_update_bits(ds1307->regmap, M41TXX_REG_CONTROL, M41TXX_BIT_FT, + freq_test_en ? M41TXX_BIT_FT : 0); + + return count; +} + +static ssize_t frequency_test_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct ds1307 *ds1307 = dev_get_drvdata(dev); + unsigned int ctrl_reg; + + regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg); + + if (ctrl_reg & M41TXX_BIT_FT) + return scnprintf(buf, PAGE_SIZE, "on\n"); + else + return scnprintf(buf, PAGE_SIZE, "off\n"); +} + +static DEVICE_ATTR_RW(frequency_test_enable); + +static struct attribute *rtc_freq_test_attrs[] = { + &dev_attr_frequency_test_enable.attr, + NULL, +}; + +static const struct attribute_group rtc_freq_test_attr_group = { + .attrs = rtc_freq_test_attrs, +}; + +static void rtc_calib_remove_sysfs_group(void *_dev) +{ + struct device *dev = _dev; + + sysfs_remove_group(&dev->kobj, &rtc_freq_test_attr_group); +} + +static int ds1307_add_frequency_test(struct ds1307 *ds1307) +{ + int err = 0; + + switch (ds1307->type) { + case m41t0: + case m41t00: + case m41t11: + /* Export sysfs entries */ + err = sysfs_create_group(&(ds1307->dev)->kobj, + &rtc_freq_test_attr_group); + if (err) { + dev_err(ds1307->dev, + "Failed to create sysfs group: %d\n", + err); + return err; + } + + err = devm_add_action_or_reset(ds1307->dev, + rtc_calib_remove_sysfs_group, + ds1307->dev); + if (err) { + dev_err(ds1307->dev, + "Failed to add sysfs cleanup action: %d\n", + err); + sysfs_remove_group(&(ds1307->dev)->kobj, + &rtc_freq_test_attr_group); + return err; + } + break; + default: + break; + } + + return err; +} + /*----------------------------------------------------------------------*/ static int ds1307_nvram_read(void *priv, unsigned int offset, void *val, @@ -1794,6 +1884,12 @@ static int ds1307_probe(struct i2c_client *client, if (err) return err; + err = ds1307_add_frequency_test(ds1307); + if (err) { + rtc_device_unregister(ds1307->rtc); + return err; + } + if (chip->nvram_size) { struct nvmem_config nvmem_cfg = { .name = "ds1307_nvram", -- 2.17.0