Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1526513565.9159.153.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 60/97] clk: mvebu: armada-38x: add support for
 1866MHz variants
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Ralph Sennhauser <ralph.sennhauser@gmail.com>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Stephen Boyd <sboyd@codeaurora.org>
Cc:     stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Thu, 17 May 2018 00:32:45 +0100
In-Reply-To: <20180422135308.591594256@linuxfoundation.org>
References: <20180422135304.577223025@linuxfoundation.org>
         <20180422135308.591594256@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2018-04-22 at 15:53 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> 
> commit 9593f4f56cf5d1c443f66660a0c7f01de38f979d upstream.
> 
> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
> 
> Noticed by the following warning:
> [    0.000000] Selected CPU frequency (16) unsupported

So the frequency selection field is read as 16...

[...]
> --- a/drivers/clk/mvebu/armada-38x.c
> +++ b/drivers/clk/mvebu/armada-38x.c
> @@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequenc
>  	0, 0, 0, 0,
>  	1066 * 1000 * 1000, 0, 0, 0,
>  	1332 * 1000 * 1000, 0, 0, 0,
> -	1600 * 1000 * 1000,
> +	1600 * 1000 * 1000, 0, 0, 0,
> +	1866 * 1000 * 1000,
>  };
[...]

...but this only adds entries to the lookup table at indexes 9-12
inclusive.

It looks like this fixes the clock settings, but not the warning.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.