Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3259881imm; Thu, 17 May 2018 06:06:09 -0700 (PDT) X-Google-Smtp-Source: AB8JxZowlvPn66CAs379ROJyH8nJfqc5KSwveTQu+Rjw+34peUM6s0eUMR9qExuDT8difjAopNZd X-Received: by 2002:a17:902:4545:: with SMTP id m63-v6mr5288136pld.268.1526562368967; Thu, 17 May 2018 06:06:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526562368; cv=none; d=google.com; s=arc-20160816; b=qCU2RdECirNP97PD+JX0BBEe2KDx3cw5ax+r0nx1sTxvCsFgk51BgXDApxqd81sTYH CX8bxCliaqRxXj7K6hhaoBrtK/F+7zBYc2tYWWa6mnuXXd0RT/O9DSAF7S3l6aLCOr1Y +6SRhkXpXNwoRVyYdtqSeox4yAJZp0vnphGRhPrUu0toPmThY+rhTjksnRIasQjbDNDC Jpt6yGmJyE2Z3K3JHzwK70QQVhVbEoEIvEL5G0V5m7IvIxCHuBLCeGGauS1qfAU8mgwZ PJZ9nYsulximCgDkP7QBftOtW1kUp3t/swWyB3NOnnP+TWkAjIg7VGGBXqNY1J/bkswh NrRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:arc-authentication-results; bh=KIbJEiIxNLXpz4jtHFrORV2NewYlh7AWbD8qcAh1Iko=; b=TGU7ZxM/NvjPPYQNzirOgyHSa7YUmHtkszrwxz1drqpFQ7JCoNmzu4SPxhKlgH0UI4 BaBWKBTkW+JZgxc3QbO6MsJXinCiP5GCLlWasCVINm3S1ZFJ1H4H91cuCwamWB7rR4yT Dd7jSCCuQouLky9dtYOqPV7cwYsYCQWbwSo901RLLHmijbt7lWK4tyy7UM5Y4Sh/6BDv y1vZATpLI0lbVH59dG4XeiNSIjjjEDYPt4z4Tmntec+ADpTf2SBbcdmDuFijs+6xtzxj 8Nc3aULygiTSutTTGaZ9WnXTwXEBb/fmQzsoTTDp/9Kpy5jIvqOv0fVP3Z9MuvkH/P4Q EfPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7-v6si5038441pfa.78.2018.05.17.06.05.53; Thu, 17 May 2018 06:06:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbeEQNFP (ORCPT + 99 others); Thu, 17 May 2018 09:05:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:34228 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbeEQNFN (ORCPT ); Thu, 17 May 2018 09:05:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7A386ABCF; Thu, 17 May 2018 13:05:12 +0000 (UTC) Message-ID: <1526561908.15506.5.camel@suse.com> Subject: Re: [PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work From: Oliver Neukum To: Alexander Kappner , Alan Stern Cc: gregkh@linuxfoundation.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Thu, 17 May 2018 14:58:28 +0200 In-Reply-To: <9c638d96-d2b4-cf19-d7e8-4ef93549bd79@godking.net> References: <9c638d96-d2b4-cf19-d7e8-4ef93549bd79@godking.net> Content-Type: multipart/mixed; boundary="=-h7qlglWApRe8X3b59KHS" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-h7qlglWApRe8X3b59KHS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Am Donnerstag, den 17.05.2018, 01:15 -0700 schrieb Alexander Kappner: > Yes. Without this flag, the device keeps throwing similar errors on > usb-storage. That's the same result I get on a host that doesn't have UAS > compiled in. Here's a dmesg: Hi, this is suspicious. You do not actually whether US_FL_NO_WP_DETECT by itself would make the device work. Can you please test that? You will need the attached patch for the quirk to be supported. Regards Oliver --=-h7qlglWApRe8X3b59KHS Content-Disposition: attachment; filename="0001-UAS-add-support-for-the-quirk-US_FL_NO_WP_DETECT.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-UAS-add-support-for-the-quirk-US_FL_NO_WP_DETECT.patch"; charset="UTF-8" RnJvbSAxZmY2YzljOWNjNjZkZGI0Y2Y3Y2E5NWJlYTU4OWQ2YTMwYzYzNjIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGl2ZXIgTmV1a3VtIDxvbmV1a3VtQHN1c2UuY29tPgpEYXRl OiBUaHUsIDE3IE1heSAyMDE4IDE0OjQ2OjQ3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gVUFTOiBh ZGQgc3VwcG9ydCBmb3IgdGhlIHF1aXJrIFVTX0ZMX05PX1dQX0RFVEVDVAoKVGhlIGFzc3VtcHRp b24gdGhhdCB0aGlzIHF1aXJrIGNhbiBiZSBsaW1pdGVkIHRvIG9sZCBzdG9yYWdlCmRldmljZXMg d2FzIHRvbyBvcHRpbWlzdGljLgoKU2lnbmVkLW9mZi1ieTogT2xpdmVyIE5ldWt1bSA8b25ldWt1 bUBzdXNlLmNvbT4KLS0tCiBkcml2ZXJzL3VzYi9zdG9yYWdlL3Vhcy5jIHwgNCArKysrCiAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc3Rv cmFnZS91YXMuYyBiL2RyaXZlcnMvdXNiL3N0b3JhZ2UvdWFzLmMKaW5kZXggNjAzNGMzOWI2N2Qx Li43ZWU2N2U4YzFmMWUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL3N0b3JhZ2UvdWFzLmMKKysr IGIvZHJpdmVycy91c2Ivc3RvcmFnZS91YXMuYwpAQCAtODM2LDYgKzgzNiwxMCBAQCBzdGF0aWMg aW50IHVhc19zbGF2ZV9jb25maWd1cmUoc3RydWN0IHNjc2lfZGV2aWNlICpzZGV2KQogCWlmIChk ZXZpbmZvLT5mbGFncyAmIFVTX0ZMX0JST0tFTl9GVUEpCiAJCXNkZXYtPmJyb2tlbl9mdWEgPSAx OwogCisJLyogVUFTIGFsc28gbmVlZHMgdG8gc3VwcG9ydCBGTF9OT19XUF9ERVRFQ1QgKi8KKwlp ZiAoZGV2aW5mby0+ZmxhZ3MgJiBVU19GTF9OT19XUF9ERVRFQ1QpCisJCXNkZXYtPnNraXBfbXNf cGFnZV8zZiA9IDE7CisKIAlzY3NpX2NoYW5nZV9xdWV1ZV9kZXB0aChzZGV2LCBkZXZpbmZvLT5x ZGVwdGggLSAyKTsKIAlyZXR1cm4gMDsKIH0KLS0gCjIuMTMuNgoK --=-h7qlglWApRe8X3b59KHS--