Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3312118imm; Thu, 17 May 2018 06:55:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZozTY40Q+VaFjgGTt0tSNYjCMl3kIWG7oVVZeYaApZxFfAi9oomSi6W4F8kD5n1BR2lzABT X-Received: by 2002:a17:902:70c4:: with SMTP id l4-v6mr5357330plt.174.1526565317881; Thu, 17 May 2018 06:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526565317; cv=none; d=google.com; s=arc-20160816; b=CLzowUxQsGZn4uZExDOcHxnbrs2arNIbAWcntieZ7qy4jbcp1ggPIGLiiIb8DYtVWi ejifU7qFQBCMxv+Qm1ISpSctMk1LLTYzGa4465nlkiuM4XU9fMDc2h9HeA01GlxvDnOd UzmVo7k5HYHYQ6aefZ2F71v/w/7atUwg1G9W2Rq0L50ANdQGU9lKV9B7B2WxookxMdP3 +uty64TTqyU9RxL/WIH2RhQd+grVmIG2BS6SElLd8QBD8OdQMGr91JcAUyDmlQ82rCRs 1s0kx5FClMoyJeRHvk+Ak5Yqp9RuIKHsuRe5IML9bJJ1mMQGT/jhu0W01+yp5aWr5UJ7 //JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=SwEQ1y4ZaVVcQy/MqumSQ1IjLvLC2E20fJHPk6DUqy4=; b=0JCLCrS1pflKF0P4raUCaODrPyAt4Gi8KCEUh88BKPLM8s0r8xvywNZUNc06v8y+Rq yqUlG9cB00BlpG/pR7K3w4F7EcFvO6NsmLCgTc2G9jVvKwt+zIXD1vwIQhkE4hPDzEPm hLlsGGxs8pG2izytuMRRYZ2GYl2EKLBr4mVKnLKeiPdmBTiWsllvgLmndW7wYXRTFZ3n ywExpU8PGd2AgqzDcL2/MecaZm3Ml/ml//T1/SQ7o+S03BkGQkuvXHCRBVi6j0ftSj7W 4TFt3HuQPqTZrF5VAwk3nq91KaNRXGo7cjVhHf8eUA0h79v8X2a+lS/PvZkW/PoEzbrX DGQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6-v6si5227843pls.583.2018.05.17.06.55.03; Thu, 17 May 2018 06:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbeEQNy4 (ORCPT + 99 others); Thu, 17 May 2018 09:54:56 -0400 Received: from sauhun.de ([88.99.104.3]:51438 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbeEQNyz (ORCPT ); Thu, 17 May 2018 09:54:55 -0400 Received: from localhost (p54B3345A.dip0.t-ipconnect.de [84.179.52.90]) by pokefinder.org (Postfix) with ESMTPSA id 02D6C3640A7; Thu, 17 May 2018 15:54:53 +0200 (CEST) Date: Thu, 17 May 2018 15:54:53 +0200 From: Wolfram Sang To: Anders Roxell Cc: jdelvare@suse.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: i801: fix unused-function warning Message-ID: <20180517135453.ori4uopsqnxn6wte@ninjato> References: <20180510152719.6e37b10e@endymion> <20180514093326.30314-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vro5bi3toditkjgc" Content-Disposition: inline In-Reply-To: <20180514093326.30314-1-anders.roxell@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vro5bi3toditkjgc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 14, 2018 at 11:33:26AM +0200, Anders Roxell wrote: > With CONFIG_PM, we get a harmless build warning: > drivers/i2c/busses/i2c-i801.c:1723:12: warning: =E2=80=98i801_resume=E2= =80=99 defined but not used [-Wunused-function] > static int i801_resume(struct device *dev) > ^~~~~~~~~~~ > drivers/i2c/busses/i2c-i801.c:1714:12: warning: =E2=80=98i801_suspend=E2= =80=99 defined but not used [-Wunused-function] > static int i801_suspend(struct device *dev) > ^~~~~~~~~~~~ >=20 > Follow design pattern from other drivers like i2c-brcmstb, i2c-mpc, > i2c-ocores, i2c-pnx, i2c-puv3, i2c-st, i2c-stu300 and i2c-mux-pca954x > and changing the ifdef CONFIG_PM to CONFIG_PM_SLEEP. >=20 > Fixes: a9c8088c7988 ("i2c: i801: Don't restore config registers on runtim= e PM") > Signed-off-by: Anders Roxell Applied to for-next, thanks! --vro5bi3toditkjgc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlr9ia0ACgkQFA3kzBSg KbadwA/9GsKwsmiOW7KLc3Cfv86pVOZaEF8HPeccuW+fkZk4hu+9mEtta6fE43bH rBFAGAcbzU7Uv73zZ8OEogLPB+EnI3r/vrMD+3dvpBLlQOJ2sp1uzBg1JiZz+MsR OJa1a+WFC3s2J3AYCWUNJ2cc83YLSiImQQLJfgtDyCUJGPcMrTetx3r85lZfM0Dd Nvaab1Pg7gkbuAsaynTs7NUPqngSc3lHkKUfB1TW0Dx2rGFVg3lw342pfh//VJwq wfBm2CsNwGY1EN5xXcN6A+FQVhUYCfGKq9FvaawGCya6c7jDapOTe86AN16FbnUw bfyWmudlVrnPg8a4KdGiDpmNinUHcCdvgh4zrWES45Z5Sp7PvXKKjy746ziULZRe stdel7ov36WtghkLl9ncABWuZLXJPoE34GRem2xwqisvLqSTGvRTTNlq5zpyTQv9 m2TTlAmbvxEzZShf0EU7BFbZ/LUKXK3ThRgMogrulp4H3DhP1xSq0umx5F/3x8o7 zmrlxB1bft2L/DLqxmYffRF8Qe4yjQeAc61/RNrfmdu7HYseuYs00cC9ZYHS1f1v pydbP5ECgGszAgeBJOLeCQ8rwt2enPTMarPMy6svRKBu3kw1zMau0jrq8bLM6dfJ zD2BSL3Wwyqsau8pBV8xVzCZtZ8LUbtDFEtsAoEEeKbfddnX0wQ= =X2Ca -----END PGP SIGNATURE----- --vro5bi3toditkjgc--